Commit 81fbecf0 authored by Ian Vollick's avatar Ian Vollick Committed by Commit Bot

[vr] Disable text suggestions in immersive mode

This feature is not currently supported, though we hope to add support
soon. This work is tracked in crbug.com/779126

Bug: 818012
Change-Id: Ib677f7ea62b9f681ba494c27367b286a122dd10f
Reviewed-on: https://chromium-review.googlesource.com/944543
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541461}
parent 4828a3ee
...@@ -19,6 +19,7 @@ ...@@ -19,6 +19,7 @@
#include "core/editing/suggestion/TextSuggestionInfo.h" #include "core/editing/suggestion/TextSuggestionInfo.h"
#include "core/frame/FrameView.h" #include "core/frame/FrameView.h"
#include "core/frame/LocalFrame.h" #include "core/frame/LocalFrame.h"
#include "core/frame/Settings.h"
#include "core/layout/LayoutTheme.h" #include "core/layout/LayoutTheme.h"
#include "services/service_manager/public/cpp/interface_provider.h" #include "services/service_manager/public/cpp/interface_provider.h"
...@@ -206,6 +207,10 @@ bool TextSuggestionController::IsMenuOpen() const { ...@@ -206,6 +207,10 @@ bool TextSuggestionController::IsMenuOpen() const {
void TextSuggestionController::HandlePotentialSuggestionTap( void TextSuggestionController::HandlePotentialSuggestionTap(
const PositionInFlatTree& caret_position) { const PositionInFlatTree& caret_position) {
// TODO(crbug.com/779126): add support for suggestions in immersive mode.
if (GetDocument().GetSettings()->GetImmersiveModeEnabled())
return;
// It's theoretically possible, but extremely unlikely, that the user has // It's theoretically possible, but extremely unlikely, that the user has
// managed to tap on some text after TextSuggestionController has told the // managed to tap on some text after TextSuggestionController has told the
// browser to open the text suggestions menu, but before the browser has // browser to open the text suggestions menu, but before the browser has
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment