Commit 82041208 authored by Lan Wei's avatar Lan Wei Committed by Commit Bot

[Chromedriver] Do not need release events for wheel events

In Chromedriver's ExecutePerformActions, we put the mouse events which
have a button pressed in a list of input_cancel_list in the session, so
we will release any pressed buttons at the end of each test.

For mouse wheel events we also generate mouse events with type of
"wheel", and it does not support any pressed button, so we should not
push the mouse event in the input_cancel_list.

Bug: 1040611
Change-Id: I3f651a26b9137dbd8e7754d62852be64f44d5e6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387546Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803673}
parent 2df15e26
......@@ -1662,8 +1662,6 @@ Status ExecutePerformActions(Session* session,
event.delta_y = delta_y;
buttons[id] |= StringToModifierMouseButton(button_type[id]);
session->mouse_position = WebPoint(event.x, event.y);
session->input_cancel_list.emplace_back(
action_input_states[j], &event, nullptr, nullptr);
dispatch_wheel_events.push_back(event);
Status status = web_view->DispatchMouseEvents(
dispatch_wheel_events, session->GetCurrentFrameId(),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment