Commit 822d7cb2 authored by Hyunjune's avatar Hyunjune Committed by Commit Bot

Revert "Fix that mask containing image with clip-path can not apply to client"

Reason for revert: After a patch[1], this issue is fixed. So this patch is not needed anymore.
Because pass a if statement relied to check cull-rect and a function called |ClearInvalidationMask| is called in painting time.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2050382

Original change's description:
> Fix that mask containing image with clip-path can not apply to client
>
> When image contained mask is loading, it touches a mask flag called
> |computed_invalidation_mask_|.
> Because |MarkForLayoutAndParentResourceInvalidation| is called in
> |ImageChanged| without layout while loading, so this flag would be
> changed without clear. And this flag is used in the next layout.
> Actually this mask can not apply to client element in next time.
> This patch clears the mask flag in pre-paint time.
>
> Bug: 1086070
> Change-Id: I55a7a16faafe4eeefac88e8e15e6d3b18b097acf
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432151
> Reviewed-by: Fredrik Söderquist <fs@opera.com>
> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com>
> Cr-Commit-Position: refs/heads/master@{#813061}

TBR=fs@opera.com,hyunjune.kim@samsung.com,schenney@chromium.org

Change-Id: Ifca23ff31590ebc13e1b5a7492c04724847e748f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1086070
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460527Reviewed-by: default avatarFredrik Söderquist <fs@opera.com>
Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com>
Cr-Commit-Position: refs/heads/master@{#815117}
parent fcffa1cc
......@@ -27,7 +27,6 @@ base::Optional<IntRect> CSSMaskPainter::MaskBoundingBox(
SVGResources::ReferenceBoxForEffects(object);
const float reference_box_zoom =
object.IsSVGForeignObject() ? object.StyleRef().EffectiveZoom() : 1;
masker->ClearInvalidationMask();
return EnclosingIntRect(
masker->ResourceBoundingBox(reference_box, reference_box_zoom));
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment