[SyntheticModules] Address follow-up comments from "Implements...
[SyntheticModules] Address follow-up comments from "Implements ValueWrapperSyntheticModuleScript::Create" CL The following CL: https://chromium-review.googlesource.com/c/chromium/src/+/1694604 Contains a few comments left by nhiroki@chromium.org which didn't make it into the CL until after it was merged. This is a follow-up CL designed to address these comments. The comments are: third_party/blink/renderer/core/script/value_wrapper_synthetic_module_script.cc: Line 22: "Non-member variables shouldn't have trailing `_`, so this should be `options`." Line 55: "According to the spec, the base URL and fetch options are null, while in this CL they are set to non-null things. Is this intentional?" Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=967018 Change-Id: Ie579d0f0d0429e32304b5f01e2e9454ee4cad044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727519Reviewed-by:Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#683349}
Showing
Please register or sign in to comment