Inline static Create() factory functions from renderer/modules/mediastream

This CL removes Create() factory functions in
//third_partyb/blink/renderer/modules/mediastream as much as possible,
and makes all callers use MakeGarbageCollected<Foo> instead.

This CL removes below factory functions,
  - MediaStreamEvent::Create
  - ApplyConstraintsRequest::Create
  - InputDeviceInfo::Create
  - MediaStreamTrackEvent::Create

Bug: 939691
Change-Id: If665d5a2d90cf01c209c9fbb97f69efc73421823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947617Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#721441}

third_party/blink/renderer/modules/mediastream/apply_constraints_request.cc

@@ -7,16 +7,10 @@
 #include "third_party/blink/renderer/bindings/core/v8/script_promise_resolver.h"
 #include "third_party/blink/renderer/core/dom/dom_exception.h"
 #include "third_party/blink/renderer/modules/mediastream/overconstrained_error.h"
+#include "third_party/blink/renderer/platform/heap/heap.h"
 
 namespace blink {
 
-ApplyConstraintsRequest* ApplyConstraintsRequest::CreateForTesting(
-    const WebMediaStreamTrack& track,
-    const WebMediaConstraints& constraints) {
-  return MakeGarbageCollected<ApplyConstraintsRequest>(track, constraints,
-                                                       nullptr);
-}
-
 ApplyConstraintsRequest::ApplyConstraintsRequest(
     const WebMediaStreamTrack& track,
     const WebMediaConstraints& constraints,
@@ -41,7 +35,8 @@ void ApplyConstraintsRequest::RequestSucceeded() {
 void ApplyConstraintsRequest::RequestFailed(const String& constraint,
                                             const String& message) {
   if (resolver_) {
-    resolver_->Reject(OverconstrainedError::Create(constraint, message));
+    resolver_->Reject(
+        MakeGarbageCollected<OverconstrainedError>(constraint, message));
   }
   track_.Reset();
 }

third_party/blink/renderer/modules/mediastream/apply_constraints_request.h

@@ -18,9 +18,6 @@ class ScriptPromiseResolver;
 class MODULES_EXPORT ApplyConstraintsRequest final
     : public GarbageCollected<ApplyConstraintsRequest> {
  public:
-  static ApplyConstraintsRequest* CreateForTesting(const WebMediaStreamTrack&,
-                                                   const WebMediaConstraints&);
-
   ApplyConstraintsRequest(const WebMediaStreamTrack&,
                           const WebMediaConstraints&,
                           ScriptPromiseResolver*);

third_party/blink/renderer/modules/mediastream/input_device_info.cc

@@ -42,14 +42,6 @@ WebMediaStreamTrack::FacingMode ToWebFacingMode(mojom::FacingMode facing_mode) {
 
 }  // namespace
 
-InputDeviceInfo* InputDeviceInfo::Create(const String& device_id,
-                                         const String& label,
-                                         const String& group_id,
-                                         MediaDeviceType device_type) {
-  return MakeGarbageCollected<InputDeviceInfo>(device_id, label, group_id,
-                                               device_type);
-}
-
 InputDeviceInfo::InputDeviceInfo(const String& device_id,
                                  const String& label,
                                  const String& group_id,

third_party/blink/renderer/modules/mediastream/input_device_info.h

@@ -16,11 +16,6 @@ class InputDeviceInfo final : public MediaDeviceInfo {
   DEFINE_WRAPPERTYPEINFO();
 
  public:
-  static InputDeviceInfo* Create(const String& device_id,
-                                 const String& label,
-                                 const String& group_id,
-                                 MediaDeviceType);
-
   InputDeviceInfo(const String& device_id,
                   const String& label,
                   const String& group_id,

third_party/blink/renderer/modules/mediastream/media_devices.cc

@@ -304,8 +304,9 @@ void MediaDevices::DevicesEnumerated(
       if (device_type == mojom::blink::MediaDeviceType::MEDIA_AUDIO_INPUT ||
           device_type == mojom::blink::MediaDeviceType::MEDIA_VIDEO_INPUT) {
         InputDeviceInfo* input_device_info =
-            InputDeviceInfo::Create(device_info->device_id, device_info->label,
-                                    device_info->group_id, device_type);
+            MakeGarbageCollected<InputDeviceInfo>(
+                device_info->device_id, device_info->label,
+                device_info->group_id, device_type);
         if (device_type == mojom::blink::MediaDeviceType::MEDIA_VIDEO_INPUT &&
             !video_input_capabilities.IsEmpty()) {
           input_device_info->SetVideoInputCapabilities(

third_party/blink/renderer/modules/mediastream/media_error_state.cc

@@ -31,6 +31,7 @@
 #include "third_party/blink/renderer/modules/mediastream/media_error_state.h"
 
 #include "third_party/blink/renderer/modules/mediastream/overconstrained_error.h"
+#include "third_party/blink/renderer/platform/heap/heap.h"
 
 namespace blink {
 
@@ -118,7 +119,7 @@ String MediaErrorState::GetErrorMessage() {
 DOMExceptionOrOverconstrainedError MediaErrorState::CreateError() {
   DCHECK(error_type_ == kConstraintError);
   return DOMExceptionOrOverconstrainedError::FromOverconstrainedError(
-      OverconstrainedError::Create(constraint_, message_));
+      MakeGarbageCollected<OverconstrainedError>(constraint_, message_));
 }
 
 }  // namespace blink

third_party/blink/renderer/modules/mediastream/media_stream.cc

@@ -438,8 +438,8 @@ void MediaStream::RemoveTrackByComponentAndFireEvents(
   MediaStreamTrack* track = (*tracks)[index];
   track->UnregisterMediaStream(this);
   tracks->EraseAt(index);
-  ScheduleDispatchEvent(
-      MediaStreamTrackEvent::Create(event_type_names::kRemovetrack, track));
+  ScheduleDispatchEvent(MakeGarbageCollected<MediaStreamTrackEvent>(
+      event_type_names::kRemovetrack, track));
 
   if (active() && EmptyOrOnlyEndedTracks()) {
     descriptor_->SetActive(false);
@@ -460,8 +460,8 @@ void MediaStream::AddTrackAndFireEvents(MediaStreamTrack* track) {
   track->RegisterMediaStream(this);
   descriptor_->AddComponent(track->Component());
 
-  ScheduleDispatchEvent(
-      MediaStreamTrackEvent::Create(event_type_names::kAddtrack, track));
+  ScheduleDispatchEvent(MakeGarbageCollected<MediaStreamTrackEvent>(
+      event_type_names::kAddtrack, track));
 
   if (!active() && !track->Ended()) {
     descriptor_->SetActive(true);

third_party/blink/renderer/modules/mediastream/media_stream_event.cc

@@ -26,11 +26,6 @@
 
 namespace blink {
 
-MediaStreamEvent* MediaStreamEvent::Create(const AtomicString& type,
-                                           MediaStream* stream) {
-  return MakeGarbageCollected<MediaStreamEvent>(type, stream);
-}
-
 MediaStreamEvent* MediaStreamEvent::Create(
     const AtomicString& type,
     const MediaStreamEventInit* initializer) {

third_party/blink/renderer/modules/mediastream/media_stream_event.h

@@ -40,7 +40,6 @@ class MediaStreamEvent final : public Event {
   MediaStreamEvent(const AtomicString& type, const MediaStreamEventInit*);
   ~MediaStreamEvent() override;
 
-  static MediaStreamEvent* Create(const AtomicString& type, MediaStream*);
   static MediaStreamEvent* Create(const AtomicString& type,
                                   const MediaStreamEventInit* initializer);
 

third_party/blink/renderer/modules/mediastream/media_stream_track_event.cc

@@ -28,11 +28,6 @@
 
 namespace blink {
 
-MediaStreamTrackEvent* MediaStreamTrackEvent::Create(const AtomicString& type,
-                                                     MediaStreamTrack* track) {
-  return MakeGarbageCollected<MediaStreamTrackEvent>(type, track);
-}
-
 MediaStreamTrackEvent::MediaStreamTrackEvent(const AtomicString& type,
                                              MediaStreamTrack* track)
     : Event(type, Bubbles::kNo, Cancelable::kNo), track_(track) {

third_party/blink/renderer/modules/mediastream/media_stream_track_event.h

@@ -39,8 +39,6 @@ class MediaStreamTrackEvent final : public Event {
  public:
   ~MediaStreamTrackEvent() override;
 
-  static MediaStreamTrackEvent* Create(const AtomicString& type,
-                                       MediaStreamTrack*);
   static MediaStreamTrackEvent* Create(const AtomicString& type,
                                        const MediaStreamTrackEventInit*);
 

third_party/blink/renderer/modules/mediastream/user_media_client_test.cc

@@ -36,6 +36,7 @@
 #include "third_party/blink/renderer/modules/mediastream/mock_constraint_factory.h"
 #include "third_party/blink/renderer/modules/mediastream/mock_media_stream_video_source.h"
 #include "third_party/blink/renderer/modules/mediastream/mock_mojo_media_stream_dispatcher_host.h"
+#include "third_party/blink/renderer/platform/heap/heap.h"
 #include "third_party/blink/renderer/platform/mediastream/media_stream_audio_processor_options.h"
 #include "third_party/blink/renderer/platform/mediastream/media_stream_audio_source.h"
 #include "third_party/blink/renderer/platform/testing/io_task_runner_testing_platform_support.h"
@@ -627,8 +628,8 @@ class UserMediaClientTest : public ::testing::Test {
       factory.basic().frame_rate.SetExact(*frame_rate);
 
     auto* apply_constraints_request =
-        blink::ApplyConstraintsRequest::CreateForTesting(
-            web_track, factory.CreateWebMediaConstraints());
+        MakeGarbageCollected<blink::ApplyConstraintsRequest>(
+            web_track, factory.CreateWebMediaConstraints(), nullptr);
     user_media_client_impl_->ApplyConstraints(apply_constraints_request);
     base::RunLoop().RunUntilIdle();
   }

third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc

@@ -2786,8 +2786,8 @@ void RTCPeerConnection::DidAddReceiverPlanB(
           MediaStream::Create(GetExecutionContext(), descriptor,
                               std::move(audio_tracks), std::move(video_tracks));
       // Schedule to fire "pc.onaddstream".
-      ScheduleDispatchEvent(
-          MediaStreamEvent::Create(event_type_names::kAddstream, stream));
+      ScheduleDispatchEvent(MakeGarbageCollected<MediaStreamEvent>(
+          event_type_names::kAddstream, stream));
     } else {
       // The stream already exists, add the track to it.
       // This will cause to schedule to fire "stream.onaddtrack".
@@ -2829,8 +2829,8 @@ void RTCPeerConnection::DidRemoveReceiverPlanB(
       // need for |StreamEnded|.
       stream->StreamEnded();
       stream->UnregisterObserver(this);
-      ScheduleDispatchEvent(
-          MediaStreamEvent::Create(event_type_names::kRemovestream, stream));
+      ScheduleDispatchEvent(MakeGarbageCollected<MediaStreamEvent>(
+          event_type_names::kRemovestream, stream));
     }
   }
 
@@ -2954,13 +2954,13 @@ void RTCPeerConnection::DidModifyTransceivers(
   // Legacy APIs: "pc.onaddstream" and "pc.onremovestream".
   for (const auto& current_stream : current_streams) {
     if (!previous_streams.Contains(current_stream)) {
-      ScheduleDispatchEvent(MediaStreamEvent::Create(
+      ScheduleDispatchEvent(MakeGarbageCollected<MediaStreamEvent>(
           event_type_names::kAddstream, current_stream));
     }
   }
   for (const auto& previous_stream : previous_streams) {
     if (!current_streams.Contains(previous_stream)) {
-      ScheduleDispatchEvent(MediaStreamEvent::Create(
+      ScheduleDispatchEvent(MakeGarbageCollected<MediaStreamEvent>(
           event_type_names::kRemovestream, previous_stream));
     }
   }