Commit 828f303b authored by Yoshifumi Inoue's avatar Yoshifumi Inoue Committed by Chromium LUCI CQ

Revert "Utilize EphemeralRange::IsCollapsed() in ComputeAdjustedSelection()"

This reverts commit 5ab6138e.

Reason for revert: Due by http://crbug.com/1154761

Original change's description:
> Utilize EphemeralRange::IsCollapsed() in ComputeAdjustedSelection()
>
> This patch makes |ComputeAdjustedSelection()| to utilize |IsCollapsed()|
> of |EphemeralRange|[1] to simplify source code for improving code health.
>
> Note: This patch doesn't change behavior.
>
> [1] http://crrev.com/c/2550834: [editing] Ranges with equivalent positions
> should be collapsed
>
> Change-Id: Iab464fafb0f02f90d346bc1cbc0a2734d6744138
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567146
> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Koji Ishii <kojii@chromium.org>
> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#832722}

# Not skipping CQ checks because original CL landed > 1 day ago.

TBR=yosin@chromium.org

Change-Id: Ifa4fe1a3e27ef78858123b0027cab2f59a1cca48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576063
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#834107}
parent ae812c0c
......@@ -43,9 +43,10 @@ template <typename Strategy>
SelectionTemplate<Strategy> ComputeAdjustedSelection(
const SelectionTemplate<Strategy> selection,
const EphemeralRangeTemplate<Strategy>& range) {
if (range.IsCollapsed()) {
if (range.StartPosition().CompareTo(range.EndPosition()) == 0) {
return typename SelectionTemplate<Strategy>::Builder()
.Collapse(range.StartPosition())
.Collapse(selection.IsBaseFirst() ? range.StartPosition()
: range.EndPosition())
.Build();
}
if (selection.IsBaseFirst()) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment