Remove code duplication for copying OpenURLParams into LoadURLParams.
There was quite a bit of code duplication related to copying OpenURLParams into LoadURLParams. Some callsites didn't copy all the navigation properties (leading to the DCHECK reported in https://crbug.com/1007041 and possibly also to some of renderer kills reported in https://crbug.com/1014483). This CL tries to improve the situation, by moving the copying code into a new constructor of LoadURLParams and reusing the constructor from as many places as possible. Bug: 1007041, 1014483 Change-Id: Ibeefd97118a78f5a2b3779e51d83731c546fd113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853910 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#709132}
Showing
Please register or sign in to comment