Commit 82b284c1 authored by Ghazale Hosseinabadi's avatar Ghazale Hosseinabadi Committed by Commit Bot

Remove flaky test for WINDOWS_GETCURRENT API

This CL removes WINDOWS_GETCURRENT API test coverage from
ServiceWorkerBasedBackgroundTest. The reason is 1)The test is flaky, 2)The API test coverage is already added in NonPersistentExtensionTabsTest.TabCurrentWindow.

Bug: 1140254
Change-Id: I90d93a27d3c3f420b2a12f17a38503850f33bf79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487868Reviewed-by: default avatarDavid Bertoni <dbertoni@chromium.org>
Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819399}
parent 21793cfe
...@@ -420,9 +420,6 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBasedBackgroundTest, WindowsBasic) { ...@@ -420,9 +420,6 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerBasedBackgroundTest, WindowsBasic) {
EXPECT_EQ(1, histogram_tester.GetBucketCount( EXPECT_EQ(1, histogram_tester.GetBucketCount(
"Extensions.Functions.ExtensionServiceWorkerCalls", "Extensions.Functions.ExtensionServiceWorkerCalls",
functions::HistogramValue::WINDOWS_GET)); functions::HistogramValue::WINDOWS_GET));
EXPECT_EQ(1, histogram_tester.GetBucketCount(
"Extensions.Functions.ExtensionServiceWorkerCalls",
functions::HistogramValue::WINDOWS_GETCURRENT));
} }
// Tests chrome.webRequest APIs. // Tests chrome.webRequest APIs.
......
...@@ -27,14 +27,6 @@ var getWindowUtil = function(windowId, getCallback) { ...@@ -27,14 +27,6 @@ var getWindowUtil = function(windowId, getCallback) {
} }
} }
var getCurrentWindowUtil = function(getCurrentCallback) {
try {
chrome.windows.getCurrent(getCurrentCallback);
} catch (e) {
chrome.test.fail(e);
}
}
chrome.test.runTests([ chrome.test.runTests([
// Get the window that was automatically created. // Get the window that was automatically created.
function testWindowGetAllBeforeCreate() { function testWindowGetAllBeforeCreate() {
...@@ -63,12 +55,6 @@ chrome.test.runTests([ ...@@ -63,12 +55,6 @@ chrome.test.runTests([
chrome.test.assertEq(400, windowData.height); chrome.test.assertEq(400, windowData.height);
chrome.test.succeed(); chrome.test.succeed();
}); });
// Check that the created window is the current window.
getCurrentWindowUtil(function(currentWindowData) {
chrome.test.assertEq(createdWindowId, currentWindowData.id);
chrome.test.succeed();
});
chrome.test.succeed();
}); });
}, },
]); ]);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment