Commit 82b76f7d authored by michaeldo's avatar michaeldo Committed by Commit bot

Ensure network activity is stopped on deallocation.

BUG=620887

Review-Url: https://codereview.chromium.org/2585863002
Cr-Commit-Position: refs/heads/master@{#439180}
parent 3784517e
...@@ -25,7 +25,14 @@ NetworkActivityIndicatorTabHelper::NetworkActivityIndicatorTabHelper( ...@@ -25,7 +25,14 @@ NetworkActivityIndicatorTabHelper::NetworkActivityIndicatorTabHelper(
NSString* tab_id) NSString* tab_id)
: web::WebStateObserver(web_state), network_activity_key_([tab_id copy]) {} : web::WebStateObserver(web_state), network_activity_key_([tab_id copy]) {}
NetworkActivityIndicatorTabHelper::~NetworkActivityIndicatorTabHelper() {} NetworkActivityIndicatorTabHelper::~NetworkActivityIndicatorTabHelper() {
NetworkActivityIndicatorManager* shared_manager =
[NetworkActivityIndicatorManager sharedInstance];
// Verifies that there is a network task associated with this instance
// before stopping a task, so that this method is idempotent.
if ([shared_manager numNetworkTasksForGroup:network_activity_key_])
[shared_manager stopNetworkTaskForGroup:network_activity_key_];
}
void NetworkActivityIndicatorTabHelper::DidStartLoading() { void NetworkActivityIndicatorTabHelper::DidStartLoading() {
NetworkActivityIndicatorManager* shared_manager = NetworkActivityIndicatorManager* shared_manager =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment