Use [RaisesException] for immediate promise rejections in background_sync

This is a part of effort for using [RaisesException] when
synchronously rejecting a promise.

It uses [RaisesException] for
//third_party/blink/renderer/modules/background_sync.

Bug: 1001114
Change-Id: I6146006633aa4147f8682b73e2e268ee5b11b63c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958555Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Julie Kim <jkim@igalia.com>
Cr-Commit-Position: refs/heads/master@{#724083}

third_party/blink/renderer/modules/background_sync/periodic_sync_manager.cc

@@ -12,6 +12,7 @@
 #include "third_party/blink/renderer/core/execution_context/execution_context.h"
 #include "third_party/blink/renderer/modules/background_sync/background_sync_options.h"
 #include "third_party/blink/renderer/modules/service_worker/service_worker_registration.h"
+#include "third_party/blink/renderer/platform/bindings/exception_state.h"
 
 namespace blink {
 
@@ -25,12 +26,13 @@ PeriodicSyncManager::PeriodicSyncManager(
 ScriptPromise PeriodicSyncManager::registerPeriodicSync(
     ScriptState* script_state,
     const String& tag,
-    const BackgroundSyncOptions* options) {
+    const BackgroundSyncOptions* options,
+    ExceptionState& exception_state) {
   if (!registration_->active()) {
-    return ScriptPromise::RejectWithDOMException(
-        script_state, MakeGarbageCollected<DOMException>(
-                          DOMExceptionCode::kInvalidStateError,
-                          "Registration failed - no active Service Worker"));
+    exception_state.ThrowDOMException(
+        DOMExceptionCode::kInvalidStateError,
+        "Registration failed - no active Service Worker");
+    return ScriptPromise();
   }
 
   auto* resolver = MakeGarbageCollected<ScriptPromiseResolver>(script_state);

third_party/blink/renderer/modules/background_sync/periodic_sync_manager.h

@@ -15,6 +15,7 @@
 namespace blink {
 
 class BackgroundSyncOptions;
+class ExceptionState;
 class ScriptPromise;
 class ScriptPromiseResolver;
 class ScriptState;
@@ -37,7 +38,8 @@ class PeriodicSyncManager final : public ScriptWrappable {
   // IDL exposed interface
   ScriptPromise registerPeriodicSync(ScriptState* script_state,
                                      const String& tag,
-                                     const BackgroundSyncOptions* options);
+                                     const BackgroundSyncOptions* options,
+                                     ExceptionState& exception_state);
   ScriptPromise getTags(ScriptState* script_state);
   ScriptPromise unregister(ScriptState* script_state, const String& tag);
 

third_party/blink/renderer/modules/background_sync/periodic_sync_manager.idl

@@ -9,7 +9,7 @@
     Exposed=(Window,Worker),
     RuntimeEnabled=PeriodicBackgroundSync
 ] interface PeriodicSyncManager {
-    [MeasureAs=PeriodicBackgroundSyncRegister,CallWith=ScriptState,ImplementedAs=registerPeriodicSync] Promise<void> register(DOMString tag, optional BackgroundSyncOptions options);
+    [MeasureAs=PeriodicBackgroundSyncRegister,CallWith=ScriptState,RaisesException,ImplementedAs=registerPeriodicSync] Promise<void> register(DOMString tag, optional BackgroundSyncOptions options);
     [MeasureAs=PeriodicBackgroundSyncGetTags, CallWith=ScriptState] Promise<sequence<DOMString>> getTags();
     [MeasureAs=PeriodicBackgroundSyncUnregister,CallWith=ScriptState] Promise<void> unregister(DOMString tag);
 };

third_party/blink/renderer/modules/background_sync/sync_manager.cc

@@ -12,6 +12,7 @@
 #include "third_party/blink/renderer/core/dom/dom_exception.h"
 #include "third_party/blink/renderer/core/execution_context/execution_context.h"
 #include "third_party/blink/renderer/modules/service_worker/service_worker_registration.h"
+#include "third_party/blink/renderer/platform/bindings/exception_state.h"
 #include "third_party/blink/renderer/platform/bindings/script_state.h"
 #include "third_party/blink/renderer/platform/heap/heap.h"
 #include "third_party/blink/renderer/platform/heap/persistent.h"
@@ -26,12 +27,13 @@ SyncManager::SyncManager(ServiceWorkerRegistration* registration,
 }
 
 ScriptPromise SyncManager::registerFunction(ScriptState* script_state,
-                                            const String& tag) {
+                                            const String& tag,
+                                            ExceptionState& exception_state) {
   if (!registration_->active()) {
-    return ScriptPromise::RejectWithDOMException(
-        script_state, MakeGarbageCollected<DOMException>(
-                          DOMExceptionCode::kInvalidStateError,
-                          "Registration failed - no active Service Worker"));
+    exception_state.ThrowDOMException(
+        DOMExceptionCode::kInvalidStateError,
+        "Registration failed - no active Service Worker");
+    return ScriptPromise();
   }
 
   auto* resolver = MakeGarbageCollected<ScriptPromiseResolver>(script_state);

third_party/blink/renderer/modules/background_sync/sync_manager.h

@@ -13,6 +13,7 @@
 
 namespace blink {
 
+class ExceptionState;
 class ScriptPromise;
 class ScriptPromiseResolver;
 class ScriptState;
@@ -32,7 +33,9 @@ class SyncManager final : public ScriptWrappable {
   SyncManager(ServiceWorkerRegistration*,
               scoped_refptr<base::SequencedTaskRunner>);
 
-  ScriptPromise registerFunction(ScriptState*, const String& tag);
+  ScriptPromise registerFunction(ScriptState*,
+                                 const String& tag,
+                                 ExceptionState& exception_state);
   ScriptPromise getTags(ScriptState*);
 
   void Trace(blink::Visitor*) override;

third_party/blink/renderer/modules/background_sync/sync_manager.idl

@@ -7,6 +7,6 @@
 [
     Exposed=(Window,Worker)
 ] interface SyncManager {
-    [MeasureAs=BackgroundSyncRegister,CallWith=ScriptState,ImplementedAs=registerFunction] Promise<void> register(DOMString tag);
+    [MeasureAs=BackgroundSyncRegister,CallWith=ScriptState,RaisesException,ImplementedAs=registerFunction] Promise<void> register(DOMString tag);
     [CallWith=ScriptState] Promise<sequence<DOMString>> getTags();
 };

third_party/blink/web_tests/http/tests/background_sync/oneshot-register-failure-worker-not-activated.html

@@ -27,7 +27,7 @@ async_test(function(test) {
             assert_unreached('sync.register() must not succeed without an active service worker');
         }, function(e) {
             assert_equals(e.name, 'InvalidStateError');
-            assert_equals(e.message, 'Registration failed - no active Service Worker');
+            assert_equals(e.message, 'Failed to execute \'register\' on \'SyncManager\': Registration failed - no active Service Worker');
             return service_worker_unregister_and_done(test, workerScope);
         })
         .catch(unreached_rejection(test));

third_party/blink/web_tests/http/tests/background_sync/periodic-sync-register-fails-if-worker-not-activated.html

@@ -35,7 +35,7 @@
         }, error => {
           assert_equals(error.name, 'InvalidStateError');
           assert_equals(
-              error.message, 'Registration failed - no active Service Worker');
+              error.message, 'Failed to execute \'register\' on \'PeriodicSyncManager\': Registration failed - no active Service Worker');
           return service_worker_unregister_and_done(test, workerScope);
         })
         .catch(unreached_rejection(test));