Skip to content

GitLab

T
tangled
Commit 82e13c27 authored by Noel Gordon's avatar Noel Gordon Committed by Commit Bot
Browse files
Options

Closure compile providers_model_unittest 

 - use let and const and add doc comment annotations.
 - update LoadTimeData fake to include DRIVE_OFFLINE_COLLECTION_LABEL
   and DRIVE_SHARED_WITH_ME_COLLECTION_LABEL to avoid JS exceptions
   about them being missing / undefined when running the unittest.
 - rm duplicate NOT_MOUNTED_SINGLE_PROVIDING_EXTENSION definition.
 - use VolumeManagerCommon.Source types rather than bare strings.
 - create & install mock chrome.fileManagerPrivate.
 - create & install mock VolumeManager.
 - run JS formatter over the code.

Bug: 905933
Change-Id: I7dabbb8ff72f79d290eaeffcb941280715f93660
Reviewed-on: https://chromium-review.googlesource.com/c/1343397
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: default avatarStuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609487}
parent 03cf5921
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 186 additions and 177 deletions
chrome/browser/chromeos/file_manager/file_manager_jstest.cc
View file @ 82e13c27
......@@ -178,8 +178,7 @@ IN_PROC_BROWSER_TEST_F(FileManagerJsTest, ImageOrientation) {
}
IN_PROC_BROWSER_TEST_F(FileManagerJsTest, ProvidersModel) {
RunTest(base::FilePath(
FILE_PATH_LITERAL("foreground/js/providers_model_unittest.html")));
RunGeneratedTest("/foreground/js/providers_model_unittest.html");
}
IN_PROC_BROWSER_TEST_F(FileManagerJsTest, FilesTooltip) {
......
ui/file_manager/file_manager/foreground/js/BUILD.gn
View file @ 82e13c27
......@@ -540,6 +540,16 @@ js_library("providers_model") {
]
}
js_unittest("providers_model_unittest") {
deps = [
":providers_model",
"//ui/file_manager/base/js:mock_chrome",
"//ui/file_manager/base/js:test_error_reporting",
"//ui/file_manager/file_manager/background/js:mock_volume_manager",
"//ui/webui/resources/js:load_time_data",
]
}
js_library("quick_view_controller") {
deps = [
":dialog_type",
......@@ -674,6 +684,7 @@ js_library("webui_command_extender") {
js_unit_tests("unit_tests") {
deps = [
":file_list_model_unittest",
":providers_model_unittest",
":thumbnail_loader_unittest",
]
}
ui/file_manager/file_manager/foreground/js/providers_model_unittest.html deleted 100644 → 0
View file @ 03cf5921
<!DOCTYPE html>
<!-- Copyright 2015 The Chromium Authors. All rights reserved.
-- Use of this source code is governed by a BSD-style license that can be
-- found in the LICENSE file.
-->
<html>
<body>
<script src="../../../../../ui/webui/resources/js/cr.js"></script>
<script src="../../../../../ui/webui/resources/js/cr/event_target.js"></script>
<script src="../../../../../ui/webui/resources/js/cr/ui.js"></script>
<script src="../../../../../ui/webui/resources/js/cr/ui/array_data_model.js"></script>
<script src="../../../../../ui/webui/resources/js/load_time_data.js"></script>
<script src="../../common/js/mock_entry.js"></script>
<script src="../../../base/js/test_error_reporting.js"></script>
<script src="../../../base/js/mock_chrome.js"></script>
<script src="../../common/js/unittest_util.js"></script>
<script src="../../common/js/files_app_entry_types.js"></script>
<script src="../../common/js/util.js"></script>
<script src="../../../base/js/volume_manager_types.js"></script>
<script src="../../background/js/volume_info_impl.js"></script>
<script src="../../background/js/volume_info_list_impl.js"></script>
<script src="../../background/js/volume_manager_factory.js"></script>
<script src="../../background/js/volume_manager_impl.js"></script>
<script src="../../background/js/volume_manager_util.js"></script>
<script src="../../background/js/mock_volume_manager.js"></script>
<script src="providers_model.js"></script>
<script src="providers_model_unittest.js"></script>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment