Commit 82efa8a3 authored by Tommy Martino's avatar Tommy Martino Committed by Chromium LUCI CQ

Revert "[Controls Refresh Android] Fixes input missing border"

This reverts commit 909901eb.

Reason for revert: Causing failures on Mac bots, see crbug.com/1164011

Original change's description:
> [Controls Refresh Android] Fixes input missing border
>
> Prior to this CL, controls-refresh text input is missing its border.
>
> The fix is to make sure property text_field.has_border is passed to
> native theme. This property is only used by form controls-refresh
> so it has no impact on existing text input.
>
> Bug: 1155397
> Change-Id: I3cacd4d9550e10388b15122d7ff94a32ffa5e39d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612495
> Reviewed-by: Camille Lamy <clamy@chromium.org>
> Reviewed-by: Mason Freed <masonfreed@chromium.org>
> Commit-Queue: Yu Han <yuzhehan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#841106}

TBR=clamy@chromium.org,masonfreed@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,yuzhehan@chromium.org

Change-Id: I2704b803c8aea565781632e8f07bbd0b29947f6f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1155397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616279Reviewed-by: default avatarTommy Martino <tmartino@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#841174}
parent 5d53420c
......@@ -158,25 +158,6 @@ IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, Radio) {
/* screenshot_height */ 40);
}
IN_PROC_BROWSER_TEST_F(FormControlsBrowserTest, Input) {
RunTest("form_controls_browsertest_input",
"<!-- text inputs -->"
"<style>input {width: 150px;}</style>"
"<input type=\"text\" /><br><br>"
"<input type=\"number\" /><br><br>"
"<input type=\"search\" /><br><br>"
"<input type=\"email\" /><br><br>"
"<input type=\"password\" /><br><br>"
"<!-- border -->"
"<input type=\"text\" style=\"border: 3px solid lime;\"/><br><br>"
"<!-- shadow -->"
"<input type=\"text\" style=\"box-shadow: 4px 4px 10px rgba(255,0,0,0.5), inset 4px 4px 4px rgba(0,255,0,0.5);\"/><br><br>"
"<!-- disabled -->"
"<input type=\"text\" disabled/>",
/* screenshot_width */ 200,
/* screenshot_height */ 330);
}
// TODO(jarhar): Add tests for other elements from
// https://concrete-hardboard.glitch.me
......
......@@ -60,8 +60,6 @@ static void GetNativeThemeExtraParams(
extra_params->text_field.is_listbox;
native_theme_extra_params->text_field.background_color =
extra_params->text_field.background_color;
native_theme_extra_params->text_field.has_border =
extra_params->text_field.has_border;
break;
case WebThemeEngine::kPartMenuList:
native_theme_extra_params->menu_list.has_border =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment