Commit 8322d40e authored by Viviane Yang's avatar Viviane Yang Committed by Commit Bot

[PUSH] Change const to constexpr

Changed const char to constexpr char

Bug: None
Change-Id: Ib52da28f638cfb6030aebaf659027fd64e9a6f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247736Reviewed-by: default avatarRayan Kanso <rayankans@chromium.org>
Commit-Queue: Viviane Yang <viviy@google.com>
Cr-Commit-Position: refs/heads/master@{#779379}
parent b87b9725
......@@ -19,18 +19,18 @@
#include "components/prefs/pref_service.h"
#include "components/prefs/scoped_user_pref_update.h"
const char kPushMessagingAppIdentifierPrefix[] = "wp:";
const char kInstanceIDGuidSuffix[] = "-V2";
constexpr char kPushMessagingAppIdentifierPrefix[] = "wp:";
constexpr char kInstanceIDGuidSuffix[] = "-V2";
namespace {
// sizeof is strlen + 1 since it's null-terminated.
const size_t kPrefixLength = sizeof(kPushMessagingAppIdentifierPrefix) - 1;
const size_t kGuidSuffixLength = sizeof(kInstanceIDGuidSuffix) - 1;
constexpr size_t kPrefixLength = sizeof(kPushMessagingAppIdentifierPrefix) - 1;
constexpr size_t kGuidSuffixLength = sizeof(kInstanceIDGuidSuffix) - 1;
// Ok to use '#' as separator since only the origin of the url is used.
const char kOriginSWRIdSeparator = '#';
const size_t kGuidLength = 36; // "%08X-%04X-%04X-%04X-%012llX"
constexpr char kOriginSWRIdSeparator = '#';
constexpr size_t kGuidLength = 36; // "%08X-%04X-%04X-%04X-%012llX"
std::string MakePrefValue(const GURL& origin,
int64_t service_worker_registration_id) {
......@@ -248,7 +248,7 @@ void PushMessagingAppIdentifier::DCheckValid() const {
// Optional (origin.spec() + '#')
if (app_id_.size() != kPrefixLength + kGuidLength) {
const size_t suffix_length = 1 /* kOriginSWRIdSeparator */ + kGuidLength;
constexpr size_t suffix_length = 1 /* kOriginSWRIdSeparator */ + kGuidLength;
DCHECK_GT(app_id_.size(), kPrefixLength + suffix_length);
DCHECK_EQ(origin_, GURL(app_id_.substr(
kPrefixLength,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment