Commit 832fee08 authored by David Tseng's avatar David Tseng

Disable ChromeVoxOptionsTest.PunctuationEchoSelect on chromeos MSAN

TBR=josiahk@chromium.org

Bug: 1128926
Change-Id: Ib9c2ed0622b7b22dd94294ecd7aba8cb76b3478c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413534Reviewed-by: default avatarDavid Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#807576}
parent 12e346a1
...@@ -73,52 +73,63 @@ TEST_F('ChromeVoxOptionsTest', 'NumberReadingStyleSelect', function() { ...@@ -73,52 +73,63 @@ TEST_F('ChromeVoxOptionsTest', 'NumberReadingStyleSelect', function() {
}); });
}); });
TEST_F('ChromeVoxOptionsTest', 'punctuationEchoSelect', function() { // TODO(crbug.com/1128926): Test times out flakily in MSAN builds.
this.runOnOptionsPage((mockFeedback, evt) => { TEST_F_WITH_PREAMBLE(
const PUNCTUATION_ECHO_NONE = '0'; `
const PUNCTUATION_ECHO_SOME = '1'; #if defined(MEMORY_SANITIZER)
const PUNCTUATION_ECHO_ALL = '2'; #define MAYBE_PunctuationEchoSelect DISABLED_PunctuationEchoSelect
const punctuationEchoSelect = evt.target.find({ #else
role: chrome.automation.RoleType.POP_UP_BUTTON, #define MAYBE_PunctuationEchoSelect PunctuationEchoSelect
attributes: {name: 'Punctuation echo:'} #endif
`,
'ChromeVoxOptionsTest', 'MAYBE_PunctuationEchoSelect', function() {
this.runOnOptionsPage((mockFeedback, evt) => {
const PUNCTUATION_ECHO_NONE = '0';
const PUNCTUATION_ECHO_SOME = '1';
const PUNCTUATION_ECHO_ALL = '2';
const punctuationEchoSelect = evt.target.find({
role: chrome.automation.RoleType.POP_UP_BUTTON,
attributes: {name: 'Punctuation echo:'}
});
assertNotNullNorUndefined(punctuationEchoSelect);
mockFeedback
.call(punctuationEchoSelect.focus.bind(punctuationEchoSelect))
.expectSpeech('Punctuation echo:', 'None', 'Collapsed')
.call(punctuationEchoSelect.doDefault.bind(punctuationEchoSelect))
.expectSpeech('Expanded')
// Before selecting the menu option.
.call(() => {
assertEquals(
PUNCTUATION_ECHO_NONE,
localStorage[AbstractTts.PUNCTUATION_ECHO]);
})
.call(press(KeyCode.DOWN))
.expectSpeech('Some', 'List item', ' 2 of 3 ')
.call(press(KeyCode.RETURN))
// TODO(josiahk): The underlying select behavior here is unexpected
// because we never get a new focus event for the select (moving us
// away from the menu item). We simply repeat the menu item.
.expectSpeech('Some', ' 2 of 3 ')
.call(() => {
assertEquals(
PUNCTUATION_ECHO_SOME,
localStorage[AbstractTts.PUNCTUATION_ECHO]);
})
.call(press(KeyCode.DOWN))
.expectSpeech('All', ' 3 of 3 ')
.call(() => {
assertEquals(
PUNCTUATION_ECHO_ALL,
localStorage[AbstractTts.PUNCTUATION_ECHO]);
})
.replay();
});
}); });
assertNotNullNorUndefined(punctuationEchoSelect);
mockFeedback.call(punctuationEchoSelect.focus.bind(punctuationEchoSelect))
.expectSpeech('Punctuation echo:', 'None', 'Collapsed')
.call(punctuationEchoSelect.doDefault.bind(punctuationEchoSelect))
.expectSpeech('Expanded')
// Before selecting the menu option.
.call(() => {
assertEquals(
PUNCTUATION_ECHO_NONE,
localStorage[AbstractTts.PUNCTUATION_ECHO]);
})
.call(press(KeyCode.DOWN))
.expectSpeech('Some', 'List item', ' 2 of 3 ')
.call(press(KeyCode.RETURN))
// TODO(josiahk): The underlying select behavior here is unexpected
// because we never get a new focus event for the select (moving us
// away from the menu item). We simply repeat the menu item.
.expectSpeech('Some', ' 2 of 3 ')
.call(() => {
assertEquals(
PUNCTUATION_ECHO_SOME,
localStorage[AbstractTts.PUNCTUATION_ECHO]);
})
.call(press(KeyCode.DOWN))
.expectSpeech('All', ' 3 of 3 ')
.call(() => {
assertEquals(
PUNCTUATION_ECHO_ALL, localStorage[AbstractTts.PUNCTUATION_ECHO]);
})
.replay();
});
});
TEST_F('ChromeVoxOptionsTest', 'SmartStickyMode', function() { TEST_F('ChromeVoxOptionsTest', 'SmartStickyMode', function() {
this.runOnOptionsPage((mockFeedback, evt) => { this.runOnOptionsPage((mockFeedback, evt) => {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment