Commit 8331c1ba authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

win: Pass -fno-delete-null-pointer-checks without /clang: prefix.

As of the clang roll in https://crbug.com/1149189, clang-cl understands
this flag directly.

Bug: 1139129
Change-Id: I5f484d259f48855967a1715e87d2f704826ceacd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547122
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: default avatarMatthew Denton <mpdenton@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#828914}
parent 38122dcf
...@@ -266,12 +266,7 @@ config("compiler") { ...@@ -266,12 +266,7 @@ config("compiler") {
# Nacl does not support the flag. And, we still want UBSAN to catch undefined # Nacl does not support the flag. And, we still want UBSAN to catch undefined
# behavior related to nullptrs, so do not add this flag if UBSAN is enabled. # behavior related to nullptrs, so do not add this flag if UBSAN is enabled.
if (!is_nacl && !is_ubsan) { if (!is_nacl && !is_ubsan) {
if (is_win) { cflags += [ "-fno-delete-null-pointer-checks" ]
# TODO(thakis): Remove this branch once chromium's clang has https://github.com/llvm/llvm-project/commit/3109ce5
cflags += [ "/clang:-fno-delete-null-pointer-checks" ]
} else {
cflags += [ "-fno-delete-null-pointer-checks" ]
}
} }
# In general, Windows is totally different, but all the other builds share # In general, Windows is totally different, but all the other builds share
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment