Commit 834841e4 authored by Ben Kelly's avatar Ben Kelly Committed by Commit Bot

Make default ResponseTime the time when the Response was created.

This CL sets a default ResponseTime when a Response object is created.  This
will be overriden with the real ResponseTime when created via fetch() or Cache
API.  Synthetic Response objects created using the constructor, however, will
end up using this default value for their ResponseTime.

Bug: 747718
Change-Id: Id8c56c875d6ca00285048ebd51f92c0380dcfed1
Reviewed-on: https://chromium-review.googlesource.com/1255423Reviewed-by: default avatarTsuyoshi Horo <horo@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595665}
parent 571755af
...@@ -287,7 +287,8 @@ FetchResponseData::FetchResponseData(Type type, ...@@ -287,7 +287,8 @@ FetchResponseData::FetchResponseData(Type type,
: type_(type), : type_(type),
status_(status), status_(status),
status_message_(status_message), status_message_(status_message),
header_list_(FetchHeaderList::Create()) {} header_list_(FetchHeaderList::Create()),
response_time_(base::Time::Now()) {}
void FetchResponseData::ReplaceBodyStreamBuffer(BodyStreamBuffer* buffer) { void FetchResponseData::ReplaceBodyStreamBuffer(BodyStreamBuffer* buffer) {
if (type_ == Type::kBasic || type_ == Type::kCORS) { if (type_ == Type::kBasic || type_ == Type::kCORS) {
......
...@@ -268,4 +268,9 @@ TEST_F(FetchResponseDataTest, ToWebServiceWorkerOpaqueRedirectType) { ...@@ -268,4 +268,9 @@ TEST_F(FetchResponseDataTest, ToWebServiceWorkerOpaqueRedirectType) {
CheckHeaders(web_response); CheckHeaders(web_response);
} }
TEST_F(FetchResponseDataTest, DefaultResponseTime) {
FetchResponseData* internal_response = CreateInternalResponse();
EXPECT_FALSE(internal_response->ResponseTime().is_null());
}
} // namespace blink } // namespace blink
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment