Commit 834bb952 authored by jbauman's avatar jbauman Committed by Commit bot

Log command name with GPU parse errors.

This should make it easier to debug when there's an issue.

BUG=

Review URL: https://codereview.chromium.org/554783002

Cr-Commit-Position: refs/heads/master@{#293842}
parent 4cd276bc
...@@ -51,12 +51,12 @@ error::Error CommandParser::ProcessCommand() { ...@@ -51,12 +51,12 @@ error::Error CommandParser::ProcessCommand() {
CommandHeader header = buffer_[get].value_header; CommandHeader header = buffer_[get].value_header;
if (header.size == 0) { if (header.size == 0) {
DVLOG(1) << "Error: zero sized command in command buffer"; LOG(ERROR) << "Parse error: zero sized command in command buffer";
return error::kInvalidSize; return error::kInvalidSize;
} }
if (static_cast<int>(header.size) + get > entry_count_) { if (static_cast<int>(header.size) + get > entry_count_) {
DVLOG(1) << "Error: get offset out of bounds"; LOG(ERROR) << "Parse error: get offset out of bounds";
return error::kOutOfBounds; return error::kOutOfBounds;
} }
...@@ -66,9 +66,6 @@ error::Error CommandParser::ProcessCommand() { ...@@ -66,9 +66,6 @@ error::Error CommandParser::ProcessCommand() {
error::Error result = handler_->DoCommand( error::Error result = handler_->DoCommand(
header.command, header.size - 1, buffer_ + get); header.command, header.size - 1, buffer_ + get);
// TODO(gman): If you want to log errors this is the best place to catch them.
// It seems like we need an official way to turn on a debug mode and
// get these errors.
if (error::IsError(result)) { if (error::IsError(result)) {
ReportError(header.command, result); ReportError(header.command, result);
} }
...@@ -82,8 +79,8 @@ error::Error CommandParser::ProcessCommand() { ...@@ -82,8 +79,8 @@ error::Error CommandParser::ProcessCommand() {
void CommandParser::ReportError(unsigned int command_id, void CommandParser::ReportError(unsigned int command_id,
error::Error result) { error::Error result) {
DVLOG(1) << "Error: " << result << " for Command " LOG(ERROR) << "Error: " << result << " for Command "
<< handler_->GetCommandName(command_id); << handler_->GetCommandName(command_id);
} }
// Processes all the commands, while the buffer is not empty. Stop if an error // Processes all the commands, while the buffer is not empty. Stop if an error
......
...@@ -91,8 +91,6 @@ void GpuScheduler::PutChanged() { ...@@ -91,8 +91,6 @@ void GpuScheduler::PutChanged() {
command_buffer_->SetGetOffset(static_cast<int32>(parser_->get())); command_buffer_->SetGetOffset(static_cast<int32>(parser_->get()));
if (error::IsError(error)) { if (error::IsError(error)) {
LOG(ERROR) << "[" << decoder_ << "] "
<< "GPU PARSE ERROR: " << error;
command_buffer_->SetContextLostReason(decoder_->GetContextLostReason()); command_buffer_->SetContextLostReason(decoder_->GetContextLostReason());
command_buffer_->SetParseError(error); command_buffer_->SetParseError(error);
break; break;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment