Commit 8381dcb4 authored by Victor Hugo Vianna Silva's avatar Victor Hugo Vianna Silva Committed by Commit Bot

Fix innacurate documentation in TestChromeWebUIControllerFactory

Before the CL, the class-level documentation affirmed that simply adding
a kTestType switch to the CLI would cause this factory to replace the
ChromeWebUIFactory. This was true when it was first introduced [1] but
nowadays it seems that users have to replace the factories by hand (see
the 7 callers of the constructor).

[1] https://codereview.chromium.org/6992019/diff/10003/chrome/browser/ui/webui/chrome_web_ui_factory.cc

Bug: None
Change-Id: Ic9413976b1fd6eb8b1e5ce8c58112629471143c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360270
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#798711}
parent 0168742f
...@@ -13,9 +13,8 @@ ...@@ -13,9 +13,8 @@
#include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h" #include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h"
#include "content/public/browser/web_ui.h" #include "content/public/browser/web_ui.h"
// This class replaces the ChromeWebUIFactory when the switches::kTestType flag // A test implementation of ChromeWebUIControllerFactory that provides a
// is passed. It provides a registry to override CreateWebUIControllerForURL() // registry to override CreateWebUIControllerForURL() by host.
// by host.
class TestChromeWebUIControllerFactory : public ChromeWebUIControllerFactory { class TestChromeWebUIControllerFactory : public ChromeWebUIControllerFactory {
public: public:
// Interface to create a new WebUI object. // Interface to create a new WebUI object.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment