Commit 8389a73f authored by Erik Chen's avatar Erik Chen Committed by Chromium LUCI CQ

Revert "Set "dev" channel for all lacros builds."

This reverts commit 8d4df26b.

Reason for revert: 
Reverting for now -- this enables Finch configs for Lacros -- which in turn will turn on Vulkan backend for Skia, which can (sometimes) crash Lacros on launch.

Original change's description:
> Set "dev" channel for all lacros builds.
>
> Linux-chrome (of which lacros is a variant) has its channel set as a
> runtime environment variable by the launcher script. For Lacros, we must
> set the environment variable from ash. For now, we always set "dev" for
> all builds of Lacros.
>
> Change-Id: I840286b6fd5772701c3f6d927986405697b82097
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570448
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#833460}

TBR=jamescook@chromium.org,erikchen@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I25d3d72d27571645ef9b1723e624e75859579d8b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574803Reviewed-by: default avatarErik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833801}
parent e9cac65c
......@@ -304,9 +304,6 @@ void BrowserManager::StartWithLogFile(base::ScopedFD logfd) {
options.environment["GOOGLE_DEFAULT_CLIENT_SECRET"] =
google_apis::GetOAuth2ClientSecret(google_apis::CLIENT_MAIN);
// This sets the channel for Lacros.
options.environment["CHROME_VERSION_EXTRA"] = "dev";
options.kill_on_parent_death = true;
// Paths are UTF-8 safe on Chrome OS.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment