Allow embedders to provide a custom view for popup (select box) widgets,

the same way they have the ability to provide a custom view for page widgets.
All the widget views are created using WebContentsView, which can be
overriden by embedders with ContentBrowserClient::OverrideCreateWebContentsView
Contributed by rosca@adobe.com

BUG=155761

Review URL: https://chromiumcodereview.appspot.com/11773042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176092 0039d316-1c4b-4281-b951-d872f2087c98

AUTHORS

@@ -217,3 +217,4 @@ Martin Bednorz <m.s.bednorz@gmail.com>
 Kamil Jiwa <kamil.jiwa@gmail.com>
 Keene Pan <keenepan@linpus.com>
 Trevor Perrin <unsafe@trevp.net>
+Ion Rosca <rosca@adobe.com>

content/browser/web_contents/web_contents_impl.cc

@@ -1390,8 +1390,10 @@ void WebContentsImpl::CreateNewWidget(int route_id,
       new RenderWidgetHostImpl(this, process, route_id);
   created_widgets_.insert(widget_host);
 
-  RenderWidgetHostViewPort* widget_view =
-      RenderWidgetHostViewPort::CreateViewForWidget(widget_host);
+  RenderWidgetHostViewPort* widget_view = RenderWidgetHostViewPort::FromRWHV(
+      view_->CreateViewForPopupWidget(widget_host));
+  if (!widget_view)
+    return;
   if (!is_fullscreen) {
     // Popups should not get activated.
     widget_view->SetPopupType(popup_type);

content/browser/web_contents/web_contents_view_android.cc

@@ -80,6 +80,11 @@ RenderWidgetHostView* WebContentsViewAndroid::CreateViewForWidget(
   return view;
 }
 
+RenderWidgetHostView* WebContentsViewAndroid::CreateViewForPopupWidget(
+    RenderWidgetHost* render_widget_host) {
+  return RenderWidgetHostViewPort::CreateViewForWidget(render_widget_host);
+}
+
 gfx::NativeView WebContentsViewAndroid::GetNativeView() const {
   return content_view_core_;
 }

content/browser/web_contents/web_contents_view_android.h

@@ -34,6 +34,8 @@ class WebContentsViewAndroid : public WebContentsView,
       const gfx::Size& initial_size, gfx::NativeView context) OVERRIDE;
   virtual RenderWidgetHostView* CreateViewForWidget(
       RenderWidgetHost* render_widget_host) OVERRIDE;
+  virtual RenderWidgetHostView* CreateViewForPopupWidget(
+      RenderWidgetHost* render_widget_host) OVERRIDE;
   virtual gfx::NativeView GetNativeView() const OVERRIDE;
   virtual gfx::NativeView GetContentNativeView() const OVERRIDE;
   virtual gfx::NativeWindow GetTopLevelNativeWindow() const OVERRIDE;

content/browser/web_contents/web_contents_view_aura.cc

@@ -680,6 +680,11 @@ RenderWidgetHostView* WebContentsViewAura::CreateViewForWidget(
   return view;
 }
 
+RenderWidgetHostView* WebContentsViewAura::CreateViewForPopupWidget(
+    RenderWidgetHost* render_widget_host) {
+  return RenderWidgetHostViewPort::CreateViewForWidget(render_widget_host);
+}
+
 gfx::NativeView WebContentsViewAura::GetNativeView() const {
   return window_.get();
 }

content/browser/web_contents/web_contents_view_aura.h

@@ -82,6 +82,8 @@ class CONTENT_EXPORT WebContentsViewAura
       const gfx::Size& initial_size, gfx::NativeView context) OVERRIDE;
   virtual RenderWidgetHostView* CreateViewForWidget(
       RenderWidgetHost* render_widget_host) OVERRIDE;
+  virtual RenderWidgetHostView* CreateViewForPopupWidget(
+      RenderWidgetHost* render_widget_host) OVERRIDE;
   virtual gfx::NativeView GetNativeView() const OVERRIDE;
   virtual gfx::NativeView GetContentNativeView() const OVERRIDE;
   virtual gfx::NativeWindow GetTopLevelNativeWindow() const OVERRIDE;

content/browser/web_contents/web_contents_view_gtk.cc

@@ -149,6 +149,11 @@ RenderWidgetHostView* WebContentsViewGtk::CreateViewForWidget(
   return view;
 }
 
+RenderWidgetHostView* WebContentsViewGtk::CreateViewForPopupWidget(
+    RenderWidgetHost* render_widget_host) {
+  return RenderWidgetHostViewPort::CreateViewForWidget(render_widget_host);
+}
+
 gfx::NativeView WebContentsViewGtk::GetNativeView() const {
   if (delegate_.get())
     return delegate_->GetNativeView();

content/browser/web_contents/web_contents_view_gtk.h

@@ -49,6 +49,8 @@ class CONTENT_EXPORT WebContentsViewGtk
       const gfx::Size& initial_size, gfx::NativeView context) OVERRIDE;
   virtual RenderWidgetHostView* CreateViewForWidget(
       RenderWidgetHost* render_widget_host) OVERRIDE;
+  virtual RenderWidgetHostView* CreateViewForPopupWidget(
+      RenderWidgetHost* render_widget_host) OVERRIDE;
   virtual gfx::NativeView GetNativeView() const OVERRIDE;
   virtual gfx::NativeView GetContentNativeView() const OVERRIDE;
   virtual gfx::NativeWindow GetTopLevelNativeWindow() const OVERRIDE;

content/browser/web_contents/web_contents_view_guest.cc

@@ -56,6 +56,11 @@ RenderWidgetHostView* WebContentsViewGuest::CreateViewForWidget(
   return view;
 }
 
+RenderWidgetHostView* WebContentsViewGuest::CreateViewForPopupWidget(
+    RenderWidgetHost* render_widget_host) {
+  return RenderWidgetHostViewPort::CreateViewForWidget(render_widget_host);
+}
+
 gfx::NativeView WebContentsViewGuest::GetNativeView() const {
   return NULL;
 }

content/browser/web_contents/web_contents_view_guest.h

@@ -40,6 +40,8 @@ class CONTENT_EXPORT WebContentsViewGuest
                           gfx::NativeView context) OVERRIDE;
   virtual RenderWidgetHostView* CreateViewForWidget(
       RenderWidgetHost* render_widget_host) OVERRIDE;
+  virtual RenderWidgetHostView* CreateViewForPopupWidget(
+      RenderWidgetHost* render_widget_host) OVERRIDE;
   virtual gfx::NativeView GetNativeView() const OVERRIDE;
   virtual gfx::NativeView GetContentNativeView() const OVERRIDE;
   virtual gfx::NativeWindow GetTopLevelNativeWindow() const OVERRIDE;

content/browser/web_contents/web_contents_view_mac.h

@@ -68,6 +68,8 @@ class WebContentsViewMac : public WebContentsView,
       const gfx::Size& initial_size, gfx::NativeView context) OVERRIDE;
   virtual RenderWidgetHostView* CreateViewForWidget(
       RenderWidgetHost* render_widget_host) OVERRIDE;
+  virtual RenderWidgetHostView* CreateViewForPopupWidget(
+      RenderWidgetHost* render_widget_host) OVERRIDE;
   virtual gfx::NativeView GetNativeView() const OVERRIDE;
   virtual gfx::NativeView GetContentNativeView() const OVERRIDE;
   virtual gfx::NativeWindow GetTopLevelNativeWindow() const OVERRIDE;

content/browser/web_contents/web_contents_view_mac.mm

@@ -142,6 +142,11 @@ RenderWidgetHostView* WebContentsViewMac::CreateViewForWidget(
   return view;
 }
 
+RenderWidgetHostView* WebContentsViewMac::CreateViewForPopupWidget(
+    RenderWidgetHost* render_widget_host) {
+  return RenderWidgetHostViewPort::CreateViewForWidget(render_widget_host);
+}
+
 gfx::NativeView WebContentsViewMac::GetNativeView() const {
   return cocoa_view_.get();
 }

content/browser/web_contents/web_contents_view_win.cc

@@ -139,6 +139,11 @@ RenderWidgetHostView* WebContentsViewWin::CreateViewForWidget(
   return view;
 }
 
+RenderWidgetHostView* WebContentsViewWin::CreateViewForPopupWidget(
+    RenderWidgetHost* render_widget_host) {
+  return RenderWidgetHostViewPort::CreateViewForWidget(render_widget_host);
+}
+
 gfx::NativeView WebContentsViewWin::GetNativeView() const {
   return hwnd();
 }

content/browser/web_contents/web_contents_view_win.h

@@ -57,6 +57,8 @@ class CONTENT_EXPORT WebContentsViewWin
       const gfx::Size& initial_size, gfx::NativeView context) OVERRIDE;
   virtual RenderWidgetHostView* CreateViewForWidget(
       RenderWidgetHost* render_widget_host) OVERRIDE;
+  virtual RenderWidgetHostView* CreateViewForPopupWidget(
+      RenderWidgetHost* render_widget_host) OVERRIDE;
   virtual gfx::NativeView GetNativeView() const OVERRIDE;
   virtual gfx::NativeView GetContentNativeView() const OVERRIDE;
   virtual gfx::NativeWindow GetTopLevelNativeWindow() const OVERRIDE;

content/public/browser/web_contents_view.h

@@ -38,6 +38,10 @@ class CONTENT_EXPORT WebContentsView {
   virtual RenderWidgetHostView* CreateViewForWidget(
       RenderWidgetHost* render_widget_host) = 0;
 
+  // Creates a new View that holds a popup and receives messages for it.
+  virtual RenderWidgetHostView* CreateViewForPopupWidget(
+      RenderWidgetHost* render_widget_host) = 0;
+
   // Returns the native widget that contains the contents of the tab.
   virtual gfx::NativeView GetNativeView() const = 0;
 

content/test/test_web_contents_view.cc

@@ -51,6 +51,11 @@ RenderWidgetHostView* TestWebContentsView::CreateViewForWidget(
   return NULL;
 }
 
+RenderWidgetHostView* TestWebContentsView::CreateViewForPopupWidget(
+    RenderWidgetHost* render_widget_host) {
+  return NULL;
+}
+
 gfx::NativeView TestWebContentsView::GetNativeView() const {
   return gfx::NativeView();
 }

content/test/test_web_contents_view.h

@@ -41,6 +41,8 @@ class TestWebContentsView : public WebContentsView,
                           gfx::NativeView context) OVERRIDE;
   virtual RenderWidgetHostView* CreateViewForWidget(
       RenderWidgetHost* render_widget_host) OVERRIDE;
+  virtual RenderWidgetHostView* CreateViewForPopupWidget(
+      RenderWidgetHost* render_widget_host) OVERRIDE;
   virtual gfx::NativeView GetNativeView() const OVERRIDE;
   virtual gfx::NativeView GetContentNativeView() const OVERRIDE;
   virtual gfx::NativeWindow GetTopLevelNativeWindow() const OVERRIDE;