Skip to content

GitLab

T
tangled
Commit 839ed279 authored by Johannes Henkel's avatar Johannes Henkel Committed by Commit Bot
Browse files
Options

Revert "Revert "[DevTools] Internally use binary protocol by default."" 

This reverts commit 03844362.

Reason for revert: heap-snapshot-with-multiple-retainers.js no longer flaky. See https://chromium-review.googlesource.com/c/chromium/src/+/1546939
TBR=pfeldman

Change-Id: Ie6917ebadb843c3c0b025a8113345cc9c8994011
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548048Reviewed-by: default avatarJohannes Henkel <johannes@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646503}
parent 1085b643
Expand all Hide whitespace changes
Inline Side-by-side
Showing with 378 additions and 250 deletions
chrome/browser/devtools/chrome_devtools_session.cc
View file @ 839ed279
...@@ -54,9 +54,9 @@ void ChromeDevToolsSession::sendProtocolResponse( ...@@ -54,9 +54,9 @@ void ChromeDevToolsSession::sendProtocolResponse(
} }
static bool EnableInternalDevToolsBinaryProtocol() { static bool EnableInternalDevToolsBinaryProtocol() {
static bool enabled = base::CommandLine::ForCurrentProcess()->HasSwitch( static bool disabled = base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableInternalDevToolsBinaryProtocol); switches::kDisableInternalDevToolsBinaryProtocol);
return enabled; return !disabled;
} }
void ChromeDevToolsSession::HandleCommand( void ChromeDevToolsSession::HandleCommand(
......
content/browser/devtools/devtools_session_encoding.cc
View file @ 839ed279
...@@ -40,9 +40,9 @@ class ContentShellPlatform : public Platform { ...@@ -40,9 +40,9 @@ class ContentShellPlatform : public Platform {
}; };
} // namespace } // namespace
bool EnableInternalDevToolsBinaryProtocol() { bool EnableInternalDevToolsBinaryProtocol() {
static bool enabled = base::CommandLine::ForCurrentProcess()->HasSwitch( static bool disabled = base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableInternalDevToolsBinaryProtocol); switches::kDisableInternalDevToolsBinaryProtocol);
return enabled; return !disabled;
} }
// TODO(johannes): Move this into the cbor library. Don't want to // TODO(johannes): Move this into the cbor library. Don't want to
......
content/public/common/content_switches.cc
View file @ 839ed279
...@@ -216,11 +216,12 @@ const char kDisableNotifications[] = "disable-notifications"; ...@@ -216,11 +216,12 @@ const char kDisableNotifications[] = "disable-notifications";
// the use of persistent gpu memory buffers. // the use of persistent gpu memory buffers.
const char kDisablePartialRaster[] = "disable-partial-raster"; const char kDisablePartialRaster[] = "disable-partial-raster";
// Internally (in devtools_session.cc) switches the protocol to binary format // By default, in devtools_session.cc, we use CBOR for protocol messages
// (CBOR). This setting is temporary; we plan to remove it after transition to // except for sending JSON to clients that request it.
// binary is sufficiently complete (2019-04-01). // This switch undoes this default. We plan to remove it after after transition
const char kEnableInternalDevToolsBinaryProtocol[] = // to binary is sufficiently complete (2019-04-15).
"enable-internal-devtools-binary-protocol"; const char kDisableInternalDevToolsBinaryProtocol[] =
"disable-internal-devtools-binary-protocol";
// Enable partial raster in the renderer. // Enable partial raster in the renderer.
const char kEnablePartialRaster[] = "enable-partial-raster"; const char kEnablePartialRaster[] = "enable-partial-raster";
......
content/public/common/content_switches.h
View file @ 839ed279
...@@ -74,7 +74,7 @@ CONTENT_EXPORT extern const char kDisableNewContentRenderingTimeout[]; ...@@ -74,7 +74,7 @@ CONTENT_EXPORT extern const char kDisableNewContentRenderingTimeout[];
CONTENT_EXPORT extern const char kDisableNotifications[]; CONTENT_EXPORT extern const char kDisableNotifications[];
CONTENT_EXPORT extern const char kDisableOriginTrialControlledBlinkFeatures[]; CONTENT_EXPORT extern const char kDisableOriginTrialControlledBlinkFeatures[];
CONTENT_EXPORT extern const char kDisablePartialRaster[]; CONTENT_EXPORT extern const char kDisablePartialRaster[];
CONTENT_EXPORT extern const char kEnableInternalDevToolsBinaryProtocol[]; CONTENT_EXPORT extern const char kDisableInternalDevToolsBinaryProtocol[];
CONTENT_EXPORT extern const char kEnablePartialRaster[]; CONTENT_EXPORT extern const char kEnablePartialRaster[];
extern const char kDisablePepper3d[]; extern const char kDisablePepper3d[];
CONTENT_EXPORT extern const char kDisablePepper3DImageChromium[]; CONTENT_EXPORT extern const char kDisablePepper3DImageChromium[];
......
headless/lib/browser/protocol/headless_devtools_session.cc
View file @ 839ed279
...@@ -16,9 +16,9 @@ ...@@ -16,9 +16,9 @@
namespace headless { namespace headless {
namespace protocol { namespace protocol {
static bool EnableInternalDevToolsBinaryProtocol() { static bool EnableInternalDevToolsBinaryProtocol() {
static bool enabled = base::CommandLine::ForCurrentProcess()->HasSwitch( static bool disabled = base::CommandLine::ForCurrentProcess()->HasSwitch(
::switches::kEnableInternalDevToolsBinaryProtocol); ::switches::kDisableInternalDevToolsBinaryProtocol);
return enabled; return !disabled;
} }
HeadlessDevToolsSession::HeadlessDevToolsSession( HeadlessDevToolsSession::HeadlessDevToolsSession(
......
third_party/blink/web_tests/ASANExpectations
View file @ 839ed279
...@@ -48,9 +48,9 @@ crbug.com/438499 [ Linux ] fast/workers/worker-multi-startup.html [ Timeout ] ...@@ -48,9 +48,9 @@ crbug.com/438499 [ Linux ] fast/workers/worker-multi-startup.html [ Timeout ]
crbug.com/438499 [ Linux ] http/tests/websocket/workers/worker-simple.html [ Timeout ] crbug.com/438499 [ Linux ] http/tests/websocket/workers/worker-simple.html [ Timeout ]
crbug.com/438499 [ Linux ] http/tests/workers/text-encoding.html [ Timeout ] crbug.com/438499 [ Linux ] http/tests/workers/text-encoding.html [ Timeout ]
crbug.com/438499 [ Linux ] http/tests/devtools/profiler/heap-snapshot-loader.js [ Timeout ] crbug.com/438499 [ Linux ] http/tests/devtools/profiler/heap-snapshot-loader.js [ Timeout ]
crbug.com/438499 [ Linux ] virtual/binary-for-devtools/http/tests/devtools/profiler/heap-snapshot-loader.js [ Timeout ] crbug.com/438499 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/profiler/heap-snapshot-loader.js [ Timeout ]
crbug.com/438499 [ Linux ] http/tests/devtools/profiler/heap-snapshot-containment-show-all.js [ Timeout ] crbug.com/438499 [ Linux ] http/tests/devtools/profiler/heap-snapshot-containment-show-all.js [ Timeout ]
crbug.com/438499 [ Linux ] virtual/binary-for-devtools/http/tests/devtools/profiler/heap-snapshot-containment-show-all.js [ Timeout ] crbug.com/438499 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/profiler/heap-snapshot-containment-show-all.js [ Timeout ]
crbug.com/438499 [ Linux ] virtual/threaded/animations/unanimated-style.html [ Timeout ] crbug.com/438499 [ Linux ] virtual/threaded/animations/unanimated-style.html [ Timeout ]
# Flakily timeout on Linux ASAN bots. # Flakily timeout on Linux ASAN bots.
...@@ -58,9 +58,9 @@ crbug.com/243871 [ Linux ] virtual/threaded/fast/scroll-behavior/ [ Skip ] ...@@ -58,9 +58,9 @@ crbug.com/243871 [ Linux ] virtual/threaded/fast/scroll-behavior/ [ Skip ]
crbug.com/464065 [ Linux ] media/track/css-cue-for-video-in-shadow.html [ Timeout ] crbug.com/464065 [ Linux ] media/track/css-cue-for-video-in-shadow.html [ Timeout ]
crbug.com/464065 [ Linux ] media/track/css-cue-for-video-in-shadow-2.html [ Timeout ] crbug.com/464065 [ Linux ] media/track/css-cue-for-video-in-shadow-2.html [ Timeout ]
crbug.com/572723 [ Linux ] http/tests/devtools/sources/debugger/debugger-completions-on-call-frame.js [ Timeout Pass ] crbug.com/572723 [ Linux ] http/tests/devtools/sources/debugger/debugger-completions-on-call-frame.js [ Timeout Pass ]
crbug.com/572723 [ Linux ] virtual/binary-for-devtools/http/tests/devtools/sources/debugger/debugger-completions-on-call-frame.js [ Timeout Pass ] crbug.com/572723 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/sources/debugger/debugger-completions-on-call-frame.js [ Timeout Pass ]
crbug.com/700795 [ Linux ] http/tests/devtools/animation/animation-transition-setTiming-crash.js [ Skip ] crbug.com/700795 [ Linux ] http/tests/devtools/animation/animation-transition-setTiming-crash.js [ Skip ]
crbug.com/700795 [ Linux ] virtual/binary-for-devtools/http/tests/devtools/animation/animation-transition-setTiming-crash.js [ Skip ] crbug.com/700795 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/animation/animation-transition-setTiming-crash.js [ Skip ]
crbug.com/928941 [ Linux ] external/wpt/background-fetch/fetch.https.window.html [ Timeout ] crbug.com/928941 [ Linux ] external/wpt/background-fetch/fetch.https.window.html [ Timeout ]
# Intentionally failed allocations, via partitionAllocGenericFlags() # Intentionally failed allocations, via partitionAllocGenericFlags()
...@@ -68,7 +68,9 @@ crbug.com/577889 [ Linux ] fast/js/typed-array-allocation-failure.html [ Crash ] ...@@ -68,7 +68,9 @@ crbug.com/577889 [ Linux ] fast/js/typed-array-allocation-failure.html [ Crash ]
# Memory allocation hooks are disabled on ASAN/MSAN # Memory allocation hooks are disabled on ASAN/MSAN
crbug.com/803276 inspector-protocol/memory/sampling-native-profile.js [ Skip ] crbug.com/803276 inspector-protocol/memory/sampling-native-profile.js [ Skip ]
crbug.com/803276 virtual/nobinary-for-inspector-protocol/inspector-protocol/memory/sampling-native-profile.js [ Skip ]
crbug.com/803276 inspector-protocol/memory/sampling-native-snapshot.js [ Skip ] crbug.com/803276 inspector-protocol/memory/sampling-native-snapshot.js [ Skip ]
crbug.com/803276 virtual/nobinary-for-inspector-protocol/inspector-protocol/memory/sampling-native-snapshot.js [ Skip ]
crbug.com/803276 virtual/sampling-heap-profiler/inspector-protocol/memory/sampling-native-profile.js [ Skip ] crbug.com/803276 virtual/sampling-heap-profiler/inspector-protocol/memory/sampling-native-profile.js [ Skip ]
crbug.com/803276 virtual/sampling-heap-profiler/inspector-protocol/memory/sampling-native-snapshot.js [ Skip ] crbug.com/803276 virtual/sampling-heap-profiler/inspector-protocol/memory/sampling-native-snapshot.js [ Skip ]
......
third_party/blink/web_tests/FlagExpectations/disable-features=NetworkService
View file @ 839ed279
...@@ -7,8 +7,11 @@ crbug.com/800898 external/wpt/workers/shared-worker-from-blob-url.window.html [ ...@@ -7,8 +7,11 @@ crbug.com/800898 external/wpt/workers/shared-worker-from-blob-url.window.html [
crbug.com/800898 virtual/omt-worker-fetch/external/wpt/workers/shared-worker-from-blob-url.window.html [ Skip ] crbug.com/800898 virtual/omt-worker-fetch/external/wpt/workers/shared-worker-from-blob-url.window.html [ Skip ]
crbug.com/595993 external/wpt/service-workers/service-worker/request-end-to-end.https.html [ Failure ] crbug.com/595993 external/wpt/service-workers/service-worker/request-end-to-end.https.html [ Failure ]
crbug.com/896924 http/tests/inspector-protocol/network/interception-multiclient.js [ Timeout Failure ] crbug.com/896924 http/tests/inspector-protocol/network/interception-multiclient.js [ Timeout Failure ]
crbug.com/896924 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/interception-multiclient.js [ Timeout Failure ]
crbug.com/899303 http/tests/inspector-protocol/fetch/fetch-basic.js [ Timeout ] crbug.com/899303 http/tests/inspector-protocol/fetch/fetch-basic.js [ Timeout ]
crbug.com/899303 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/fetch/fetch-basic.js [ Timeout ]
crbug.com/899303 http/tests/inspector-protocol/fetch/fetch-renderer.js [ Timeout ] crbug.com/899303 http/tests/inspector-protocol/fetch/fetch-renderer.js [ Timeout ]
crbug.com/899303 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/fetch/fetch-renderer.js [ Timeout ]
crbug.com/917284 external/wpt/service-workers/service-worker/claim-fetch-with-appcache.https.html [ Failure ] crbug.com/917284 external/wpt/service-workers/service-worker/claim-fetch-with-appcache.https.html [ Failure ]
crbug.com/917284 virtual/disabled-service-worker-servicification/external/wpt/service-workers/service-worker/claim-fetch-with-appcache.https.html [ Failure ] crbug.com/917284 virtual/disabled-service-worker-servicification/external/wpt/service-workers/service-worker/claim-fetch-with-appcache.https.html [ Failure ]
crbug.com/933880 external/wpt/FileAPI/url/cross-global-revoke.sub.html [ Failure ] crbug.com/933880 external/wpt/FileAPI/url/cross-global-revoke.sub.html [ Failure ]
...@@ -24,4 +27,4 @@ Bug(none) http/tests/misc/redirect-to-about-blank.html [ Pass ] ...@@ -24,4 +27,4 @@ Bug(none) http/tests/misc/redirect-to-about-blank.html [ Pass ]
Bug(none) virtual/omt-worker-fetch [ Skip ] Bug(none) virtual/omt-worker-fetch [ Skip ]
Bug(none) virtual/outofblink-cors [ Skip ] Bug(none) virtual/outofblink-cors [ Skip ]
Bug(none) http/tests/inspector-protocol/fetch [ Skip ] Bug(none) http/tests/inspector-protocol/fetch [ Skip ]
Bug(none) virtual/binary-for-inspector-protocol/http/tests/inspector-protocol/fetch [ Skip ] Bug(none) virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/fetch [ Skip ]
third_party/blink/web_tests/FlagExpectations/disable-site-isolation-trials
View file @ 839ed279
...@@ -13,13 +13,13 @@ crbug.com/933880 external/wpt/FileAPI/url/url-with-fetch.any.html [ Failure ] ...@@ -13,13 +13,13 @@ crbug.com/933880 external/wpt/FileAPI/url/url-with-fetch.any.html [ Failure ]
crbug.com/933880 external/wpt/FileAPI/url/url-with-xhr.any.html [ Failure ] crbug.com/933880 external/wpt/FileAPI/url/url-with-xhr.any.html [ Failure ]
crbug.com/933880 external/wpt/service-workers/service-worker/request-end-to-end.https.html [ Failure ] crbug.com/933880 external/wpt/service-workers/service-worker/request-end-to-end.https.html [ Failure ]
crbug.com/933880 http/tests/inspector-protocol/network/interception-take-stream.js [ Failure ] crbug.com/933880 http/tests/inspector-protocol/network/interception-take-stream.js [ Failure ]
crbug.com/933880 virtual/binary-for-inspector-protocol/http/tests/inspector-protocol/network/interception-take-stream.js [ Failure ] crbug.com/933880 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/interception-take-stream.js [ Failure ]
crbug.com/933880 http/tests/inspector-protocol/network/raw-headers-for-protected-document.js [ Failure ] crbug.com/933880 http/tests/inspector-protocol/network/raw-headers-for-protected-document.js [ Failure ]
crbug.com/933880 virtual/binary-for-inspector-protocol/http/tests/inspector-protocol/network/raw-headers-for-protected-document.js [ Failure ] crbug.com/933880 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/raw-headers-for-protected-document.js [ Failure ]
crbug.com/933880 http/tests/inspector-protocol/network/raw-headers-for-websocket.js [ Failure ] crbug.com/933880 http/tests/inspector-protocol/network/raw-headers-for-websocket.js [ Failure ]
crbug.com/933880 virtual/binary-for-inspector-protocol/http/tests/inspector-protocol/network/raw-headers-for-websocket.js [ Failure ] crbug.com/933880 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/raw-headers-for-websocket.js [ Failure ]
crbug.com/933880 http/tests/inspector-protocol/network/security-info-on-response.js [ Failure ] crbug.com/933880 http/tests/inspector-protocol/network/security-info-on-response.js [ Failure ]
crbug.com/933880 virtual/binary-for-inspector-protocol/http/tests/inspector-protocol/network/security-info-on-response.js [ Failure ] crbug.com/933880 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/security-info-on-response.js [ Failure ]
crbug.com/933880 http/tests/inspector-protocol/network/xhr-interception-auth-fail.js [ Failure ] crbug.com/933880 http/tests/inspector-protocol/network/xhr-interception-auth-fail.js [ Failure ]
crbug.com/933880 virtual/binary-for-inspector-protocol/http/tests/inspector-protocol/network/xhr-interception-auth-fail.js [ Failure ] crbug.com/933880 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/xhr-interception-auth-fail.js [ Failure ]
crbug.com/933880 http/tests/misc/redirect-to-about-blank.html [ Timeout ] crbug.com/933880 http/tests/misc/redirect-to-about-blank.html [ Timeout ]
third_party/blink/web_tests/FlagExpectations/enable-blink-features=CompositeAfterPaint
View file @ 839ed279
# Expectations for CompositeAfterPaint # Expectations for CompositeAfterPaint
# See: https://docs.google.com/document/d/1QCM912Dr6u38DqyQqd7pxQxDy8FFOoWMMDq7uAXqKdA/view # See: https://docs.google.com/document/d/1QCM912Dr6u38DqyQqd7pxQxDy8FFOoWMMDq7uAXqKdA/view
Bug(none) http/tests/devtools/tracing/ [ Skip ] Bug(none) http/tests/devtools/tracing/ [ Skip ]
Bug(none) virtual/nobinary-for-devtools/http/tests/devtools/tracing/ [ Skip ]
Bug(none) scrollingcoordinator/ [ Skip ] Bug(none) scrollingcoordinator/ [ Skip ]
Bug(none) virtual/disable-blink-gen-property-trees/ [ Skip ] Bug(none) virtual/disable-blink-gen-property-trees/ [ Skip ]
...@@ -13,7 +14,6 @@ Bug(none) virtual/prefer_compositing_to_lcd_text/compositing/overflow/ [ Skip ] ...@@ -13,7 +14,6 @@ Bug(none) virtual/prefer_compositing_to_lcd_text/compositing/overflow/ [ Skip ]
Bug(none) virtual/stable/ [ Skip ] Bug(none) virtual/stable/ [ Skip ]
# For now we track the failures of the base tests of the following virtual suites. # For now we track the failures of the base tests of the following virtual suites.
Bug(none) virtual/binary-for-devtools/http/tests/devtools [ Skip ]
Bug(none) virtual/exotic-color-space/images/ [ Skip ] Bug(none) virtual/exotic-color-space/images/ [ Skip ]
Bug(none) virtual/gpu-rasterization/images/ [ Skip ] Bug(none) virtual/gpu-rasterization/images/ [ Skip ]
Bug(none) virtual/mouseevent_fractional/fast/events/touch/ [ Skip ] Bug(none) virtual/mouseevent_fractional/fast/events/touch/ [ Skip ]
...@@ -446,11 +446,15 @@ Bug(none) css3/filters/blur-filter-page-scroll-self.html [ Failure ] ...@@ -446,11 +446,15 @@ Bug(none) css3/filters/blur-filter-page-scroll-self.html [ Failure ]
# Crash during PictureLayer::GetPicture() when DisplayItemList is finished twice. # Crash during PictureLayer::GetPicture() when DisplayItemList is finished twice.
Bug(none) http/tests/devtools/layers/layer-canvas-log.js [ Crash ] Bug(none) http/tests/devtools/layers/layer-canvas-log.js [ Crash ]
Bug(none) virtual/nobinary-for-devtools/http/tests/devtools/layers/layer-canvas-log.js [ Crash ]
Bug(none) http/tests/devtools/layers/layer-replay-scale.js [ Crash ] Bug(none) http/tests/devtools/layers/layer-replay-scale.js [ Crash ]
Bug(none) virtual/nobinary-for-devtools/http/tests/devtools/layers/layer-replay-scale.js [ Crash ]
# Missing compositing reasons # Missing compositing reasons
Bug(none) http/tests/devtools/layers/layer-compositing-reasons.js [ Failure ] Bug(none) http/tests/devtools/layers/layer-compositing-reasons.js [ Failure ]
Bug(none) virtual/nobinary-for-devtools/http/tests/devtools/layers/layer-compositing-reasons.js [ Failure ]
# Missing WheelEventHandler # Missing WheelEventHandler
Bug(none) http/tests/devtools/layers/layer-scroll-rects-get.js [ Failure ] Bug(none) http/tests/devtools/layers/layer-scroll-rects-get.js [ Failure ]
Bug(none) virtual/nobinary-for-devtools/http/tests/devtools/layers/layer-scroll-rects-get.js [ Failure ]
# Other: # Other:
crbug.com/935728 fast/frames/transparent-scrollbar.html [ Failure ] crbug.com/935728 fast/frames/transparent-scrollbar.html [ Failure ]
......
third_party/blink/web_tests/FlagExpectations/enable-blink-features=LayoutNG
View file @ 839ed279
...@@ -433,14 +433,23 @@ crbug.com/591099 html/marquee/marquee-destroyed-without-removed-from-crash.html ...@@ -433,14 +433,23 @@ crbug.com/591099 html/marquee/marquee-destroyed-without-removed-from-crash.html
crbug.com/591099 http/tests/appcache/non-html.xhtml [ Crash Pass ] crbug.com/591099 http/tests/appcache/non-html.xhtml [ Crash Pass ]
crbug.com/591099 http/tests/csspaint/invalidation-border-image.html [ Pass ] crbug.com/591099 http/tests/csspaint/invalidation-border-image.html [ Pass ]
crbug.com/591099 http/tests/devtools/elements/highlight/highlight-css-grid.js [ Failure ] crbug.com/591099 http/tests/devtools/elements/highlight/highlight-css-grid.js [ Failure ]
crbug.com/591099 virtual/nobinary-for-devtools/http/tests/devtools/elements/highlight/highlight-css-grid.js [ Failure ]
crbug.com/591099 http/tests/devtools/elements/shadow/shadow-distribution.js [ Failure ] crbug.com/591099 http/tests/devtools/elements/shadow/shadow-distribution.js [ Failure ]
crbug.com/591099 virtual/nobinary-for-devtools/http/tests/devtools/elements/shadow/shadow-distribution.js [ Failure ]
crbug.com/591099 http/tests/devtools/elements/styles-1/edit-value-url-with-color.js [ Pass ] crbug.com/591099 http/tests/devtools/elements/styles-1/edit-value-url-with-color.js [ Pass ]
crbug.com/591099 virtual/nobinary-for-devtools/http/tests/devtools/elements/styles-1/edit-value-url-with-color.js [ Pass ]
crbug.com/591099 http/tests/devtools/elements/user-properties.js [ Pass ] crbug.com/591099 http/tests/devtools/elements/user-properties.js [ Pass ]
crbug.com/591099 virtual/nobinary-for-devtools/http/tests/devtools/elements/user-properties.js [ Pass ]
crbug.com/591099 http/tests/devtools/service-workers/service-worker-v8-cache.js [ Timeout ] crbug.com/591099 http/tests/devtools/service-workers/service-worker-v8-cache.js [ Timeout ]
crbug.com/591099 virtual/nobinary-for-devtools/http/tests/devtools/service-workers/service-worker-v8-cache.js [ Timeout ]
crbug.com/591099 http/tests/devtools/sources/debugger-frameworks/frameworks-jquery.js [ Crash Pass ] crbug.com/591099 http/tests/devtools/sources/debugger-frameworks/frameworks-jquery.js [ Crash Pass ]
crbug.com/591099 virtual/nobinary-for-devtools/http/tests/devtools/sources/debugger-frameworks/frameworks-jquery.js [ Crash Pass ]
crbug.com/591099 http/tests/devtools/sources/debugger/debugger-proto-property.js [ Pass ] crbug.com/591099 http/tests/devtools/sources/debugger/debugger-proto-property.js [ Pass ]
crbug.com/591099 virtual/nobinary-for-devtools/http/tests/devtools/sources/debugger/debugger-proto-property.js [ Pass ]
crbug.com/591099 http/tests/devtools/tracing-session-id.js [ Pass ] crbug.com/591099 http/tests/devtools/tracing-session-id.js [ Pass ]
crbug.com/591099 virtual/nobinary-for-devtools/http/tests/devtools/tracing-session-id.js [ Pass ]
crbug.com/591099 http/tests/devtools/tracing/console-timeline.js [ Pass ] crbug.com/591099 http/tests/devtools/tracing/console-timeline.js [ Pass ]
crbug.com/591099 virtual/nobinary-for-devtools/http/tests/devtools/tracing/console-timeline.js [ Pass ]
crbug.com/591099 http/tests/fetch/chromium/response-blob-gc-crash.html [ Pass ] crbug.com/591099 http/tests/fetch/chromium/response-blob-gc-crash.html [ Pass ]
crbug.com/591099 http/tests/fetch/serviceworker-proxied/thorough/cookie-nocors-base-https-other-https.html [ Pass ] crbug.com/591099 http/tests/fetch/serviceworker-proxied/thorough/cookie-nocors-base-https-other-https.html [ Pass ]
crbug.com/591099 http/tests/fetch/serviceworker-proxied/thorough/redirect-nocors-base-https-other-https.html [ Pass ] crbug.com/591099 http/tests/fetch/serviceworker-proxied/thorough/redirect-nocors-base-https-other-https.html [ Pass ]
...@@ -453,6 +462,7 @@ crbug.com/591099 http/tests/fetch/workers/thorough/cookie-nocors-base-https-othe ...@@ -453,6 +462,7 @@ crbug.com/591099 http/tests/fetch/workers/thorough/cookie-nocors-base-https-othe
crbug.com/591099 http/tests/html/validation-bubble-oopif-clip.html [ Pass ] crbug.com/591099 http/tests/html/validation-bubble-oopif-clip.html [ Pass ]
crbug.com/591099 http/tests/images/feature-policy-unoptimized-images-cached-image.html [ Failure Pass ] crbug.com/591099 http/tests/images/feature-policy-unoptimized-images-cached-image.html [ Failure Pass ]
crbug.com/591099 http/tests/inspector-protocol/network/navigation-blocking-xorigin-iframe.js [ Failure Pass ] crbug.com/591099 http/tests/inspector-protocol/network/navigation-blocking-xorigin-iframe.js [ Failure Pass ]
crbug.com/591099 virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/network/navigation-blocking-xorigin-iframe.js [ Failure Pass ]
crbug.com/591099 http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-disabled.html [ Failure Pass ] crbug.com/591099 http/tests/media/autoplay/document-user-activation-cross-origin-feature-policy-disabled.html [ Failure Pass ]
crbug.com/591099 http/tests/media/video-load-metadata-decode-error.html [ Pass ] crbug.com/591099 http/tests/media/video-load-metadata-decode-error.html [ Pass ]
crbug.com/591099 http/tests/multipart/multipart-main-resource.html [ Pass ] crbug.com/591099 http/tests/multipart/multipart-main-resource.html [ Pass ]
...@@ -463,6 +473,7 @@ crbug.com/591099 http/tests/security/video-poster-cross-origin-crash2.html [ Pas ...@@ -463,6 +473,7 @@ crbug.com/591099 http/tests/security/video-poster-cross-origin-crash2.html [ Pas
crbug.com/591099 http/tests/webfont/crbug-655076.html [ Pass ] crbug.com/591099 http/tests/webfont/crbug-655076.html [ Pass ]
crbug.com/591099 images/feature-policy-oversized-images-resize.html [ Pass ] crbug.com/591099 images/feature-policy-oversized-images-resize.html [ Pass ]
crbug.com/591099 inspector-protocol/dom-snapshot/dom-snapshot-getSnapshot-origin-url.js [ Crash Pass ] crbug.com/591099 inspector-protocol/dom-snapshot/dom-snapshot-getSnapshot-origin-url.js [ Crash Pass ]
crbug.com/591099 virtual/nobinary-for-inspector-protocol/inspector-protocol/dom-snapshot/dom-snapshot-getSnapshot-origin-url.js [ Crash Pass ]
crbug.com/591099 jquery/offset.html [ Pass ] crbug.com/591099 jquery/offset.html [ Pass ]
crbug.com/591099 media/autoplay/webaudio-audio-context-resume.html [ Failure Pass ] crbug.com/591099 media/autoplay/webaudio-audio-context-resume.html [ Failure Pass ]
crbug.com/591099 media_capabilities/encodingInfo-avc1.html [ Failure ] crbug.com/591099 media_capabilities/encodingInfo-avc1.html [ Failure ]
...@@ -491,11 +502,6 @@ crbug.com/591099 virtual/bidi-caret-affinity/editing/selection/modify_move/move_ ...@@ -491,11 +502,6 @@ crbug.com/591099 virtual/bidi-caret-affinity/editing/selection/modify_move/move_
crbug.com/591099 virtual/bidi-caret-affinity/editing/selection/modify_move/move_left_word_09_rtl_multi_line.html [ Failure ] crbug.com/591099 virtual/bidi-caret-affinity/editing/selection/modify_move/move_left_word_09_rtl_multi_line.html [ Failure ]
crbug.com/591099 virtual/bidi-caret-affinity/editing/selection/modify_move/move_right_word_01_rtl_multi_line.html [ Failure ] crbug.com/591099 virtual/bidi-caret-affinity/editing/selection/modify_move/move_right_word_01_rtl_multi_line.html [ Failure ]
crbug.com/591099 virtual/bidi-caret-affinity/editing/selection/modify_move/move_right_word_05_rtl_multi_line.html [ Failure ] crbug.com/591099 virtual/bidi-caret-affinity/editing/selection/modify_move/move_right_word_05_rtl_multi_line.html [ Failure ]
crbug.com/591099 virtual/binary-for-devtools/http/tests/devtools/elements/highlight/highlight-css-grid.js [ Failure ]
crbug.com/591099 virtual/binary-for-devtools/http/tests/devtools/sources/debugger-frameworks/frameworks-jquery.js [ Crash Pass ]
crbug.com/591099 virtual/binary-for-inspector-protocol/http/tests/inspector-protocol/fetch/fetch-basic.js [ Pass ]
crbug.com/591099 virtual/binary-for-inspector-protocol/http/tests/inspector-protocol/fetch/fetch-renderer.js [ Pass ]
crbug.com/591099 virtual/binary-for-inspector-protocol/http/tests/inspector-protocol/network/interception-multiclient.js [ Pass ]
crbug.com/916511 virtual/composite-after-paint/paint/background/scrolling-background-with-negative-z-child.html [ Crash ] crbug.com/916511 virtual/composite-after-paint/paint/background/scrolling-background-with-negative-z-child.html [ Crash ]
crbug.com/591099 virtual/composite-after-paint/paint/invalidation/box/margin.html [ Failure Pass ] crbug.com/591099 virtual/composite-after-paint/paint/invalidation/box/margin.html [ Failure Pass ]
Bug(none) virtual/disable-blink-gen-property-trees/ [ Skip ] Bug(none) virtual/disable-blink-gen-property-trees/ [ Skip ]
......
third_party/blink/web_tests/LeakExpectations
View file @ 839ed279
...@@ -23,7 +23,7 @@ crbug.com/891575 virtual/android/fullscreen/video-overlay-scroll.html [ Leak Pas ...@@ -23,7 +23,7 @@ crbug.com/891575 virtual/android/fullscreen/video-overlay-scroll.html [ Leak Pas
crbug.com/786995 virtual/threaded/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js [ Leak Pass ] crbug.com/786995 virtual/threaded/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js [ Leak Pass ]
crbug.com/859640 http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js [ Leak Pass ] crbug.com/859640 http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js [ Leak Pass ]
crbug.com/859640 virtual/binary-for-devtools/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js [ Leak Pass ] crbug.com/859640 virtual/nobinary-for-devtools/http/tests/devtools/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.js [ Leak Pass ]
# Requests with keepalive specified will be kept alive even when the frame is # Requests with keepalive specified will be kept alive even when the frame is
# detached, which means leaks reported by the leak detector are by design. # detached, which means leaks reported by the leak detector are by design.
...@@ -36,7 +36,7 @@ crbug.com/651742 external/wpt/content-security-policy/connect-src/connect-src-be ...@@ -36,7 +36,7 @@ crbug.com/651742 external/wpt/content-security-policy/connect-src/connect-src-be
# ----------------------------------------------------------------- # -----------------------------------------------------------------
crbug.com/780386 external/wpt/html/dom/reflection-grouping.html [ Leak Pass ] crbug.com/780386 external/wpt/html/dom/reflection-grouping.html [ Leak Pass ]
crbug.com/667560 [ Linux ] http/tests/devtools/console/console-search.js [ Leak Pass ] crbug.com/667560 [ Linux ] http/tests/devtools/console/console-search.js [ Leak Pass ]
crbug.com/667560 [ Linux ] virtual/binary-for-devtools/http/tests/devtools/console/console-search.js [ Leak Pass ] crbug.com/667560 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/console/console-search.js [ Leak Pass ]
crbug.com/835943 [ Linux ] http/tests/appcache/non-html.xhtml [ Leak Pass ] crbug.com/835943 [ Linux ] http/tests/appcache/non-html.xhtml [ Leak Pass ]
crbug.com/860117 [ Linux ] editing/pasteboard/drag-drop-iframe-refresh-crash.html [ Pass Leak ] crbug.com/860117 [ Linux ] editing/pasteboard/drag-drop-iframe-refresh-crash.html [ Pass Leak ]
...@@ -63,14 +63,14 @@ crbug.com/848354 [ Linux ] plugins/fullscreen-plugins-dont-reload.html [ Pass Le ...@@ -63,14 +63,14 @@ crbug.com/848354 [ Linux ] plugins/fullscreen-plugins-dont-reload.html [ Pass Le
# Sheriff 2018-07-10 # Sheriff 2018-07-10
# Test flaking on Linux Trusty Leak # Test flaking on Linux Trusty Leak
crbug.com/862029 [ Linux ] http/tests/devtools/tracing/timeline-misc/timeline-window-filter.js [ Pass Leak ] crbug.com/862029 [ Linux ] http/tests/devtools/tracing/timeline-misc/timeline-window-filter.js [ Pass Leak ]
crbug.com/862029 [ Linux ] virtual/binary-for-devtools/http/tests/devtools/tracing/timeline-misc/timeline-window-filter.js [ Pass Leak ] crbug.com/862029 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/tracing/timeline-misc/timeline-window-filter.js [ Pass Leak ]
# Sheriff 2018-08-15 # Sheriff 2018-08-15
crbug.com/874442 [ Linux ] svg/animations/mpath-remove-from-dependents-on-delete-crash.html [ Pass Crash ] crbug.com/874442 [ Linux ] svg/animations/mpath-remove-from-dependents-on-delete-crash.html [ Pass Crash ]
# Sheriff 2018-08-17 # Sheriff 2018-08-17
crbug.com/847114 [ Linux ] http/tests/devtools/tracing/decode-resize.js [ Pass Failure ] crbug.com/847114 [ Linux ] http/tests/devtools/tracing/decode-resize.js [ Pass Failure ]
crbug.com/847114 [ Linux ] virtual/binary-for-devtools/http/tests/devtools/tracing/decode-resize.js [ Pass Failure ] crbug.com/847114 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/tracing/decode-resize.js [ Pass Failure ]
crbug.com/847114 [ Linux ] virtual/threaded/http/tests/devtools/tracing/decode-resize.js [ Pass Failure ] crbug.com/847114 [ Linux ] virtual/threaded/http/tests/devtools/tracing/decode-resize.js [ Pass Failure ]
# Sheriff 2018-08-29 # Sheriff 2018-08-29
...@@ -96,7 +96,7 @@ crbug.com/927454 [ Linux ] external/wpt/pointerevents/pointerevent_lostpointerca ...@@ -96,7 +96,7 @@ crbug.com/927454 [ Linux ] external/wpt/pointerevents/pointerevent_lostpointerca
#Sheriff 2019-02-21 #Sheriff 2019-02-21
crbug.com/934144 [ Linux ] http/tests/devtools/tracing/timeline-misc/timeline-flame-chart-automatically-size-window.js [ Pass Leak ] crbug.com/934144 [ Linux ] http/tests/devtools/tracing/timeline-misc/timeline-flame-chart-automatically-size-window.js [ Pass Leak ]
crbug.com/934144 [ Linux ] virtual/binary-for-devtools/http/tests/devtools/tracing/timeline-misc/timeline-flame-chart-automatically-size-window.js [ Pass Leak ] crbug.com/934144 [ Linux ] virtual/nobinary-for-devtools/http/tests/devtools/tracing/timeline-misc/timeline-flame-chart-automatically-size-window.js [ Pass Leak ]
#Sheriff 2019-02-25 #Sheriff 2019-02-25
crbug.com/894651 [ Linux ] virtual/bidi-caret-affinity/editing/selection/modify_move/move_left_word_09_rtl_multi_line.html [ Failure Leak ] crbug.com/894651 [ Linux ] virtual/bidi-caret-affinity/editing/selection/modify_move/move_left_word_09_rtl_multi_line.html [ Failure Leak ]
......
third_party/blink/web_tests/NeverFixTests
View file @ 839ed279
...@@ -144,10 +144,13 @@ fast/harness/results.html [ WontFix ] ...@@ -144,10 +144,13 @@ fast/harness/results.html [ WontFix ]
# Linux layout tests do not have a Myanmar fallback font. # Linux layout tests do not have a Myanmar fallback font.
[ Linux ] inspector-protocol/layout-fonts/fallback-myanmar.js [ WontFix ] [ Linux ] inspector-protocol/layout-fonts/fallback-myanmar.js [ WontFix ]
[ Linux ] virtual/nobinary-for-inspector-protocol/inspector-protocol/layout-fonts/fallback-myanmar.js [ WontFix ]
# Segoe UI matching is only relevant on Windows # Segoe UI matching is only relevant on Windows
[ Mac ] inspector-protocol/layout-fonts/font-weight-granularity-matching.js [ WontFix ] [ Mac ] inspector-protocol/layout-fonts/font-weight-granularity-matching.js [ WontFix ]
[ Mac ] virtual/nobinary-for-inspector-protocol/inspector-protocol/layout-fonts/font-weight-granularity-matching.js [ WontFix ]
[ Linux ] inspector-protocol/layout-fonts/font-weight-granularity-matching.js [ WontFix ] [ Linux ] inspector-protocol/layout-fonts/font-weight-granularity-matching.js [ WontFix ]
[ Linux ] virtual/nobinary-for-inspector-protocol/inspector-protocol/layout-fonts/font-weight-granularity-matching.js [ WontFix ]
# Tests in media/stable are only supposed to be run as virtual test (see virtual/stable/media). # Tests in media/stable are only supposed to be run as virtual test (see virtual/stable/media).
media/stable [ WontFix ] media/stable [ WontFix ]
...@@ -2206,7 +2209,7 @@ crbug.com/669083 virtual/outofblink-cors/http/tests/security/frameNavigation/xss ...@@ -2206,7 +2209,7 @@ crbug.com/669083 virtual/outofblink-cors/http/tests/security/frameNavigation/xss
# 3) site isolation is enabled without also enabling # 3) site isolation is enabled without also enabling
# IsolatedCodeCache (tests disabled by the test expectation below). # IsolatedCodeCache (tests disabled by the test expectation below).
Bug(none) http/tests/devtools/isolated-code-cache/cross-origin-test.js [ WontFix ] Bug(none) http/tests/devtools/isolated-code-cache/cross-origin-test.js [ WontFix ]
Bug(none) virtual/binary-for-devtools/http/tests/devtools/isolated-code-cache/cross-origin-test.js [ WontFix ] Bug(none) virtual/nobinary-for-devtools/http/tests/devtools/isolated-code-cache/cross-origin-test.js [ WontFix ]
# ==== Tests incompatible with the default WPT Origin Isolation end here ==^^ # ==== Tests incompatible with the default WPT Origin Isolation end here ==^^
# Tests using testRunner.useUnfortunateSynchronousResizeMode occasionally fail on Win7, # Tests using testRunner.useUnfortunateSynchronousResizeMode occasionally fail on Win7,
......
third_party/blink/web_tests/SlowTests
View file @ 839ed279
This diff is collapsed.
third_party/blink/web_tests/VirtualTestSuites
View file @ 839ed279
...@@ -296,14 +296,19 @@ ...@@ -296,14 +296,19 @@
"args": ["--enable-threaded-compositing"] "args": ["--enable-threaded-compositing"]
}, },
{ {
"prefix": "binary-for-devtools", "prefix": "nobinary-for-devtools",
"base": "http/tests/devtools", "base": "http/tests/devtools",
"args": ["--enable-internal-devtools-binary-protocol"] "args": ["--disable-internal-devtools-binary-protocol"]
}, },
{ {
"prefix": "binary-for-inspector-protocol", "prefix": "nobinary-for-http-inspector-protocol",
"base": "http/tests/inspector-protocol", "base": "http/tests/inspector-protocol",
"args": ["--enable-internal-devtools-binary-protocol"] "args": ["--disable-internal-devtools-binary-protocol"]
},
{
"prefix": "nobinary-for-inspector-protocol",
"base": "inspector-protocol",
"args": ["--disable-internal-devtools-binary-protocol"]
}, },
{ {
"prefix": "composite-after-paint", "prefix": "composite-after-paint",
......
third_party/blink/web_tests/inspector-protocol/dom/dom-getBoxModel-expected.txt
View file @ 839ed279
...@@ -21,12 +21,12 @@ DIV style,position:absolute;top:200;left:100;width:100;height:100;background:gre ...@@ -21,12 +21,12 @@ DIV style,position:absolute;top:200;left:100;width:100;height:100;background:gre
] ]
DIV style,position:absolute;top:150;left:50;width:100;height:100;background:blue;transform:rotate(45deg); [ DIV style,position:absolute;top:150;left:50;width:100;height:100;background:blue;transform:rotate(45deg); [
[0] : 100 [0] : 100
[1] : 129.289321899414 [1] : 129.28932189941406
[2] : 170.710678100586 [2] : 170.71067810058594
[3] : 200 [3] : 200
[4] : 100 [4] : 100
[5] : 270.710693359375 [5] : 270.710693359375
[6] : 29.2893218994141 [6] : 29.289321899414062
[7] : 200 [7] : 200
] ]
DIV style,width:100px;height:100px;background:orange [ DIV style,width:100px;height:100px;background:orange [
......
third_party/blink/web_tests/virtual/binary-for-devtools/http/tests/devtools/README.txt → third_party/blink/web_tests/virtual/nobinary-for-devtools/http/tests/devtools/README.txt
View file @ 839ed279
# This suite runs the tests in http/tests/devtools with # This suite runs the tests in http/tests/devtools with
# the additional flag --enable-internal-devtools-binary-protocol. # the additional flag --disable-internal-devtools-binary-protocol.
third_party/blink/web_tests/virtual/binary-for-inspector-protocol/http/tests/inspector-protocol/README.txt → third_party/blink/web_tests/virtual/nobinary-for-http-inspector-protocol/http/tests/inspector-protocol/README.txt
View file @ 839ed279
# This suite runs the tests in http/tests/inspector-protocol with # This suite runs the tests in http/tests/inspector-protocol with
# the additional flag --enable-internal-devtools-binary-protocol. # the additional flag --disable-internal-devtools-binary-protocol.
third_party/blink/web_tests/virtual/nobinary-for-inspector-protocol/inspector-protocol/README.txt 0 → 100644
View file @ 839ed279
# This suite runs the tests in inspector-protocol with
# the additional flag --disable-internal-devtools-binary-protocol.
third_party/blink/web_tests/virtual/nobinary-for-inspector-protocol/inspector-protocol/dom/dom-getBoxModel-expected.txt 0 → 100644
View file @ 839ed279
Tests DOM.getBoxModel method.
DIV style,position:absolute;top:100;left:0;width:100;height:100;background:red [
[0] : 0
[1] : 100
[2] : 100
[3] : 100
[4] : 100
[5] : 200
[6] : 0
[7] : 200
]
DIV style,position:absolute;top:200;left:100;width:100;height:100;background:green [
[0] : 100
[1] : 200
[2] : 200
[3] : 200
[4] : 200
[5] : 300
[6] : 100
[7] : 300
]
DIV style,position:absolute;top:150;left:50;width:100;height:100;background:blue;transform:rotate(45deg); [
[0] : 100
[1] : 129.289321899414
[2] : 170.710678100586
[3] : 200
[4] : 100
[5] : 270.710693359375
[6] : 29.2893218994141
[7] : 200
]
DIV style,width:100px;height:100px;background:orange [
[0] : 210
[1] : 210
[2] : 310
[3] : 210
[4] : 310
[5] : 310
[6] : 210
[7] : 310
]
rect id,theRect,x,30,y,50,width,100,height,100 [
[0] : 432
[1] : 452
[2] : 532
[3] : 452
[4] : 532
[5] : 552
[6] : 432
[7] : 552
]
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment