Skip to content

GitLab

T
tangled
Commit 83b86e5a authored by tkent@chromium.org's avatar tkent@chromium.org
Browse files
Options

Mac: Update CSS appearance for input[type=color][list]. 

r168130 updated -webkit-appearance:menulist-button implementation. We should
update the CSS ruleset for input[type=color][list] too because it uses
menulist-button when it is styled.

BUG=345609
TEST=automated

Review URL: https://codereview.chromium.org/180163012

git-svn-id: svn://svn.chromium.org/blink/trunk@168519 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent ecddfb29
Hide whitespace changes
Inline Side-by-side
Showing with 60 additions and 19 deletions
third_party/WebKit/LayoutTests/TestExpectations
View file @ 83b86e5a
...@@ -895,7 +895,7 @@ crbug.com/347365 [ Linux ] dom/xhtml/level3/core/canonicalform09.xhtml [ Crash P ...@@ -895,7 +895,7 @@ crbug.com/347365 [ Linux ] dom/xhtml/level3/core/canonicalform09.xhtml [ Crash P
# Flaky since being added # Flaky since being added
crbug.com/340277 http/tests/navigation/back-to-get-after-post.php [ Failure Pass ] crbug.com/340277 http/tests/navigation/back-to-get-after-post.php [ Failure Pass ]
crbug.com/345609 fast/forms/color/input-appearance-color.html [ NeedsRebaseline ]
crbug.com/309197 [ Win ] fast/block/float/overhanging-tall-block.html [ NeedsManualRebaseline ] crbug.com/309197 [ Win ] fast/block/float/overhanging-tall-block.html [ NeedsManualRebaseline ]
crbug.com/309197 [ Win ] fast/gradients/css3-radial-gradients2.html [ NeedsManualRebaseline ] crbug.com/309197 [ Win ] fast/gradients/css3-radial-gradients2.html [ NeedsManualRebaseline ]
......
third_party/WebKit/LayoutTests/fast/forms/color/input-appearance-color.html
View file @ 83b86e5a
<h3>Default Appearance</h3> <h3>Default Appearance</h3>
List color controls have different appearance if ENABLE(DATALIST).<br> List color controls have different appearance.<br>
<input type="color"><input type="color" list> <input type="color"><input type="color" list>
<h3>Different Font Sizes</h3> <h3>Different Font Sizes</h3>
List color controls have different sizes depending on font sizes. Normal color controls don't.<br> List color controls have different sizes depending on font sizes. Normal color controls don't.<br>
...@@ -21,4 +21,11 @@ List color controls have different sizes depending on font sizes. Normal color c ...@@ -21,4 +21,11 @@ List color controls have different sizes depending on font sizes. Normal color c
<input type="color" value="#EC008C" list> <input type="color" value="#EC008C" list>
<input type="color" value="#40e0d0" list> <input type="color" value="#40e0d0" list>
<h3>Arbitrary Size</h3> <h3>Arbitrary Size</h3>
<input type="color" value="#FF0000" style="width:100px;height:30px;"> <input type="color" value="#FF0000" style="width:100px;height:30px;">
\ No newline at end of file <input type="color" value="#FF0000" style="zoom:2">
<input type="color" value="#FF0000" style="zoom:2" list>
<h3>Other styles</h3>
<input type="color" value="#FF0000" style="background-color:yellow">
<input type="color" value="#FF0000" style="background-color:yellow" list>
<input type="color" value="#FF0000" style="border:1px solid lime; border-radius:0">
<input type="color" value="#FF0000" style="border:1px solid lime; border-radius:0" list>
third_party/WebKit/LayoutTests/platform/mac/fast/forms/color/input-appearance-color-expected.txt
View file @ 83b86e5a
...@@ -7,13 +7,13 @@ layer at (0,0) size 800x600 ...@@ -7,13 +7,13 @@ layer at (0,0) size 800x600
RenderText {#text} at (0,0) size 157x22 RenderText {#text} at (0,0) size 157x22
text run at (0,0) width 157: "Default Appearance" text run at (0,0) width 157: "Default Appearance"
RenderBlock (anonymous) at (0,40.72) size 784x41 RenderBlock (anonymous) at (0,40.72) size 784x41
RenderText {#text} at (0,0) size 456x18 RenderText {#text} at (0,0) size 284x18
text run at (0,0) width 456: "List color controls have different appearance if ENABLE(DATALIST)." text run at (0,0) width 284: "List color controls have different appearance."
RenderBR {BR} at (456,14) size 0x0 RenderBR {BR} at (284,14) size 0x0
RenderBlock {INPUT} at (0,18) size 44x23 [bgcolor=#FFFFFF] [border: none (2px inset #EEEEEE) none (2px inset #EEEEEE)] RenderBlock {INPUT} at (0,18) size 44x23 [bgcolor=#FFFFFF] [border: none (2px inset #EEEEEE) none (2px inset #EEEEEE)]
RenderFlexibleBox {DIV} at (3,1) size 38x21 RenderFlexibleBox {DIV} at (3,1) size 38x21
RenderBlock {DIV} at (2,4) size 34x13 [bgcolor=#000000] [border: (1px solid #777777)] RenderBlock {DIV} at (2,4) size 34x13 [bgcolor=#000000] [border: (1px solid #777777)]
RenderBlock {INPUT} at (44,22) size 88x18 [bgcolor=#FFFFFF] RenderBlock {INPUT} at (44,22) size 88x18 [bgcolor=#F8F8F8]
RenderFlexibleBox {DIV} at (0,0) size 88x18 RenderFlexibleBox {DIV} at (0,0) size 88x18
RenderBlock {DIV} at (8,4) size 56x10 [bgcolor=#000000] [border: (1px solid #000000)] RenderBlock {DIV} at (8,4) size 56x10 [bgcolor=#000000] [border: (1px solid #000000)]
RenderText {#text} at (0,0) size 0x0 RenderText {#text} at (0,0) size 0x0
...@@ -39,17 +39,17 @@ layer at (0,0) size 800x600 ...@@ -39,17 +39,17 @@ layer at (0,0) size 800x600
RenderBlock {DIV} at (2,4) size 34x13 [bgcolor=#00FF00] [border: (1px solid #777777)] RenderBlock {DIV} at (2,4) size 34x13 [bgcolor=#00FF00] [border: (1px solid #777777)]
RenderText {#text} at (140,21) size 4x18 RenderText {#text} at (140,21) size 4x18
text run at (140,21) width 4: " " text run at (140,21) width 4: " "
RenderBlock {INPUT} at (144,19) size 88x21 [bgcolor=#FFFFFF] RenderBlock {INPUT} at (144,19) size 88x21 [bgcolor=#F8F8F8]
RenderFlexibleBox {DIV} at (0,0) size 88x21 RenderFlexibleBox {DIV} at (0,0) size 88x21
RenderBlock {DIV} at (8,4) size 56x13 [bgcolor=#00FF00] [border: (1px solid #000000)] RenderBlock {DIV} at (8,4) size 56x13 [bgcolor=#00FF00] [border: (1px solid #000000)]
RenderText {#text} at (232,21) size 4x18 RenderText {#text} at (232,21) size 4x18
text run at (232,21) width 4: " " text run at (232,21) width 4: " "
RenderBlock {INPUT} at (236,22) size 88x18 [bgcolor=#FFFFFF] RenderBlock {INPUT} at (236,22) size 88x18 [bgcolor=#F8F8F8]
RenderFlexibleBox {DIV} at (0,0) size 88x18 RenderFlexibleBox {DIV} at (0,0) size 88x18
RenderBlock {DIV} at (8,4) size 56x10 [bgcolor=#00FF00] [border: (1px solid #000000)] RenderBlock {DIV} at (8,4) size 56x10 [bgcolor=#00FF00] [border: (1px solid #000000)]
RenderText {#text} at (324,21) size 4x18 RenderText {#text} at (324,21) size 4x18
text run at (324,21) width 4: " " text run at (324,21) width 4: " "
RenderBlock {INPUT} at (328,25) size 88x15 [bgcolor=#FFFFFF] RenderBlock {INPUT} at (328,25) size 88x15 [bgcolor=#F8F8F8]
RenderFlexibleBox {DIV} at (0,0) size 88x15 RenderFlexibleBox {DIV} at (0,0) size 88x15
RenderBlock {DIV} at (8,4) size 56x7 [bgcolor=#00FF00] [border: (1px solid #000000)] RenderBlock {DIV} at (8,4) size 56x7 [bgcolor=#00FF00] [border: (1px solid #000000)]
RenderText {#text} at (0,0) size 0x0 RenderText {#text} at (0,0) size 0x0
...@@ -82,34 +82,68 @@ layer at (0,0) size 800x600 ...@@ -82,34 +82,68 @@ layer at (0,0) size 800x600
RenderBlock {DIV} at (2,4) size 34x13 [bgcolor=#40E0D0] [border: (1px solid #777777)] RenderBlock {DIV} at (2,4) size 34x13 [bgcolor=#40E0D0] [border: (1px solid #777777)]
RenderText {#text} at (236,3) size 4x18 RenderText {#text} at (236,3) size 4x18
text run at (236,3) width 4: " " text run at (236,3) width 4: " "
RenderBlock {INPUT} at (240,4) size 88x18 [bgcolor=#FFFFFF] RenderBlock {INPUT} at (240,4) size 88x18 [bgcolor=#F8F8F8]
RenderFlexibleBox {DIV} at (0,0) size 88x18 RenderFlexibleBox {DIV} at (0,0) size 88x18
RenderBlock {DIV} at (8,4) size 56x10 [bgcolor=#FF0000] [border: (1px solid #000000)] RenderBlock {DIV} at (8,4) size 56x10 [bgcolor=#FF0000] [border: (1px solid #000000)]
RenderText {#text} at (328,3) size 4x18 RenderText {#text} at (328,3) size 4x18
text run at (328,3) width 4: " " text run at (328,3) width 4: " "
RenderBlock {INPUT} at (332,4) size 88x18 [bgcolor=#FFFFFF] RenderBlock {INPUT} at (332,4) size 88x18 [bgcolor=#F8F8F8]
RenderFlexibleBox {DIV} at (0,0) size 88x18 RenderFlexibleBox {DIV} at (0,0) size 88x18
RenderBlock {DIV} at (8,4) size 56x10 [bgcolor=#00FF00] [border: (1px solid #000000)] RenderBlock {DIV} at (8,4) size 56x10 [bgcolor=#00FF00] [border: (1px solid #000000)]
RenderText {#text} at (420,3) size 4x18 RenderText {#text} at (420,3) size 4x18
text run at (420,3) width 4: " " text run at (420,3) width 4: " "
RenderBlock {INPUT} at (424,4) size 88x18 [bgcolor=#FFFFFF] RenderBlock {INPUT} at (424,4) size 88x18 [bgcolor=#F8F8F8]
RenderFlexibleBox {DIV} at (0,0) size 88x18 RenderFlexibleBox {DIV} at (0,0) size 88x18
RenderBlock {DIV} at (8,4) size 56x10 [bgcolor=#0000FF] [border: (1px solid #000000)] RenderBlock {DIV} at (8,4) size 56x10 [bgcolor=#0000FF] [border: (1px solid #000000)]
RenderText {#text} at (512,3) size 4x18 RenderText {#text} at (512,3) size 4x18
text run at (512,3) width 4: " " text run at (512,3) width 4: " "
RenderBlock {INPUT} at (516,4) size 88x18 [bgcolor=#FFFFFF] RenderBlock {INPUT} at (516,4) size 88x18 [bgcolor=#F8F8F8]
RenderFlexibleBox {DIV} at (0,0) size 88x18 RenderFlexibleBox {DIV} at (0,0) size 88x18
RenderBlock {DIV} at (8,4) size 56x10 [bgcolor=#EC008C] [border: (1px solid #000000)] RenderBlock {DIV} at (8,4) size 56x10 [bgcolor=#EC008C] [border: (1px solid #000000)]
RenderText {#text} at (604,3) size 4x18 RenderText {#text} at (604,3) size 4x18
text run at (604,3) width 4: " " text run at (604,3) width 4: " "
RenderBlock {INPUT} at (608,4) size 88x18 [bgcolor=#FFFFFF] RenderBlock {INPUT} at (608,4) size 88x18 [bgcolor=#F8F8F8]
RenderFlexibleBox {DIV} at (0,0) size 88x18 RenderFlexibleBox {DIV} at (0,0) size 88x18
RenderBlock {DIV} at (8,4) size 56x10 [bgcolor=#40E0D0] [border: (1px solid #000000)] RenderBlock {DIV} at (8,4) size 56x10 [bgcolor=#40E0D0] [border: (1px solid #000000)]
RenderText {#text} at (0,0) size 0x0 RenderText {#text} at (0,0) size 0x0
RenderBlock {H3} at (0,283.31) size 784x22 RenderBlock {H3} at (0,283.31) size 784x22
RenderText {#text} at (0,0) size 113x22 RenderText {#text} at (0,0) size 113x22
text run at (0,0) width 113: "Arbitrary Size" text run at (0,0) width 113: "Arbitrary Size"
RenderBlock (anonymous) at (0,324.03) size 784x30 RenderBlock (anonymous) at (0,324.03) size 784x46
RenderBlock {INPUT} at (0,0) size 100x30 [bgcolor=#FFFFFF] [border: none (2px inset #EEEEEE) none (2px inset #EEEEEE)] RenderBlock {INPUT} at (0,10) size 100x30 [bgcolor=#FFFFFF] [border: none (2px inset #EEEEEE) none (2px inset #EEEEEE)]
RenderFlexibleBox {DIV} at (3,1) size 94x28 RenderFlexibleBox {DIV} at (3,1) size 94x28
RenderBlock {DIV} at (2,4) size 90x20 [bgcolor=#FF0000] [border: (1px solid #777777)] RenderBlock {DIV} at (2,4) size 90x20 [bgcolor=#FF0000] [border: (1px solid #777777)]
RenderText {#text} at (100,20) size 4x18
text run at (100,20) width 4: " "
RenderBlock {INPUT} at (104,0) size 88x46 [bgcolor=#FFFFFF] [border: none (4px inset #EEEEEE) none (4px inset #EEEEEE)]
RenderFlexibleBox {DIV} at (6,2) size 76x42
RenderBlock {DIV} at (4,8) size 68x26 [bgcolor=#FF0000] [border: (2px solid #777777)]
RenderText {#text} at (192,20) size 4x18
text run at (192,20) width 4: " "
RenderBlock {INPUT} at (196,0) size 176x46 [bgcolor=#F8F8F8] [border: (2px solid #A6A6A6)]
RenderFlexibleBox {DIV} at (2,2) size 172x42
RenderBlock {DIV} at (16,8) size 108x26 [bgcolor=#FF0000] [border: (2px solid #000000)]
RenderText {#text} at (0,0) size 0x0
RenderBlock {H3} at (0,388.75) size 784x22
RenderText {#text} at (0,0) size 94x22
text run at (0,0) width 94: "Other styles"
RenderBlock (anonymous) at (0,429.47) size 784x25
RenderBlock {INPUT} at (0,2) size 44x23 [bgcolor=#FFFF00] [border: (2px inset #EEEEEE)]
RenderFlexibleBox {DIV} at (3,3) size 38x17
RenderBlock {DIV} at (2,4) size 34x9 [bgcolor=#FF0000] [border: (1px solid #777777)]
RenderText {#text} at (44,3) size 4x18
text run at (44,3) width 4: " "
RenderBlock {INPUT} at (48,0) size 88x23 [bgcolor=#FFFF00] [border: (1px solid #A6A6A6)]
RenderFlexibleBox {DIV} at (1,1) size 86x21
RenderBlock {DIV} at (8,4) size 54x13 [bgcolor=#FF0000] [border: (1px solid #000000)]
RenderText {#text} at (136,3) size 4x18
text run at (136,3) width 4: " "
RenderBlock {INPUT} at (140,1) size 44x23 [bgcolor=#FFFFFF] [border: (1px solid #00FF00)]
RenderFlexibleBox {DIV} at (2,2) size 40x19
RenderBlock {DIV} at (2,4) size 36x11 [bgcolor=#FF0000] [border: (1px solid #777777)]
RenderText {#text} at (184,3) size 4x18
text run at (184,3) width 4: " "
RenderBlock {INPUT} at (188,0) size 88x23 [bgcolor=#F8F8F8] [border: (1px solid #00FF00)]
RenderFlexibleBox {DIV} at (1,1) size 86x21
RenderBlock {DIV} at (8,4) size 54x13 [bgcolor=#FF0000] [border: (1px solid #000000)]
RenderText {#text} at (0,0) size 0x0
third_party/WebKit/Source/core/css/themeMac.css
View file @ 83b86e5a
...@@ -3,9 +3,9 @@ ...@@ -3,9 +3,9 @@
* found in the LICENSE file. * found in the LICENSE file.
*/ */
select { select, input[type="color"][list] {
background-color: #f8f8f8; background-color: #f8f8f8;
border-color: #a6a6a6; border: 1px solid #a6a6a6;
} }
select[size], select[size],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment