[SettingsUI] Add customized item for managed on/off settings

- Add customized item and cell for settings which has a toggle switcher once not managed by policy.
- Apply to "Save Password" setting.
- Add corresponding method to handle click action of the info button.

Screenshot: https://screenshot.googleplex.com/6doUPsk0Dmj

Bug: 1087223
Change-Id: I3140c7cfb99dbaf46f8679c4e675b9ab0002d6c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219569
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774424}

ios/chrome/app/strings/ios_strings.grd

@@ -1654,9 +1654,6 @@ Handoff must also be enabled in the General section of Settings, and your device
       <message name="IDS_IOS_SETTINGS_SWIPE_DOWN_KEEP" desc="Button displayed along with a message alert whenever a user tries to dismiss a Settings screen which is being edited, or information is being added to it. Selecting this option will dismiss the message alert, and will keep displaying the settings screen.">
         Keep Editing
       </message>
-      <message name="IDS_IOS_TOGGLE_SETTING_SWITCH_ACCESSIBILITY_HINT" desc="Action hint for any switch in settings. This is spoken by VoiceOver. [iOS only]">
-        Double tap to toggle setting
-      </message>
       <message name="IDS_IOS_SHARE_BUTTON_LABEL" desc="Label of a button which will initiate a share flow. [iOS only]">
         Share...
       </message>
@@ -2038,6 +2035,15 @@ Your data was encrypted with your sync passphrase on <ph name="TIME">$2<ex>Sept
       <message name="IDS_IOS_TEXT_ZOOM_ZOOM_OUT" desc="Accessibility label for a button allowing the user to zoom out." meaning="User is asking page to zoom out">
         Zoom Out
       </message>
+      <message name="IDS_IOS_TOGGLE_SETTING_SWITCH_ACCESSIBILITY_HINT" desc="Action hint for any switch in settings. This is spoken by VoiceOver. [iOS only]">
+        Double tap to toggle setting
+      </message>
+      <message name="IDS_IOS_TOGGLE_SETTING_MANAGED_ACCESSIBILITY_HINT" desc="Action hint for any managed switch in settings. This is spoken by VoiceOver. [iOS only]">
+        This setting is managed
+      </message>
+      <message name="IDS_IOS_TOGGLE_SETTING_MANAGED_INFO_BUBBLE_MESSAGE" desc="Text displayed on the textual bubble about settings managed information. [iOS only]">
+        This setting is enforced by your administrator.
+      </message>
       <message name="IDS_IOS_TOOLBAR_CLOSE_MENU" desc="The accessibility label for the toolbar close settings menu button [iOS only].">
         Close Menu
       </message>

ios/chrome/browser/ui/settings/cells/BUILD.gn

@@ -18,6 +18,10 @@ source_set("cells") {
     "settings_image_detail_text_cell.mm",
     "settings_image_detail_text_item.h",
     "settings_image_detail_text_item.mm",
+    "settings_managed_cell.h",
+    "settings_managed_cell.mm",
+    "settings_managed_item.h",
+    "settings_managed_item.mm",
     "settings_multiline_detail_item.h",
     "settings_multiline_detail_item.mm",
     "settings_switch_cell.h",

ios/chrome/browser/ui/settings/cells/settings_managed_cell.h

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_UI_SETTINGS_CELLS_SETTINGS_MANAGED_CELL_H_
+#define IOS_CHROME_BROWSER_UI_SETTINGS_CELLS_SETTINGS_MANAGED_CELL_H_
+
+#import <UIKit/UIKit.h>
+
+#import "ios/chrome/browser/ui/table_view/cells/table_view_cell.h"
+
+// SettingsManagedCell implements a TableViewCell subclass containing an icon,
+// a text label, a detail text, a status text and an info button.
+// If the preferred content size category is an accessibility category, the
+// status text is displayed below the detail text, and the info button is
+// below the status text. Otherwise, they are on the trailing side.
+@interface SettingsManagedCell : TableViewCell
+
+// UILabel displayed next to the leading image icon if there is one, otherwise
+// this UILabel will be at the leading position. Corresponding to |text| from
+// the item.
+@property(nonatomic, readonly, strong) UILabel* textLabel;
+
+// UILabel displayed under the |textLabel| shows the description text.
+// Corresponding to |detailText| from the item.
+@property(nonatomic, readonly, strong) UILabel* detailTextLabel;
+
+// UILabel displayed at the trailing side of the view, it's trailing anchor
+// align with the leading anchor of the |bubbleView| below. It shows the status
+// of the setting's row. Mostly show On or Off, but there is use case that shows
+// a search engine name. Corresponding to |statusText| from the item.
+@property(nonatomic, readonly, strong) UILabel* statusTextLabel;
+
+// UIButton displayed aligned to the trailing of the view.
+@property(nonatomic, readonly, strong) UIButton* trailingButton;
+
+// Sets the image that should be displayed at the leading edge of the cell. If
+// set to nil, the icon will be hidden and the remaining content will expand to
+// fill the full width of the cell.
+- (void)setIconImage:(UIImage*)image;
+
+@end
+
+#endif  // IOS_CHROME_BROWSER_UI_SETTINGS_CELLS_SETTINGS_MANAGED_CELL_H_

ios/chrome/browser/ui/settings/cells/settings_managed_item.h

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_UI_SETTINGS_CELLS_SETTINGS_MANAGED_ITEM_H_
+#define IOS_CHROME_BROWSER_UI_SETTINGS_CELLS_SETTINGS_MANAGED_ITEM_H_
+
+#import <UIKit/UIKit.h>
+
+#import "ios/chrome/browser/ui/table_view/cells/table_view_item.h"
+
+// SettingsManagedItem is a model class that uses SettingsManagedCell.
+@interface SettingsManagedItem : TableViewItem
+
+// The filename for the leading icon. If empty, no icon will be shown.
+@property(nonatomic, copy) NSString* iconImageName;
+
+// The main text string.
+@property(nonatomic, copy) NSString* text;
+
+// The detail text string.
+@property(nonatomic, copy) NSString* detailText;
+
+// The status text string.
+@property(nonatomic, copy) NSString* statusText;
+
+@end
+
+#endif  // IOS_CHROME_BROWSER_UI_SETTINGS_CELLS_SETTINGS_MANAGED_ITEM_H_

ios/chrome/browser/ui/settings/cells/settings_managed_item.mm

+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/chrome/browser/ui/settings/cells/settings_managed_item.h"
+
+#import "ios/chrome/browser/ui/settings/cells/settings_managed_cell.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+@implementation SettingsManagedItem
+
+- (instancetype)initWithType:(NSInteger)type {
+  self = [super initWithType:type];
+  if (self) {
+    self.cellClass = [SettingsManagedCell class];
+  }
+  return self;
+}
+
+#pragma mark TableViewItem
+
+- (void)configureCell:(SettingsManagedCell*)cell
+           withStyler:(ChromeTableViewStyler*)styler {
+  [super configureCell:cell withStyler:styler];
+  cell.textLabel.text = self.text;
+  cell.detailTextLabel.text = self.detailText;
+  cell.statusTextLabel.text = self.statusText;
+  cell.selectionStyle = UITableViewCellSelectionStyleNone;
+
+  // Update the icon image, if one is present.
+  UIImage* iconImage = nil;
+  if ([self.iconImageName length]) {
+    iconImage = [UIImage imageNamed:self.iconImageName];
+  }
+  [cell setIconImage:iconImage];
+}
+
+@end

ios/chrome/browser/ui/settings/password/BUILD.gn

@@ -41,6 +41,7 @@ source_set("password") {
     "//ios/chrome/browser/ui/table_view/cells:cells_constants",
     "//ios/chrome/browser/ui/util",
     "//ios/chrome/common/ui/colors",
+    "//ios/chrome/common/ui/elements:popover_label_view_controller",
     "//ios/chrome/common/ui/reauthentication",
     "//ios/chrome/common/ui/util",
     "//ios/third_party/material_components_ios",

ios/chrome/browser/ui/settings/password/passwords_table_view_controller.mm

@@ -38,6 +38,8 @@
 #import "ios/chrome/browser/signin/chrome_identity_service_observer_bridge.h"
 #include "ios/chrome/browser/system_flags.h"
 #import "ios/chrome/browser/ui/settings/cells/settings_cells_constants.h"
+#import "ios/chrome/browser/ui/settings/cells/settings_managed_cell.h"
+#import "ios/chrome/browser/ui/settings/cells/settings_managed_item.h"
 #import "ios/chrome/browser/ui/settings/cells/settings_switch_cell.h"
 #import "ios/chrome/browser/ui/settings/cells/settings_switch_item.h"
 #import "ios/chrome/browser/ui/settings/password/password_details_table_view_controller.h"
@@ -47,7 +49,6 @@
 #import "ios/chrome/browser/ui/settings/utils/pref_backed_boolean.h"
 #import "ios/chrome/browser/ui/settings/utils/settings_utils.h"
 #import "ios/chrome/browser/ui/table_view/cells/table_view_cells_constants.h"
-#import "ios/chrome/browser/ui/table_view/cells/table_view_detail_icon_item.h"
 #import "ios/chrome/browser/ui/table_view/cells/table_view_detail_text_item.h"
 #import "ios/chrome/browser/ui/table_view/cells/table_view_link_header_footer_item.h"
 #import "ios/chrome/browser/ui/table_view/cells/table_view_text_header_footer_item.h"
@@ -58,6 +59,7 @@
 #import "ios/chrome/browser/ui/util/uikit_ui_util.h"
 #import "ios/chrome/common/ui/colors/UIColor+cr_semantic_colors.h"
 #import "ios/chrome/common/ui/colors/semantic_color_names.h"
+#import "ios/chrome/common/ui/elements/popover_label_view_controller.h"
 #import "ios/chrome/common/ui/reauthentication/reauthentication_module.h"
 #import "ios/chrome/common/ui/util/constraints_ui_util.h"
 #include "ios/chrome/grit/ios_strings.h"
@@ -172,7 +174,7 @@ std::vector<std::unique_ptr<autofill::PasswordForm>> CopyOf(
   // The item related to the switch for the password manager setting.
   SettingsSwitchItem* _savePasswordsItem;
   // The item related to the enterprise managed save password setting.
-  TableViewDetailIconItem* _managedSavePasswordItem;
+  SettingsManagedItem* _managedSavePasswordItem;
   // The item related to the button for exporting passwords.
   TableViewTextItem* _exportPasswordsItem;
   // The interface for getting and manipulating a user's saved passwords.
@@ -460,17 +462,14 @@ std::vector<std::unique_ptr<autofill::PasswordForm>> CopyOf(
   return savePasswordsItem;
 }
 
-- (TableViewDetailIconItem*)managedSavePasswordItem {
-  TableViewDetailIconItem* managedSavePasswordItem =
-      [[TableViewDetailIconItem alloc]
-          initWithType:ItemTypeManagedSavePasswords];
-
+- (SettingsManagedItem*)managedSavePasswordItem {
+  SettingsManagedItem* managedSavePasswordItem =
+      [[SettingsManagedItem alloc] initWithType:ItemTypeManagedSavePasswords];
   managedSavePasswordItem.text = l10n_util::GetNSString(IDS_IOS_SAVE_PASSWORDS);
-  NSString* passwordsDetail = [_passwordManagerEnabled value]
-                                  ? l10n_util::GetNSString(IDS_IOS_SETTING_ON)
-                                  : l10n_util::GetNSString(IDS_IOS_SETTING_OFF);
-  managedSavePasswordItem.detailText = passwordsDetail;
-  managedSavePasswordItem.accessoryType = UITableViewCellAccessoryDetailButton;
+  managedSavePasswordItem.statusText =
+      [_passwordManagerEnabled value]
+          ? l10n_util::GetNSString(IDS_IOS_SETTING_ON)
+          : l10n_util::GetNSString(IDS_IOS_SETTING_OFF);
   managedSavePasswordItem.accessibilityIdentifier =
       @"savePasswordsItem_managed";
   return managedSavePasswordItem;
@@ -541,9 +540,23 @@ std::vector<std::unique_ptr<autofill::PasswordForm>> CopyOf(
 - (void)savePasswordsSwitchChanged:(UISwitch*)switchView {
   // Update the setting.
   [_passwordManagerEnabled setValue:switchView.on];
+}
 
-  // Update the item.
-  _savePasswordsItem.on = [_passwordManagerEnabled value];
+// Being called when the user clicks on the information button of the managed
+// setting's UI. Shows a textual bubble with the information of the enterprise.
+- (void)didTapManagedUIInfoButton:(UIButton*)buttonView {
+  // TODO(crbug.com/1085202): show customized text bubble.
+  // Now showing a PopoverLabelView as a placeholder.
+  NSString* text = l10n_util::GetNSString(
+      IDS_IOS_TOGGLE_SETTING_MANAGED_INFO_BUBBLE_MESSAGE);
+  PopoverLabelViewController* bubbleViewController =
+      [[PopoverLabelViewController alloc] initWithMessage:text];
+  [self presentViewController:bubbleViewController animated:YES completion:nil];
+  bubbleViewController.popoverPresentationController.sourceView = buttonView;
+  bubbleViewController.popoverPresentationController.sourceRect =
+      buttonView.bounds;
+  bubbleViewController.popoverPresentationController.permittedArrowDirections =
+      UIPopoverArrowDirectionAny;
 }
 
 #pragma mark - SavePasswordsConsumerDelegate
@@ -1013,11 +1026,6 @@ std::vector<std::unique_ptr<autofill::PasswordForm>> CopyOf(
          SectionIdentifierSavePasswordsSwitch;
 }
 
-- (void)tableView:(UITableView*)tableView
-    accessoryButtonTappedForRowWithIndexPath:(NSIndexPath*)indexPath {
-  // TODO(crbug.com/1085202): show the text bubble.
-}
-
 - (UIView*)tableView:(UITableView*)tableView
     viewForHeaderInSection:(NSInteger)section {
   UIView* view = [super tableView:tableView viewForHeaderInSection:section];
@@ -1065,6 +1073,15 @@ std::vector<std::unique_ptr<autofill::PasswordForm>> CopyOf(
                       forControlEvents:UIControlEventValueChanged];
       break;
     }
+    case ItemTypeManagedSavePasswords: {
+      SettingsManagedCell* managedCell =
+          base::mac::ObjCCastStrict<SettingsManagedCell>(cell);
+      [managedCell.trailingButton
+                 addTarget:self
+                    action:@selector(didTapManagedUIInfoButton:)
+          forControlEvents:UIControlEventTouchUpInside];
+      break;
+    }
   }
   return cell;
 }