Commit 83de5307 authored by Jun Mukai's avatar Jun Mukai Committed by Commit Bot

Enable OmniboxViewViews uitest

The reason of OmniboxViewViews test failures are basically on
touches, and that's because EventInjector is not used.
This CL sets nullptr for EventGenerator to use EventInjector.

BUG=883523
TEST=interactive_ui_tests

Change-Id: I394b9b11d6efc6826a45da407b79cee328224dcf
Reviewed-on: https://chromium-review.googlesource.com/c/1283929Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600606}
parent e4bd01cd
......@@ -33,6 +33,7 @@
#include "ui/base/ime/text_edit_commands.h"
#include "ui/base/ime/text_input_client.h"
#include "ui/base/test/ui_controls.h"
#include "ui/base/ui_base_features.h"
#include "ui/base/ui_base_switches.h"
#include "ui/events/event_processor.h"
#include "ui/events/event_utils.h"
......@@ -97,7 +98,12 @@ class OmniboxViewViewsTest : public InProcessBrowserTest {
// Touch down and release at the specified locations.
void Tap(const gfx::Point& press_location,
const gfx::Point& release_location) {
ui::test::EventGenerator generator(browser()->window()->GetNativeWindow());
gfx::NativeWindow window = browser()->window()->GetNativeWindow();
#if defined(OS_CHROMEOS)
if (features::IsUsingWindowService())
window = nullptr;
#endif
ui::test::EventGenerator generator(window);
if (press_location == release_location) {
generator.GestureTapAt(press_location);
} else {
......
......@@ -21,8 +21,6 @@
# misc.
-DevToolsManagerDelegateTest.ShowMinimizedWindow
-OmniboxViewViewsTest.DeactivateTouchEditingOnExecuteCommand
-OmniboxViewViewsTest.SelectAllOnTap
-WindowActivityWatcherTest.Basic
-WindowActivityWatcherTest.MultipleWindows
-WindowActivityWatcherTest.WindowActivation
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment