Remove overrides of HitTestRect() which just return false

Some overrides of View::HitTestRect() just return 
false in order to force event-targeting to fail for
that view type and its descendants. Because this 
logic is unrelated to hit-testing against a rectangular
region, remove these overrides and instead override 
View::CanProcessEventsWithinSubtree() to just return 
false.

The relevant classes are:

ProfileImageView
ShelfButton::BarView
ShelfButton::IconView
PasswordRow
BoundedLabel
Label (and Link as a result)

BUG=374303
TEST=none

Review URL: https://codereview.chromium.org/287193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274366 0039d316-1c4b-4281-b951-d872f2087c98

ash/shelf/shelf_button.cc

@@ -123,9 +123,9 @@ class ShelfButton::BarView : public views::ImageView,
       ShelfButtonAnimation::GetInstance()->RemoveObserver(this);
   }
 
-  // View
-  virtual bool HitTestRect(const gfx::Rect& rect) const OVERRIDE {
-    // Allow Mouse...() messages to go to the parent view.
+  // views::View:
+  virtual bool CanProcessEventsWithinSubtree() const OVERRIDE {
+    // Send events to the parent view for handling.
     return false;
   }
 
@@ -201,8 +201,8 @@ ShelfButton::IconView::IconView() : icon_size_(kIconSize) {
 ShelfButton::IconView::~IconView() {
 }
 
-bool ShelfButton::IconView::HitTestRect(const gfx::Rect& rect) const {
-  // Return false so that ShelfButton gets all the mouse events.
+bool ShelfButton::IconView::CanProcessEventsWithinSubtree() const {
+  // Return false so that events are sent to ShelfView for handling.
   return false;
 }
 

ash/shelf/shelf_button.h

@@ -82,8 +82,8 @@ class ASH_EXPORT ShelfButton : public views::CustomButton {
     void set_icon_size(int icon_size) { icon_size_ = icon_size; }
     int icon_size() const { return icon_size_; }
 
-    // views::View overrides.
-    virtual bool HitTestRect(const gfx::Rect& rect) const OVERRIDE;
+    // views::View:
+    virtual bool CanProcessEventsWithinSubtree() const OVERRIDE;
 
    private:
     // Set to non-zero to force icons to be resized to fit within a square,

chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc

@@ -50,8 +50,9 @@ class PasswordRow : public views::View {
   }
   virtual ~PasswordRow() {}
 
-  virtual bool HitTestRect(const gfx::Rect& rect) const OVERRIDE {
-    // Have parent do event handling.
+  // views::View:
+  virtual bool CanProcessEventsWithinSubtree() const OVERRIDE {
+    // Send events to the parent view for handling.
     return false;
   }
 

chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc

@@ -201,10 +201,12 @@ void EditProfileLink::OnBlur() {
 // them instead.
 class ProfileImageView : public views::ImageView {
  public:
-  virtual bool HitTestRect(const gfx::Rect& rect) const OVERRIDE;
+  // views::View:
+  virtual bool CanProcessEventsWithinSubtree() const OVERRIDE;
 };
 
-bool ProfileImageView::HitTestRect(const gfx::Rect& rect) const {
+bool ProfileImageView::CanProcessEventsWithinSubtree() const {
+  // Send events to the parent view for handling.
   return false;
 }
 

ui/message_center/views/bounded_label.cc

@@ -333,8 +333,8 @@ void BoundedLabel::Paint(gfx::Canvas* canvas, const views::CullSet& cull_set) {
     label_->Paint(canvas, cull_set);
 }
 
-bool BoundedLabel::HitTestRect(const gfx::Rect& rect) const {
-  return label_->HitTestRect(rect);
+bool BoundedLabel::CanProcessEventsWithinSubtree() const {
+  return label_->CanProcessEventsWithinSubtree();
 }
 
 void BoundedLabel::GetAccessibleState(ui::AXViewState* state) {

ui/message_center/views/bounded_label.h

@@ -49,13 +49,13 @@ class MESSAGE_CENTER_EXPORT BoundedLabel : public views::View {
   int GetLinesForWidthAndLimit(int width, int limit);
   gfx::Size GetSizeForWidthAndLines(int width, int lines);
 
-  // Overridden from views::View.
+  // views::View:
   virtual int GetBaseline() const OVERRIDE;
   virtual gfx::Size GetPreferredSize() const OVERRIDE;
   virtual int GetHeightForWidth(int width) const OVERRIDE;
   virtual void Paint(gfx::Canvas* canvas,
                      const views::CullSet& cull_set) OVERRIDE;
-  virtual bool HitTestRect(const gfx::Rect& rect) const OVERRIDE;
+  virtual bool CanProcessEventsWithinSubtree() const OVERRIDE;
   virtual void GetAccessibleState(ui::AXViewState* state) OVERRIDE;
 
  protected:

ui/views/controls/label.cc

@@ -289,7 +289,8 @@ View* Label::GetTooltipHandlerForPoint(const gfx::Point& point) {
   return this;
 }
 
-bool Label::HitTestRect(const gfx::Rect& rect) const {
+bool Label::CanProcessEventsWithinSubtree() const {
+  // Send events to the parent view for handling.
   return false;
 }
 

ui/views/controls/label.h

@@ -172,7 +172,7 @@ class VIEWS_EXPORT Label : public View {
   void set_collapse_when_hidden(bool value) { collapse_when_hidden_ = value; }
   bool collapse_when_hidden() const { return collapse_when_hidden_; }
 
-  // Overridden from View:
+  // View:
   virtual gfx::Insets GetInsets() const OVERRIDE;
   virtual int GetBaseline() const OVERRIDE;
   // Overridden to compute the size required to display this label.
@@ -185,7 +185,7 @@ class VIEWS_EXPORT Label : public View {
   virtual int GetHeightForWidth(int w) const OVERRIDE;
   virtual const char* GetClassName() const OVERRIDE;
   virtual View* GetTooltipHandlerForPoint(const gfx::Point& point) OVERRIDE;
-  virtual bool HitTestRect(const gfx::Rect& rect) const OVERRIDE;
+  virtual bool CanProcessEventsWithinSubtree() const OVERRIDE;
   virtual void GetAccessibleState(ui::AXViewState* state) OVERRIDE;
   // Gets the tooltip text for labels that are wider than their bounds, except
   // when the label is multiline, in which case it just returns false (no

ui/views/controls/link.cc

@@ -51,10 +51,10 @@ gfx::NativeCursor Link::GetCursor(const ui::MouseEvent& event) {
   return GetNativeHandCursor();
 }
 
-bool Link::HitTestRect(const gfx::Rect& rect) const {
-  // We need to allow clicks on the link. So we override the implementation in
-  // Label and use the default implementation of View.
-  return View::HitTestRect(rect);
+bool Link::CanProcessEventsWithinSubtree() const {
+  // Links need to be able to accept events (e.g., clicking) even though
+  // in general Labels do not.
+  return View::CanProcessEventsWithinSubtree();
 }
 
 bool Link::OnMousePressed(const ui::MouseEvent& event) {

ui/views/controls/link.h

@@ -36,7 +36,7 @@ class VIEWS_EXPORT Link : public Label {
   // Label:
   virtual const char* GetClassName() const OVERRIDE;
   virtual gfx::NativeCursor GetCursor(const ui::MouseEvent& event) OVERRIDE;
-  virtual bool HitTestRect(const gfx::Rect& rect) const OVERRIDE;
+  virtual bool CanProcessEventsWithinSubtree() const OVERRIDE;
   virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE;
   virtual bool OnMouseDragged(const ui::MouseEvent& event) OVERRIDE;
   virtual void OnMouseReleased(const ui::MouseEvent& event) OVERRIDE;