Commit 84367325 authored by David Bertoni's avatar David Bertoni Committed by Commit Bot

[Extensions] Re-enable some Declarative Web Request API tests.

These tests were disabled on Mac ASAN for flakiness, due to
bug 496955. That bug has been fixed and these tests are no
longer flaky.

Bug: 851854, 496955
Change-Id: Idd52325c2103cb5518dc058242abeb27c1107451
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238339Reviewed-by: default avatarArchana Simha <archanasimha@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779072}
parent 7f722cb5
...@@ -199,18 +199,9 @@ IN_PROC_BROWSER_TEST_F(DeclarativeApiTest, PersistRules) { ...@@ -199,18 +199,9 @@ IN_PROC_BROWSER_TEST_F(DeclarativeApiTest, PersistRules) {
EXPECT_EQ(kTestTitle, GetTitle()); EXPECT_EQ(kTestTitle, GetTitle());
} }
// Disabled for flakiness: http://crbug.com/851854
#if defined(OS_MACOSX) && defined(ADDRESS_SANITIZER)
#define MAYBE_ExtensionLifetimeRulesHandling \
DISABLED_ExtensionLifetimeRulesHandling
#else
#define MAYBE_ExtensionLifetimeRulesHandling ExtensionLifetimeRulesHandling
#endif
// Test that the rules are correctly persisted and (de)activated during // Test that the rules are correctly persisted and (de)activated during
// changing the "installed" and "enabled" status of an extension. // changing the "installed" and "enabled" status of an extension.
IN_PROC_BROWSER_TEST_F(DeclarativeApiTest, IN_PROC_BROWSER_TEST_F(DeclarativeApiTest, ExtensionLifetimeRulesHandling) {
MAYBE_ExtensionLifetimeRulesHandling) {
TestExtensionDir ext_dir; TestExtensionDir ext_dir;
// 1. Install the extension. Rules should become active. // 1. Install the extension. Rules should become active.
...@@ -276,17 +267,10 @@ IN_PROC_BROWSER_TEST_F(DeclarativeApiTest, ...@@ -276,17 +267,10 @@ IN_PROC_BROWSER_TEST_F(DeclarativeApiTest,
EXPECT_EQ(0u, NumberOfRegisteredRules(extension_id)); EXPECT_EQ(0u, NumberOfRegisteredRules(extension_id));
} }
// Disabled for flakiness: http://crbug.com/851854
#if defined(OS_MACOSX) && defined(ADDRESS_SANITIZER)
#define MAYBE_NoTracesAfterUninstalling DISABLED_NoTracesAfterUninstalling
#else
#define MAYBE_NoTracesAfterUninstalling NoTracesAfterUninstalling
#endif
// When an extension is uninstalled, the state store deletes all preferences // When an extension is uninstalled, the state store deletes all preferences
// stored for that extension. We need to make sure we don't store anything after // stored for that extension. We need to make sure we don't store anything after
// that deletion occurs. // that deletion occurs.
IN_PROC_BROWSER_TEST_F(DeclarativeApiTest, MAYBE_NoTracesAfterUninstalling) { IN_PROC_BROWSER_TEST_F(DeclarativeApiTest, NoTracesAfterUninstalling) {
TestExtensionDir ext_dir; TestExtensionDir ext_dir;
// 1. Install the extension. Verify that rules become active and some prefs // 1. Install the extension. Verify that rules become active and some prefs
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment