Commit 84a36122 authored by Isabella Scalzi's avatar Isabella Scalzi Committed by Commit Bot

Fix transferFromDownloadsToMyFilesMove transfer.js test

The transferBetweenVolumes function adds the file to be moved into
the list of expected files after the move, only runs if the flag
"isMove" is false. Because of this, the file that was moved was not
added to the list of expected files, and the test can fail.

Removes this condition, and do not add the file to be moved to the
list when the source is the same as the destination, or if the test
is expected to fail.

All tests that use transferBetweenVolumes now pass in step-by-step
mode, to complete issue 1035220.

Bug: 1035220
Change-Id: If9031eab26340af6af2440f2fd9e30d48b5a248d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976138Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Commit-Queue: Isabella Scalzi <isabellascalzi@google.com>
Cr-Commit-Position: refs/heads/master@{#726672}
parent 711f8a01
......@@ -206,7 +206,7 @@ async function transferBetweenVolumes(transferInfo) {
// If we expected the transfer to succeed, add the pasted file to the list
// of expected rows.
if (!transferInfo.expectFailure && !transferInfo.isMove &&
if (!transferInfo.expectFailure &&
transferInfo.source !== transferInfo.destination) {
const pasteFile = transferInfo.fileToTransfer.getExpectedRow();
// Check if we need to add (1) to the filename, in the case of a
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment