Commit 84aeb31e authored by Joel Einbinder's avatar Joel Einbinder Committed by Commit Bot

DevTools: Show focus outline for checkboxes in devices screen

Also stops propagation if the checkbox is clicked to prevent the default
click handler from unchecking the box.

Bug: 762441
Change-Id: I6a304221d1c9ae52d592645d430c61fa621741c2
Reviewed-on: https://chromium-review.googlesource.com/744340
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: default avatarPavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512656}
parent 4dc8ed2d
...@@ -105,6 +105,7 @@ Emulation.DevicesSettingsTab = class extends UI.VBox { ...@@ -105,6 +105,7 @@ Emulation.DevicesSettingsTab = class extends UI.VBox {
var checkbox = element.createChild('input', 'devices-list-checkbox'); var checkbox = element.createChild('input', 'devices-list-checkbox');
checkbox.type = 'checkbox'; checkbox.type = 'checkbox';
checkbox.checked = device.show(); checkbox.checked = device.show();
checkbox.addEventListener('click', event => event.consume(), false);
element.createChild('div', 'devices-list-title').textContent = device.title; element.createChild('div', 'devices-list-title').textContent = device.title;
element.addEventListener('click', onItemClicked.bind(this), false); element.addEventListener('click', onItemClicked.bind(this), false);
return element; return element;
......
...@@ -51,6 +51,10 @@ ...@@ -51,6 +51,10 @@
pointer-events: none; pointer-events: none;
} }
.devices-list-checkbox:focus {
outline: auto 5px -webkit-focus-ring-color;
}
.devices-list-title { .devices-list-title {
overflow: hidden; overflow: hidden;
white-space: nowrap; white-space: nowrap;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment