Commit 84c84e6f authored by David Bokan's avatar David Bokan Committed by Commit Bot

[RootScroller] Don't assume frame owner is an iframe

We can't assume a FrameOwner's content view is a local frame view here
since we might be removing a root scroller because it's no longer
valid; it could be that it once was a LocalFrameView but has since
been replaced by another type of view.

No test since this came from the fuzzer and only causes an issue when
run under UBSan.

Bug: 961597
Change-Id: Ia24c000ac53a795d0325c2aa8825e901344f3ec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618203Reviewed-by: default avatarChris Harrelson <chrishtr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#662182}
parent 3ab2dda8
......@@ -338,7 +338,7 @@ void RootScrollerController::ApplyRootScrollerProperties(Node& node) {
if (IsA<LocalFrame>(frame_owner->ContentFrame())) {
LocalFrameView* frame_view =
To<LocalFrameView>(frame_owner->OwnedEmbeddedContentView());
DynamicTo<LocalFrameView>(frame_owner->OwnedEmbeddedContentView());
bool is_root_scroller = &EffectiveRootScroller() == &node;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment