Remove IsBoundToCurrentThread from MessageLoop public API

A small step towards deleting MessageLoop.

TBR=fdoray@chromium.org

Bug: 891670
Change-Id: I6ca110d71acc5c6385e62f12885c799cf5f01f40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635253Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664311}

base/message_loop/message_loop.h

@@ -168,9 +168,6 @@ class BASE_EXPORT MessageLoop {
   void AddTaskObserver(TaskObserver* task_observer);
   void RemoveTaskObserver(TaskObserver* task_observer);
 
-  // Returns true if this is the active MessageLoop for the current thread.
-  bool IsBoundToCurrentThread() const;
-
   // Returns true if the message loop is idle (ignoring delayed tasks). This is
   // the same condition which triggers DoWork() to return false: i.e.
   // out of tasks which can be processed at the current run-level -- there might
@@ -181,6 +178,9 @@ class BASE_EXPORT MessageLoop {
 
   //----------------------------------------------------------------------------
  protected:
+  // Returns true if this is the active MessageLoop for the current thread.
+  bool IsBoundToCurrentThread() const;
+
   using MessagePumpFactoryCallback =
       OnceCallback<std::unique_ptr<MessagePump>()>;
 

base/message_loop/message_loop_unittest.cc

@@ -2234,7 +2234,7 @@ TEST_F(MessageLoopTest, DeleteUnboundLoop) {
   std::unique_ptr<MessageLoop> unbound_loop(
       MessageLoop::CreateUnbound(MessageLoop::TYPE_DEFAULT));
   unbound_loop.reset();
-  EXPECT_TRUE(loop.IsBoundToCurrentThread());
+  EXPECT_TRUE(loop.task_runner()->RunsTasksInCurrentSequence());
   EXPECT_EQ(loop.task_runner(), ThreadTaskRunnerHandle::Get());
 }
 

components/cronet/android/cronet_library_loader.cc

@@ -80,7 +80,7 @@ void NativeInit() {
 
 bool OnInitThread() {
   DCHECK(g_init_message_loop);
-  return g_init_message_loop->IsBoundToCurrentThread();
+  return g_init_message_loop->task_runner()->RunsTasksInCurrentSequence();
 }
 
 // In integrated mode, Cronet native library is built and loaded together with

components/cronet/android/test/cronet_test_util.cc

@@ -98,7 +98,7 @@ void JNI_CronetTestUtil_PrepareNetworkThread(
 
 static void CleanupNetworkThreadOnNetworkThread() {
   DCHECK(g_message_loop);
-  DCHECK(g_message_loop->IsBoundToCurrentThread());
+  DCHECK(g_message_loop->task_runner()->RunsTasksInCurrentSequence());
   delete g_message_loop;
   g_message_loop = nullptr;
 }

components/discardable_memory/service/discardable_shared_memory_manager.cc

@@ -406,7 +406,8 @@ size_t DiscardableSharedMemoryManager::GetBytesAllocated() {
 void DiscardableSharedMemoryManager::WillDestroyCurrentMessageLoop() {
   // The mojo thead is going to be destroyed. We should invalidate all related
   // weak ptrs and remove the destrunction observer.
-  DCHECK(mojo_thread_message_loop_->IsBoundToCurrentThread());
+  DCHECK(
+      mojo_thread_message_loop_->task_runner()->RunsTasksInCurrentSequence());
   DLOG_IF(WARNING, mojo_thread_weak_ptr_factory_.HasWeakPtrs())
       << "Some MojoDiscardableSharedMemoryManagerImpls are still alive. They "
          "will be leaked.";
@@ -616,7 +617,8 @@ void DiscardableSharedMemoryManager::ScheduleEnforceMemoryPolicy() {
 
 void DiscardableSharedMemoryManager::InvalidateMojoThreadWeakPtrs(
     base::WaitableEvent* event) {
-  DCHECK(mojo_thread_message_loop_->IsBoundToCurrentThread());
+  DCHECK(
+      mojo_thread_message_loop_->task_runner()->RunsTasksInCurrentSequence());
   mojo_thread_weak_ptr_factory_.InvalidateWeakPtrs();
   mojo_thread_message_loop_->RemoveDestructionObserver(this);
   mojo_thread_message_loop_ = base::MessageLoopCurrent::GetNull();

services/device/geolocation/network_location_provider_unittest.cc

@@ -292,7 +292,7 @@ class GeolocationNetworkProviderTest : public testing::Test {
 
 // Tests that fixture members were SetUp correctly.
 TEST_F(GeolocationNetworkProviderTest, CreateDestroy) {
-  EXPECT_TRUE(main_message_loop_.IsBoundToCurrentThread());
+  EXPECT_TRUE(main_message_loop_.task_runner()->RunsTasksInCurrentSequence());
   std::unique_ptr<LocationProvider> provider(CreateProvider(true));
   EXPECT_TRUE(provider);
   provider.reset();