Suppressing Password Manager UI while Autofill assistant is running

This CL introducing 2 modes of collaboration between Password Manager
and Autofill Assistant (who handles form submissions, whether to show prompts or not).

Change-Id: I0394efa077060af2b6783add8a935658de8ee935

Bug: 1063347
Change-Id: I0394efa077060af2b6783add8a935658de8ee935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110231
Commit-Queue: Milica Selakovic <selakovic@google.com>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#753187}

chrome/browser/android/autofill_assistant/client_android.cc

@@ -199,6 +199,11 @@ void ClientAndroid::TransferUITo(
   // From this point on, the UIController, in ui_ptr, is either transferred or
   // deleted.
 
+  GetPasswordManagerClient()
+      ->GetPasswordManager()
+      ->set_autofill_assistance_mode(
+          password_manager::AutofillAssistantMode::kNotRunning);
+
   if (!jother_web_contents)
     return;
 
@@ -433,6 +438,11 @@ void ClientAndroid::AttachUI(
 
     ui_controller_android_->Attach(web_contents_, this, controller_.get());
   }
+
+  GetPasswordManagerClient()
+      ->GetPasswordManager()
+      ->set_autofill_assistance_mode(
+          password_manager::AutofillAssistantMode::kManuallyCuratedScript);
 }
 
 void ClientAndroid::DestroyUI() {
@@ -532,6 +542,11 @@ void ClientAndroid::Shutdown(Metrics::DropOutReason reason) {
   if (!controller_)
     return;
 
+  GetPasswordManagerClient()
+      ->GetPasswordManager()
+      ->set_autofill_assistance_mode(
+          password_manager::AutofillAssistantMode::kNotRunning);
+
   if (ui_controller_android_ && ui_controller_android_->IsAttached())
     DestroyUI();
 

components/password_manager/core/browser/password_manager.cc

@@ -828,6 +828,9 @@ void PasswordManager::OnPasswordFormsRendered(
 }
 
 void PasswordManager::OnLoginSuccessful() {
+  if (autofill_assistant_mode_ == AutofillAssistantMode::kManuallyCuratedScript)
+    return;
+
   std::unique_ptr<BrowserSavePasswordProgressLogger> logger;
   if (password_manager_util::IsLoggingActive(client_)) {
     logger.reset(

components/password_manager/core/browser/password_manager.h

@@ -35,7 +35,7 @@ class PrefRegistrySyncable;
 namespace autofill {
 struct FormData;
 class FormStructure;
-}
+}  // namespace autofill
 
 namespace password_manager {
 
@@ -47,6 +47,18 @@ class PasswordFormManager;
 class PasswordManagerMetricsRecorder;
 struct PossibleUsernameData;
 
+// Define the modes of collaboration between Password Manager and Autofill
+// Assistant (who handles form submissions, whether to show prompts or not).
+enum class AutofillAssistantMode {
+  // Autofill Assistant is not running. Password Manager operates in the regular
+  // mode - it handles submissions and shows prompts.
+  kNotRunning = 0,
+  // Autofill Assistant runs a manually curated script. The password manager
+  // is basically off - it does not handle submissions and therefore does not
+  // show prompts. The script does all the work instead.
+  kManuallyCuratedScript
+};
+
 // Per-tab password manager. Handles creation and management of UI elements,
 // receiving password form data from the renderer and managing the password
 // database through the PasswordStore.
@@ -179,6 +191,11 @@ class PasswordManager : public FormSubmissionObserver {
   // Notifies that Credential Management API function store() is called.
   void NotifyStorePasswordCalled();
 
+  void set_autofill_assistance_mode(
+      AutofillAssistantMode autofill_assistant_mode) {
+    autofill_assistant_mode_ = autofill_assistant_mode;
+  }
+
 #if defined(OS_IOS)
   // TODO(https://crbug.com/866444): Use these methods instead olds ones when
   // the old parser is gone.
@@ -354,6 +371,11 @@ class PasswordManager : public FormSubmissionObserver {
 
   base::Optional<PossibleUsernameData> possible_username_;
 
+  // By default Autofill Assistant is not running. Password Manager handles
+  // submissions and shows prompts.
+  AutofillAssistantMode autofill_assistant_mode_ =
+      AutofillAssistantMode::kNotRunning;
+
   DISALLOW_COPY_AND_ASSIGN(PasswordManager);
 };