Move error_util.js to base/

Move library to base to be able to share it with other apps.

Fix the comment about metrics.js to be on top of metrics.js include.

Move error_util.js in background page to be first script loaded to be
able to catch errors from all scripts.

Bug: 893430
Change-Id: I9744089d258fc36979e88b1418595f733e00b81f
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/c/1282642Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599864}

ui/file_manager/base/js/BUILD.gn

@@ -15,6 +15,7 @@ group("closure_compile") {
 
 js_type_check("closure_compile_module") {
   deps = [
+    ":error_util",
     ":filtered_volume_manager",
   ]
 }
@@ -26,6 +27,9 @@ js_type_check("test_support_type_check") {
   ]
 }
 
+js_library("error_util") {
+}
+
 js_library("filtered_volume_manager") {
   deps = [
     "//ui/file_manager/externs:file_manager_private",

ui/file_manager/file_manager/background/js/BUILD.gn

@@ -267,7 +267,7 @@ js_library("test_util_base") {
   deps = [
     ":app_windows",
     "../../../externs:webview_tag",
-    "../../common/js:error_util",
+    "//ui/file_manager/base/js:error_util",
   ]
 }
 

ui/file_manager/file_manager/background/js/background_scripts.js

@@ -2,11 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// error_util.js must be loaded before all other scripts of the Files app.
+// <include src="../../../base/js/error_util.js">
 // <include src="metrics_start.js">
 // <include src="../../common/js/lru_cache.js">
 // <include src="../../common/js/progress_center_common.js">
 // <include src="../../common/js/importer_common.js">
-// <include src="../../common/js/error_util.js">
 // <include src="metadata_proxy.js">
 // <include src="device_handler.js">
 // <include src="drive_sync_handler.js">

ui/file_manager/file_manager/common/js/BUILD.gn

@@ -19,7 +19,6 @@ group("closure_compile") {
 js_type_check("closure_compile_module") {
   deps = [
     ":async_util",
-    ":error_util",
     ":file_type",
     ":files_app_entry_types",
     ":importer_common",
@@ -51,9 +50,6 @@ js_library("async_util_unittest") {
   ]
 }
 
-js_library("error_util") {
-}
-
 js_library("files_app_entry_types") {
   deps = [
     "../../../externs:file_manager_private",

ui/file_manager/file_manager/foreground/js/main_scripts.js

@@ -20,11 +20,11 @@
 // files don't know that "resources.pak" now has a dependency to
 // "whatever.js". You should rerun gyp to let the build files know.
 //
-// metrics_base.js and metrics.js initiates load performance tracking
-// so we want to parse it as early as possible.
 // error_util.js must be loaded before all other scripts of the Files app.
-// <include src="../../common/js/error_util.js">
+// <include src="../../../base/js/error_util.js">
 //
+// metrics_base.js and metrics.js initiates load performance tracking
+// so we want to parse it as early as possible.
 // <include src="../../common/js/metrics_base.js">
 // <include src="../../common/js/metrics.js">
 // <include src="metrics_start.js">