Commit 8536f5b4 authored by Reilly Grant's avatar Reilly Grant

Disable flaky HostedAppTests

ShouldShowLocationBarForHTTPApp and ShouldShowLocationBarForHTTPSApp
are both flaky, with the former failing while the later crashes.

TBR=mguica@chromium.org

Bug: 815240, 815246
Change-Id: I8856047c78d503affea58a25ba6f708454642116
Reviewed-on: https://chromium-review.googlesource.com/934926Reviewed-by: default avatarReilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538848}
parent 97ba93d3
...@@ -266,7 +266,10 @@ IN_PROC_BROWSER_TEST_P(HostedAppTest, ShouldShowLocationBar) { ...@@ -266,7 +266,10 @@ IN_PROC_BROWSER_TEST_P(HostedAppTest, ShouldShowLocationBar) {
// Check that the location bar is shown correctly for HTTP apps when they // Check that the location bar is shown correctly for HTTP apps when they
// navigate to a HTTPS page on the same origin. // navigate to a HTTPS page on the same origin.
IN_PROC_BROWSER_TEST_P(HostedAppTest, ShouldShowLocationBarForHTTPApp) { //
// Disabled for being flaky: https://crbug.com/815240
IN_PROC_BROWSER_TEST_P(HostedAppTest,
DISABLED_ShouldShowLocationBarForHTTPApp) {
SetupApp("app"); SetupApp("app");
// Navigate to the app's launch page; the location bar should be visible, even // Navigate to the app's launch page; the location bar should be visible, even
...@@ -280,9 +283,16 @@ IN_PROC_BROWSER_TEST_P(HostedAppTest, ShouldShowLocationBarForHTTPApp) { ...@@ -280,9 +283,16 @@ IN_PROC_BROWSER_TEST_P(HostedAppTest, ShouldShowLocationBarForHTTPApp) {
app_browser_, "https://www.example.com/blah", false); app_browser_, "https://www.example.com/blah", false);
} }
// Disabled on Windows for being flaky: https://crbug.com/815246
#if defined(OS_WIN)
#define MAYBE_ShouldShowLocationBarForHTTPSApp \
DISABLED_ShouldShowLocationBarForHTTPSApp
#else
#define MAYBE_ShouldShowLocationBarForHTTPSApp ShouldShowLocationBarForHTTPSApp
#endif
// Check that the location bar is shown correctly for HTTPS apps when they // Check that the location bar is shown correctly for HTTPS apps when they
// navigate to a HTTP page on the same origin. // navigate to a HTTP page on the same origin.
IN_PROC_BROWSER_TEST_P(HostedAppTest, ShouldShowLocationBarForHTTPSApp) { IN_PROC_BROWSER_TEST_P(HostedAppTest, MAYBE_ShouldShowLocationBarForHTTPSApp) {
SetupApp("https_app"); SetupApp("https_app");
// Navigate to the app's launch page; the location bar should be hidden. // Navigate to the app's launch page; the location bar should be hidden.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment