Commit 8545f68f authored by Joshua Bell's avatar Joshua Bell Committed by Commit Bot

Cookie Store API: Remove unneeded delete() options

The 'secure' and 'sameSite' options were included for delete() calls
for symmetry with set(). Although they are used internally as inputs
into the cookie deletion process (which is a set with an expiry time
in the past) they do not have an observable effect as they are not
part of the "key" for cookies in the jar.

Remove 'em from the script-facing API, and just pass defaults through.

If passed, the options will be ignored, so this will have no affect on
code using the API unless the code is trying to specifically probe
option parsing.

GitHub issue: https://github.com/WICG/cookie-store/issues/77
GitHub PR: https://github.com/WICG/cookie-store/pull/81

Bug: 729800
Change-Id: I847293f5274abcb6335140f7f1bf4e2f6f2f8bcf
Reviewed-on: https://chromium-review.googlesource.com/1151723Reviewed-by: default avatarChase Phillips <cmp@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578400}
parent aa53dfdd
...@@ -309,8 +309,8 @@ ScriptPromise CookieStore::Delete(ScriptState* script_state, ...@@ -309,8 +309,8 @@ ScriptPromise CookieStore::Delete(ScriptState* script_state,
set_options.setExpires(0); set_options.setExpires(0);
set_options.setDomain(options.domain()); set_options.setDomain(options.domain());
set_options.setPath(options.path()); set_options.setPath(options.path());
set_options.setSecure(options.secure()); set_options.setSecure(true);
set_options.setSameSite(options.sameSite()); set_options.setSameSite("strict");
return DoWrite(script_state, set_options, exception_state); return DoWrite(script_state, set_options, exception_state);
} }
......
...@@ -8,6 +8,4 @@ dictionary CookieStoreDeleteOptions { ...@@ -8,6 +8,4 @@ dictionary CookieStoreDeleteOptions {
required USVString name; required USVString name;
USVString? domain = null; USVString? domain = null;
USVString path = "/"; USVString path = "/";
boolean secure = true;
CookieSameSite sameSite = "strict";
}; };
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment