Add mixin for setting up guest user flags

BUG=None

Change-Id: I4caad48100f807da147ebaab7c4fc122d05d994d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614476Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661145}

chrome/browser/chromeos/login/login_browsertest.cc

@@ -11,6 +11,7 @@
 #include "base/command_line.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/chromeos/login/login_wizard.h"
+#include "chrome/browser/chromeos/login/test/guest_session_mixin.h"
 #include "chrome/browser/chromeos/login/test/login_manager_mixin.h"
 #include "chrome/browser/chromeos/login/test/offline_gaia_test_mixin.h"
 #include "chrome/browser/chromeos/login/ui/login_display_host_webui.h"
@@ -45,15 +46,9 @@ class LoginUserTest : public InProcessBrowserTest {
   }
 };
 
-class LoginGuestTest : public InProcessBrowserTest {
+class LoginGuestTest : public MixinBasedInProcessBrowserTest {
  protected:
-  void SetUpCommandLine(base::CommandLine* command_line) override {
-    command_line->AppendSwitch(switches::kGuestSession);
-    command_line->AppendSwitch(::switches::kIncognito);
-    command_line->AppendSwitchASCII(switches::kLoginProfile, "hash");
-    command_line->AppendSwitchASCII(
-        switches::kLoginUser, user_manager::GuestAccountId().GetUserEmail());
-  }
+  GuestSessionMixin guest_session_{&mixin_host_};
 };
 
 class LoginCursorTest : public InProcessBrowserTest {

chrome/browser/chromeos/login/test/guest_session_mixin.cc

+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/login/test/guest_session_mixin.h"
+
+#include "base/command_line.h"
+#include "chrome/common/chrome_switches.h"
+#include "chromeos/constants/chromeos_switches.h"
+#include "components/account_id/account_id.h"
+#include "components/user_manager/user_names.h"
+
+namespace chromeos {
+
+GuestSessionMixin::GuestSessionMixin(InProcessBrowserTestMixinHost* mixin_host)
+    : InProcessBrowserTestMixin(mixin_host) {}
+
+GuestSessionMixin::~GuestSessionMixin() = default;
+
+void GuestSessionMixin::SetUpCommandLine(base::CommandLine* command_line) {
+  command_line->AppendSwitch(switches::kGuestSession);
+  command_line->AppendSwitch(::switches::kIncognito);
+  command_line->AppendSwitchASCII(switches::kLoginProfile, "hash");
+  command_line->AppendSwitchASCII(
+      switches::kLoginUser, user_manager::GuestAccountId().GetUserEmail());
+}
+
+}  // namespace chromeos

chrome/browser/chromeos/login/test/guest_session_mixin.h

+// Copyright 2019 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_LOGIN_TEST_GUEST_SESSION_MIXIN_H_
+#define CHROME_BROWSER_CHROMEOS_LOGIN_TEST_GUEST_SESSION_MIXIN_H_
+
+#include "base/macros.h"
+#include "chrome/browser/chromeos/login/mixin_based_in_process_browser_test.h"
+
+namespace base {
+class CommandLine;
+}
+
+namespace chromeos {
+
+// A mixin that sets up test command line for guest user session.
+// Use this with tests for in-session behavior for guest user.
+class GuestSessionMixin : public InProcessBrowserTestMixin {
+ public:
+  explicit GuestSessionMixin(InProcessBrowserTestMixinHost* mixin_host);
+  ~GuestSessionMixin() override;
+
+  // InProcessBrowserTestMixin:
+  void SetUpCommandLine(base::CommandLine* command_line) override;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(GuestSessionMixin);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROME_BROWSER_CHROMEOS_LOGIN_TEST_GUEST_SESSION_MIXIN_H_

chrome/test/BUILD.gn

@@ -1936,6 +1936,8 @@ test("browser_tests") {
         "../browser/chromeos/login/test/enrollment_ui_mixin.h",
         "../browser/chromeos/login/test/fake_gaia_mixin.cc",
         "../browser/chromeos/login/test/fake_gaia_mixin.h",
+        "../browser/chromeos/login/test/guest_session_mixin.cc",
+        "../browser/chromeos/login/test/guest_session_mixin.h",
         "../browser/chromeos/login/test/hid_controller_mixin.cc",
         "../browser/chromeos/login/test/hid_controller_mixin.h",
         "../browser/chromeos/login/test/https_forwarder.cc",