Commit 85574eb3 authored by davidben's avatar davidben Committed by Commit bot

Add a histogram for session resumption version mismatches.

BUG=441456

Review URL: https://codereview.chromium.org/797693003

Cr-Commit-Position: refs/heads/master@{#308040}
parent d426a1cd
...@@ -1131,9 +1131,18 @@ int SSLClientSocketOpenSSL::DoVerifyCertComplete(int result) { ...@@ -1131,9 +1131,18 @@ int SSLClientSocketOpenSSL::DoVerifyCertComplete(int result) {
} }
} }
if (result == OK) if (result == OK) {
RecordConnectionTypeMetrics(GetNetSSLVersion(ssl_)); RecordConnectionTypeMetrics(GetNetSSLVersion(ssl_));
if (SSL_session_reused(ssl_)) {
// Record whether or not the server tried to resume a session for a
// different version. See https://crbug.com/441456.
UMA_HISTOGRAM_BOOLEAN(
"Net.SSLSessionVersionMatch",
SSL_version(ssl_) == SSL_get_session(ssl_)->ssl_version);
}
}
const CertStatus cert_status = server_cert_verify_result_.cert_status; const CertStatus cert_status = server_cert_verify_result_.cert_status;
if (transport_security_state_ && if (transport_security_state_ &&
(result == OK || (result == OK ||
......
...@@ -19007,6 +19007,15 @@ Therefore, the affected-histogram name has to have at least one dot in it. ...@@ -19007,6 +19007,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary> </summary>
</histogram> </histogram>
<histogram name="Net.SSLSessionVersionMatch" enum="BooleanMatched">
<owner>davidben@chromium.org</owner>
<summary>
For each SSL connection that resumed a session, whether the session was
resumed at the same version it was established at. This is only recorded in
BoringSSL ports.
</summary>
</histogram>
<histogram name="Net.SSLv3FallbackToRenegoPatchedServer" <histogram name="Net.SSLv3FallbackToRenegoPatchedServer"
enum="TLSRenegotiationPatched"> enum="TLSRenegotiationPatched">
<obsolete> <obsolete>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment