Skip to content

GitLab

T
tangled
Commit 85662ebb authored by myid.o.shin@gmail.com's avatar myid.o.shin@gmail.com
Browse files
Options

Fix ScriptPreprocessor leak in inspector test case of LayoutTest. 

We need to clear preprocessor when disabling inspector.

LeakExpectations : remove fixed bugs of inspector 

BUG=301515, 364408, 376188
R=haraken@chromium.org
R=kouhei@chromium.org

Review URL: https://codereview.chromium.org/458933002

git-svn-id: svn://svn.chromium.org/blink/trunk@180068 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 3390b46c
Hide whitespace changes
Inline Side-by-side
Showing with 8 additions and 95 deletions
third_party/WebKit/LayoutTests/LeakExpectations
View file @ 85662ebb
......@@ -38,7 +38,6 @@ crbug.com/371264 virtual/implsidepainting/inspector/timeline/timeline-window-fil
# The leak detector doesn't wait for worker threads to completely clean up, so leaks are expected.
crbug.com/301515 fast/workers/worker-terminate.html [ Leak ]
crbug.com/301515 inspector-protocol/debugger/debugger-terminate-dedicated-worker-while-paused.html [ Leak ]
# -----------------------------------------------------------------
# Untriaged but known real leaks.
......@@ -59,12 +58,6 @@ crbug.com/398742 fast/workers/shared-worker-event-listener.html [ Leak ]
crbug.com/398742 fast/workers/worker-crash-with-invalid-location.html [ Leak ]
crbug.com/398742 http/tests/security/contentSecurityPolicy/1.1/child-src/worker-shared-allowed.html [ Leak ]
crbug.com/364408 inspector/extensions/extensions-audits-content-script.html [ Leak ]
crbug.com/364408 inspector/extensions/extensions-eval-content-script.html [ Leak ]
crbug.com/364408 inspector/extensions/extensions-reload.html [ Leak ]
crbug.com/364408 inspector/sources/debugger/debugger-script-preprocessor.html [ Leak ]
crbug.com/364408 inspector/sources/debugger/live-edit-breakpoints.html [ Leak Timeout ]
crbug.com/364411 fast/frames/location-observe-callback-crash.html [ Leak ]
crbug.com/364417 editing/selection/selection-in-iframe-removed-crash.html [ Leak ]
......@@ -89,94 +82,6 @@ crbug.com/366455 svg/W3C-SVG-1.1/text-intro-04-t.svg [ Leak ]
crbug.com/366455 svg/css/font-face-crash.html [ Leak ]
crbug.com/366455 svg/custom/svg-fonts-fallback.xhtml [ Leak ]
crbug.com/376188 http/tests/inspector/compiler-source-mapping-debug.html [ Leak ]
crbug.com/376188 http/tests/inspector/network/load-resource-when-paused.html [ Leak ]
crbug.com/376188 inspector-protocol/debugger/access-obsolete-frame.html [ Leak ]
crbug.com/376188 inspector-protocol/debugger/continueToLocation.html [ Leak ]
crbug.com/376188 inspector-protocol/debugger/debugger-evaluate-in-worker-while-pause-in-page.html [ Leak ]
crbug.com/376188 inspector-protocol/debugger/debugger-setVariableValue.html [ Leak ]
crbug.com/376188 inspector-protocol/debugger/getStepInPositions.html [ Leak ]
crbug.com/376188 inspector-protocol/debugger/postMessage-on-pause.html [ Leak ]
crbug.com/376188 inspector-protocol/debugger/setScriptSource.html [ Leak ]
crbug.com/376188 inspector-protocol/debugger/updateCallFrameScopes.html [ Leak ]
crbug.com/376188 inspector-protocol/loading-iframe-document-node.html [ Leak ]
crbug.com/376188 inspector-protocol/runtime/runtime-getProperties.html [ Leak ]
crbug.com/376188 inspector/console/console-api-on-call-frame.html [ Leak ]
crbug.com/376188 inspector/console/console-error-on-call-frame.html [ Leak ]
crbug.com/376188 inspector/console/console-format.html [ Leak ]
crbug.com/376188 inspector/console/console-native-function.html [ Leak ]
crbug.com/376188 inspector/console/console-save-to-temp-var.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/async-callstack-and-framework-black-box.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/async-callstack-eval.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/async-callstack-middle-run.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/async-callstack-mutation-observer.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/async-callstack-scopes.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/async-callstack-xhrs.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/async-callstack.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/callstack-placards-discarded.html [ Leak Timeout ]
crbug.com/376188 inspector/sources/debugger/copy-stack-trace.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/custom-element-lifecycle-events.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debug-console-command.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debug-inlined-scripts-fragment-id.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debug-inlined-scripts.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-activation-crash2.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-change-variable.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-command-line-api.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-completions-on-call-frame.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-eval-on-call-frame.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-eval-while-paused.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-expand-scope.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-no-nested-pause.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-no-pause-on-antibreakpoint.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-pause-in-eval-script.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-pause-in-internal.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-pause-on-blocked-event-handler.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-pause-on-blocked-script-injection.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-pause-on-blocked-script-url.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-pause-on-debugger-statement.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-pause-on-exception.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-pause-on-failed-assertion.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-pause-with-overrides.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-proto-property.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-reload-on-pause.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-return-value.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-set-breakpoint-regex.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-step-in.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-step-into-custom-element-callbacks.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-step-into-event-listener.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-step-out.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-step-over.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/debugger-suspend-active-dom-objects.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/dom-breakpoints.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/dynamic-scripts-breakpoints.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/eval-on-pause-blocked.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/event-listener-breakpoints.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/frameworks-dom-xhr-event-breakpoints.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/frameworks-skip-step-in.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/frameworks-steppings.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/frameworks-with-async-callstack.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/function-details.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/function-display-name-call-stack.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/js-with-inline-stylesheets.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/live-edit-no-reveal.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/live-edit.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/mutation-observer-suspend-while-paused.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/pause-in-inline-script.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/pause-in-internal-script.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/properties-special.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/reveal-execution-line.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/reveal-not-skipped.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/script-formatter-breakpoints-1.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/script-formatter-breakpoints-2.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/script-formatter-breakpoints-3.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/selected-call-frame-after-formatting-source.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/set-breakpoint.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/skip-pauses-until-reload.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/skip-stack-frames-steps.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/step-through-event-listeners.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/watch-expressions-panel-switch.html [ Leak ]
crbug.com/376188 inspector/sources/debugger/xhr-breakpoints.html [ Leak ]
# Resource leak
crbug.com/402743 http/tests/xmlhttprequest/xmlhttprequest-sync-vs-async-assertion-failure.html [ Leak ]
crbug.com/402743 http/tests/xmlhttprequest/xmlhttprequest-leaks-on-multiple-send.html [ Leak ]
......
third_party/WebKit/Source/bindings/core/v8/PageScriptDebugServer.cpp
View file @ 85662ebb
......@@ -308,6 +308,11 @@ String PageScriptDebugServer::preprocessEventListener(LocalFrame* frame, const S
return m_scriptPreprocessor->preprocessSourceCode(source, url, functionName);
}
void PageScriptDebugServer::clearPreprocessor()
{
m_scriptPreprocessor.clear();
}
void PageScriptDebugServer::muteWarningsAndDeprecations()
{
FrameConsole::mute();
......
third_party/WebKit/Source/bindings/core/v8/PageScriptDebugServer.h
View file @ 85662ebb
......@@ -71,6 +71,7 @@ public:
virtual void preprocessBeforeCompile(const v8::Debug::EventDetails&) OVERRIDE;
virtual PassOwnPtr<ScriptSourceCode> preprocess(LocalFrame*, const ScriptSourceCode&) OVERRIDE;
virtual String preprocessEventListener(LocalFrame*, const String& source, const String& url, const String& functionName) OVERRIDE;
virtual void clearPreprocessor() OVERRIDE;
virtual void muteWarningsAndDeprecations() OVERRIDE;
virtual void unmuteWarningsAndDeprecations() OVERRIDE;
......
third_party/WebKit/Source/bindings/core/v8/ScriptDebugServer.h
View file @ 85662ebb
......@@ -108,6 +108,7 @@ public:
virtual void preprocessBeforeCompile(const v8::Debug::EventDetails&) { }
virtual PassOwnPtr<ScriptSourceCode> preprocess(LocalFrame*, const ScriptSourceCode&);
virtual String preprocessEventListener(LocalFrame*, const String& source, const String& url, const String& functionName);
virtual void clearPreprocessor() { }
virtual void muteWarningsAndDeprecations() { }
virtual void unmuteWarningsAndDeprecations() { }
......
third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp
View file @ 85662ebb
......@@ -162,6 +162,7 @@ void InspectorDebuggerAgent::disable()
scriptDebugServer().clearBreakpoints();
scriptDebugServer().clearCompiledScripts();
scriptDebugServer().clearPreprocessor();
stopListeningScriptDebugServer();
clear();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment