Skip to content

GitLab

T
tangled
Commit 85eb770d authored by Sunny Sachanandani's avatar Sunny Sachanandani Committed by Commit Bot
Browse files
Options

perf: Migrate disabled key_mobile_sites_smooth pages to expectations. 

Some pages were disabled by commenting out code. This makes refactoring
annoying so migrate these to expectations.

BUG=760553

Change-Id: I85f109d8c0093403693e39290e4d7c41cbe9662d
Reviewed-on: https://chromium-review.googlesource.com/891817
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#534598}
parent 233ed9ec
Hide whitespace changes
Inline Side-by-side
Showing with 33 additions and 88 deletions
tools/perf/expectations.config
View file @ 85eb770d
......@@ -127,7 +127,11 @@ crbug.com/750131 [ Win ] smoothness.key_desktop_move_cases/https://mail.google.c
crbug.com/770904 [ Mac ] smoothness.key_desktop_move_cases/https://mail.google.com/mail/ [ Skip ]
# Benchmark: smoothness.key_mobile_sites_smooth
crbug.com/756119 [ Android ] smoothness.key_mobile_sites_smooth/http://digg.com [ Skip ]
crbug.com/756119 [ All ] smoothness.key_mobile_sites_smooth/http://digg.com [ Skip ]
crbug.com/667432 [ All ] smoothness.key_mobile_sites_smooth/http://www.amazon.com/gp/aw/s/ref=is_box_?k=nicolas+cage [ Skip ]
crbug.com/169980 [ All ] smoothness.key_mobile_sites_smooth/Twitter [ Skip ]
crbug.com/249722 [ All ] smoothness.key_mobile_sites_smooth/ESPN [ Skip ]
crbug.com/249736 [ All ] smoothness.key_mobile_sites_smooth/http://forecast.io [ Skip ]
# Benchmark: smoothness.key_silk_cases
[ All ] smoothness.key_silk_cases/inbox_app.html?slide_drawer [ Skip ]
......
tools/perf/page_sets/data/key_mobile_sites_011.wprgo.sha1 0 → 100644
View file @ 85eb770d
55b355eecc12fdaf9521181508f3c8abeff477f1
\ No newline at end of file
tools/perf/page_sets/data/key_mobile_sites_012.wprgo.sha1 0 → 100644
View file @ 85eb770d
45d33e89afc119359b49ded38bf8f977fcffff8e
\ No newline at end of file
tools/perf/page_sets/data/key_mobile_sites_013.wprgo.sha1 0 → 100644
View file @ 85eb770d
4168e2e0672f038f39450c0babbf4b4be6cbb1d7
\ No newline at end of file
tools/perf/page_sets/data/key_mobile_sites_014.wprgo.sha1 0 → 100644
View file @ 85eb770d
6fbfdaa7f5ee08be5d381f8426b64338daa63e2c
\ No newline at end of file
tools/perf/page_sets/data/key_mobile_sites_015.wprgo.sha1 0 → 100644
View file @ 85eb770d
9e603dce548fc0fdbb916a1cff04a0b7e7360782
\ No newline at end of file
tools/perf/page_sets/data/key_mobile_sites_smooth.json
View file @ 85eb770d
{
"archives": {
"ESPN": {
"DEFAULT": "key_mobile_sites_012.wprgo"
},
"Twitter": {
"DEFAULT": "key_mobile_sites_011.wprgo"
},
"Wikipedia_(1_tab)": {
"DEFAULT": "key_mobile_sites_009.wprgo"
},
......@@ -13,7 +19,7 @@
"DEFAULT": "key_mobile_sites_000.wprgo"
},
"http://digg.com": {
"DEFAULT": "key_mobile_sites_002.wprgo"
"DEFAULT": "key_mobile_sites_014.wprgo"
},
"http://en.blog.wordpress.com/2012/09/04/freshly-pressed-editors-picks-for-august-2012/": {
"DEFAULT": "key_mobile_sites_000.wprgo"
......@@ -21,6 +27,9 @@
"http://en.wikipedia.org/wiki/Wikipedia": {
"DEFAULT": "key_mobile_sites_000.wprgo"
},
"http://forecast.io": {
"DEFAULT": "key_mobile_sites_013.wprgo"
},
"http://ftw.usatoday.com/2014/05/spelling-bee-rules-shenanigans": {
"DEFAULT": "key_mobile_sites_007.wprgo"
},
......@@ -91,7 +100,7 @@
"DEFAULT": "key_mobile_sites_000.wprgo"
},
"http://www.amazon.com/gp/aw/s/ref=is_box_?k=nicolas+cage": {
"DEFAULT": "key_mobile_sites_000.wprgo"
"DEFAULT": "key_mobile_sites_015.wprgo"
},
"http://www.androidpolice.com/2012/10/03/rumor-evidence-mounts-that-an-lg-optimus-g-nexus-is-coming-along-with-a-nexus-phone-certification-program/": {
"DEFAULT": "key_mobile_sites_000.wprgo"
......@@ -153,4 +162,4 @@
},
"description": "Describes the Web Page Replay archives for a story set. Don't edit by hand! Use record_wpr for updating.",
"platform_specific": true
}
}
\ No newline at end of file
tools/perf/page_sets/key_mobile_sites_pages.py
View file @ 85eb770d
......@@ -144,44 +144,6 @@ class YahooAnswersPage(KeyMobileSitesPage):
action_runner.ClickElement(text='Other Answers (1 - 20 of 149)')
class GroupClonedPage(KeyMobileSitesPage):
""" Why: crbug.com/172906 """
def __init__(self, page_set, name='', extra_browser_args=None):
super(GroupClonedPage, self).__init__(
url='http://groupcloned.com',
page_set=page_set,
name=name,
extra_browser_args=extra_browser_args)
def RunNavigateSteps(self, action_runner):
super(GroupClonedPage, self).RunNavigateSteps(action_runner)
action_runner.Wait(5)
action_runner.WaitForJavaScriptCondition("""
document.getElementById("element-19") !== null &&
document.getElementById("element-19").contentDocument
.getElementById("element-22") !== null &&
document.getElementById("element-19").contentDocument
.getElementsByClassName(
"container list-item gc-list-item stretched").length !== 0""")
class GroupClonedListImagesPage(KeyMobileSitesPage):
""" Why: crbug.com/172906 """
def __init__(self, page_set, name='', extra_browser_args=None):
super(GroupClonedListImagesPage, self).__init__(
url='http://groupcloned.com/test/list-images-variable/index.html',
page_set=page_set,
name=name,
extra_browser_args=extra_browser_args)
def RunNavigateSteps(self, action_runner):
super(GroupClonedListImagesPage, self).RunNavigateSteps(action_runner)
action_runner.WaitForJavaScriptCondition(
'document.getElementById("element-5") !== null')
class GoogleNewsMobilePage(KeyMobileSitesPage):
""" Why: Google News: accelerated scrolling version """
......
tools/perf/page_sets/key_mobile_sites_smooth.py
View file @ 85eb770d
......@@ -82,32 +82,6 @@ class WowwikiSmoothPage(KeyMobileSitesSmoothPage):
super(WowwikiSmoothPage, self).RunNavigateSteps(action_runner)
class GroupClonedSmoothPage(key_mobile_sites_pages.GroupClonedPage):
def RunPageInteractions(self, action_runner):
with action_runner.CreateGestureInteraction('ScrollAction'):
action_runner.ScrollPage(
distance_expr="""
Math.max(0, 1250 + document.getElementById("element-19")
.contentDocument
.getElementById("element-22")
.getBoundingClientRect().top);""",
use_touch=True)
class GroupClonedListImagesPage(
key_mobile_sites_pages.GroupClonedListImagesPage):
def RunPageInteractions(self, action_runner):
with action_runner.CreateGestureInteraction('ScrollAction'):
action_runner.ScrollPage(
distance_expr="""
Math.max(0, 1250 +
document.getElementById("element-5")
.getBoundingClientRect().top);""",
use_touch=True)
class AmazonNicolasCageSmoothPage(key_mobile_sites_pages.AmazonNicolasCagePage):
def RunPageInteractions(self, action_runner):
......@@ -151,17 +125,7 @@ class KeyMobileSitesSmoothPageSet(story.StorySet):
self.AddStory(WowwikiSmoothPage(self))
# Add pages with custom page interaction logic.
# Page behaves non-deterministically, replaced with test version for now.
# self.AddStory(GroupClonedSmoothPage(self))
# mean_input_event_latency cannot be tracked correctly for
# GroupClonedListImagesPage.
# See crbug.com/409086.
# self.AddStory(GroupClonedListImagesSmoothPage(self))
# Amazon's Nicolas Cage search is currently failing. Reenable it once it's
# not anymore.
# crbug.com/667432
# self.AddStory(AmazonNicolasCageSmoothPage(self))
self.AddStory(AmazonNicolasCageSmoothPage(self))
self.AddStory(CNNArticleSmoothPage(self))
# Add pages with custom tags.
......@@ -208,9 +172,9 @@ class KeyMobileSitesSmoothPageSet(story.StorySet):
action_on_load_complete=True))
# Why: #8 (Alexa global), picked an interesting page
# Forbidden (Rate Limit Exceeded)
# self.AddStory(KeyMobileSitesSmoothPage(
# url='http://twitter.com/katyperry', page_set=self, name='Twitter'))
self.AddStory(
KeyMobileSitesSmoothPage(
url='http://twitter.com/katyperry', page_set=self, name='Twitter'))
# Why: #37 (Alexa global) """
self.AddStory(
......@@ -218,13 +182,14 @@ class KeyMobileSitesSmoothPageSet(story.StorySet):
url='http://pinterest.com', page_set=self, name='Pinterest'))
# Why: #1 sports.
# Fails often; crbug.com/249722'
# self.AddStory(KeyMobileSitesSmoothPage(
# url='http://espn.go.com', page_set=self, name='ESPN'))
self.AddStory(
KeyMobileSitesSmoothPage(
url='http://espn.go.com', page_set=self, name='ESPN'))
# Why: crbug.com/231413
# Doesn't scroll; crbug.com/249736
# self.AddStory(KeyMobileSitesSmoothPage(
# url='http://forecast.io', page_set=self))
self.AddStory(
KeyMobileSitesSmoothPage(url='http://forecast.io', page_set=self))
# Why: crbug.com/169827
self.AddStory(
KeyMobileSitesSmoothPage(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment