Commit 85fd25ec authored by Jérémie Boulic's avatar Jérémie Boulic Committed by Chromium LUCI CQ

Files app: Generate more JS modules for foreground page

In //ui/file_manager/file_manager/foreground/js/:
- crostini_controller.js
- gear_menu_controller.js

Bug: 1133186
Change-Id: Ie078a26ec4d4fd4b73f780061483e2c62600bab7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631387Reviewed-by: default avatarLuciano Pacheco <lucmult@chromium.org>
Commit-Queue: Jeremie Boulic <jboulic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843946}
parent a1e7ec86
...@@ -54,6 +54,14 @@ js_library("command_handler_deps.m") { ...@@ -54,6 +54,14 @@ js_library("command_handler_deps.m") {
extra_deps = [ ":modulize" ] extra_deps = [ ":modulize" ]
} }
js_library("directory_change_event.m") {
sources =
[ "$root_gen_dir/ui/file_manager/externs/directory_change_event.m.js" ]
deps = [ ":files_app_entry_interfaces.m" ]
extra_deps = [ ":modulize" ]
}
js_library("entries_changed_event.m") { js_library("entries_changed_event.m") {
sources = sources =
[ "$root_gen_dir/ui/file_manager/externs/entries_changed_event.m.js" ] [ "$root_gen_dir/ui/file_manager/externs/entries_changed_event.m.js" ]
...@@ -160,6 +168,7 @@ js_modulizer("modulize") { ...@@ -160,6 +168,7 @@ js_modulizer("modulize") {
input_files = [ input_files = [
"background_window.js", "background_window.js",
"command_handler_deps.js", "command_handler_deps.js",
"directory_change_event.js",
"entries_changed_event.js", "entries_changed_event.js",
"entry_location.js", "entry_location.js",
"exif_entry.js", "exif_entry.js",
......
...@@ -2,8 +2,19 @@ ...@@ -2,8 +2,19 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
class DirectoryChangeEvent extends Event { /**
constructor() { * @fileoverview
* @suppress {externsValidation} this file is used as externs and also
* as JS module, Closure fails to compile as externs.
*/
// #import {FakeEntry} from './files_app_entry_interfaces.m.js';
/* #export */ class DirectoryChangeEvent extends Event {
/** @param {string} eventName */
constructor(eventName) {
super(eventName);
/** @type {DirectoryEntry} */ /** @type {DirectoryEntry} */
this.previousDirEntry; this.previousDirEntry;
......
...@@ -33,6 +33,7 @@ js_type_check("closure_compile_jsmodules") { ...@@ -33,6 +33,7 @@ js_type_check("closure_compile_jsmodules") {
":android_app_list_model.m", ":android_app_list_model.m",
":constants.m", ":constants.m",
":crossover_search_utils.m", ":crossover_search_utils.m",
":crostini_controller.m",
":dialog_type.m", ":dialog_type.m",
":directory_contents.m", ":directory_contents.m",
":directory_model.m", ":directory_model.m",
...@@ -49,6 +50,7 @@ js_type_check("closure_compile_jsmodules") { ...@@ -49,6 +50,7 @@ js_type_check("closure_compile_jsmodules") {
":file_type_filters_controller.m", ":file_type_filters_controller.m",
":file_watcher.m", ":file_watcher.m",
":folder_shortcuts_data_model.m", ":folder_shortcuts_data_model.m",
":gear_menu_controller.m",
":holding_space_util.m", ":holding_space_util.m",
":import_controller.m", ":import_controller.m",
":last_modified_controller.m", ":last_modified_controller.m",
...@@ -445,6 +447,26 @@ js_library("crostini_controller") { ...@@ -445,6 +447,26 @@ js_library("crostini_controller") {
] ]
} }
js_library("crostini_controller.m") {
sources = [ "$root_gen_dir/ui/file_manager/file_manager/foreground/js/crostini_controller.m.js" ]
deps = [
":constants.m",
":directory_model.m",
":file_manager_commands.m",
":navigation_list_model.m",
"ui:directory_tree.m",
"//ui/file_manager/base/js:volume_manager_types.m",
"//ui/file_manager/externs/background:crostini.m",
"//ui/file_manager/file_manager/common/js:files_app_entry_types.m",
"//ui/file_manager/file_manager/common/js:util.m",
"//ui/file_manager/file_manager/foreground/elements:files_message.m",
"//ui/file_manager/file_manager/foreground/elements:files_toast.m",
"//ui/webui/resources/js:assert.m",
]
extra_deps = [ ":modulize" ]
}
js_library("dialog_action_controller") { js_library("dialog_action_controller") {
deps = [ deps = [
":dialog_type", ":dialog_type",
...@@ -1064,6 +1086,23 @@ js_library("gear_menu_controller") { ...@@ -1064,6 +1086,23 @@ js_library("gear_menu_controller") {
] ]
} }
js_library("gear_menu_controller.m") {
sources = [ "$root_gen_dir/ui/file_manager/file_manager/foreground/js/gear_menu_controller.m.js" ]
deps = [
":directory_model.m",
":file_manager_commands.m",
":providers_model.m",
"ui:gear_menu.m",
"ui:multi_menu_button.m",
"ui:providers_menu.m",
"//ui/file_manager/base/js:volume_manager_types.m",
"//ui/file_manager/externs:directory_change_event.m",
"//ui/file_manager/file_manager/common/js:util.m",
]
extra_deps = [ ":modulize" ]
}
js_library("holding_space_util") { js_library("holding_space_util") {
deps = [ deps = [
"//ui/file_manager/base/js:volume_manager_types", "//ui/file_manager/base/js:volume_manager_types",
...@@ -1802,6 +1841,8 @@ js_modulizer("modulize") { ...@@ -1802,6 +1841,8 @@ js_modulizer("modulize") {
"thumbnail_loader.js", "thumbnail_loader.js",
"web_store_utils.js", "web_store_utils.js",
"webui_command_extender.js", "webui_command_extender.js",
"crostini_controller.js",
"gear_menu_controller.js",
] ]
namespace_rewrites = cr_namespace_rewrites + [ namespace_rewrites = cr_namespace_rewrites + [
......
...@@ -2,10 +2,25 @@ ...@@ -2,10 +2,25 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// clang-format off
// #import {FilesToast} from '../elements/files_toast.m.js';
// #import {DirectoryTree} from './ui/directory_tree.m.js';
// #import {DirectoryModel} from './directory_model.m.js';
// #import {FilesMessage} from '../elements/files_message.m.js';
// #import {Crostini} from '../../../externs/background/crostini.m.js';
// #import {CommandHandler} from './file_manager_commands.m.js';
// #import {VolumeManagerCommon} from '../../../base/js/volume_manager_types.m.js';
// #import {FakeEntryImpl} from '../../common/js/files_app_entry_types.m.js';
// #import {str, strf} from '../../common/js/util.m.js';
// #import {NavigationModelFakeItem, NavigationModelItemType} from './navigation_list_model.m.js';
// #import {constants} from './constants.m.js';
// #import {assert} from 'chrome://resources/js/assert.m.js';
// clang-format on
/** /**
* CrostiniController handles the foreground UI relating to crostini. * CrostiniController handles the foreground UI relating to crostini.
*/ */
class CrostiniController { /* #export */ class CrostiniController {
/** /**
* @param {!Crostini} crostini Crostini background object. * @param {!Crostini} crostini Crostini background object.
* @param {!FilesMessage} filesMessage FilesMessage. * @param {!FilesMessage} filesMessage FilesMessage.
......
...@@ -2,7 +2,20 @@ ...@@ -2,7 +2,20 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
class GearMenuController { // clang-format off
// #import {ProvidersModel} from './providers_model.m.js';
// #import {CommandHandler} from './file_manager_commands.m.js';
// #import {DirectoryModel} from './directory_model.m.js';
// #import {ProvidersMenu} from './ui/providers_menu.m.js';
// #import {GearMenu} from './ui/gear_menu.m.js';
// #import {MultiMenuButton} from './ui/multi_menu_button.m.js';
// #import {VolumeManagerCommon} from '../../../base/js/volume_manager_types.m.js';
// #import {DirectoryChangeEvent} from '../../../externs/directory_change_event.m.js';
// #import {str, util} from '../../common/js/util.m.js';
// clang-format on
/* #export */ class GearMenuController {
/** /**
* @param {!cr.ui.MultiMenuButton} gearButton * @param {!cr.ui.MultiMenuButton} gearButton
* @param {!FilesToggleRippleElement} toggleRipple * @param {!FilesToggleRippleElement} toggleRipple
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment