Commit 860a1adb authored by Dana Fried's avatar Dana Fried Committed by Commit Bot

Setting footnote view invalidates bubble frame.

This might be the root cause of the tagged issue, though it is no longer
reproducible.

Note that layout is already invalidated when the title changes, for
ostensibly the same reason.

Bug: 1038448
Change-Id: I3f4e40d8450fc1a96da1d0c1b1e6e9b2c9ac661e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018487Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735129}
parent d1d91d06
......@@ -498,12 +498,12 @@ void BubbleFrameView::SetFootnoteView(std::unique_ptr<View> view) {
// Remove the old footnote container.
delete footnote_container_;
footnote_container_ = nullptr;
if (!view)
return;
int radius = bubble_border_ ? bubble_border_->corner_radius() : 0;
footnote_container_ = AddChildView(std::make_unique<FootnoteContainerView>(
footnote_margins_, std::move(view), radius));
if (view) {
int radius = bubble_border_ ? bubble_border_->corner_radius() : 0;
footnote_container_ = AddChildView(std::make_unique<FootnoteContainerView>(
footnote_margins_, std::move(view), radius));
}
InvalidateLayout();
}
View* BubbleFrameView::GetFootnoteView() const {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment