Media Engagement: Rename feature flag

Rename the media-engagement feature flag to
RecordMediaEngagementScores in order to better describe what it
is doing.

BUG=None

Change-Id: I3d3ac469f6c32418396ca95884d18374ce8db1e1
Reviewed-on: https://chromium-review.googlesource.com/579196Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488369}

chrome/browser/media/media_engagement_service.cc

@@ -66,7 +66,7 @@ const char MediaEngagementService::kHistogramScoreAtStartupName[] =
 
 // static
 bool MediaEngagementService::IsEnabled() {
-  return base::FeatureList::IsEnabled(media::kMediaEngagement);
+  return base::FeatureList::IsEnabled(media::kRecordMediaEngagementScores);
 }
 
 // static

chrome/browser/media/media_engagement_service_unittest.cc

@@ -101,7 +101,8 @@ std::unique_ptr<KeyedService> BuildTestHistoryService(
 class MediaEngagementServiceTest : public ChromeRenderViewHostTestHarness {
  public:
   void SetUp() override {
-    scoped_feature_list_.InitAndEnableFeature(media::kMediaEngagement);
+    scoped_feature_list_.InitAndEnableFeature(
+        media::kRecordMediaEngagementScores);
     ChromeRenderViewHostTestHarness::SetUp();
 
     ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

chrome/test/data/webui/media/media_engagement_browsertest.js

@@ -23,7 +23,7 @@ MediaEngagementWebUIBrowserTest.prototype = {
 
   commandLineSwitches: [{
     switchName: 'enable-features',
-    switchValue: 'media-engagement'
+    switchValue: 'RecordMediaEngagementScores'
   }],
 
   runAccessibilityChecks: false,

media/base/media_switches.cc

@@ -267,8 +267,8 @@ const base::Feature kLowDelayVideoRenderingOnLiveStream{
 
 // Enables Media Engagement Index recording. The data from which will
 // be used to bypass autoplay policies.
-const base::Feature kMediaEngagement{"media-engagement",
-                                     base::FEATURE_ENABLED_BY_DEFAULT};
+const base::Feature kRecordMediaEngagementScores{
+    "kRecordMediaEngagementScores", base::FEATURE_ENABLED_BY_DEFAULT};
 
 #if defined(OS_ANDROID)
 // Lock the screen orientation when a video goes fullscreen.

media/base/media_switches.h

@@ -108,7 +108,7 @@ MEDIA_EXPORT extern const base::Feature kComplexityBasedVideoBuffering;
 MEDIA_EXPORT extern const base::Feature kExternalClearKeyForTesting;
 MEDIA_EXPORT extern const base::Feature kLowDelayVideoRenderingOnLiveStream;
 MEDIA_EXPORT extern const base::Feature kMediaCastOverlayButton;
-MEDIA_EXPORT extern const base::Feature kMediaEngagement;
+MEDIA_EXPORT extern const base::Feature kRecordMediaEngagementScores;
 MEDIA_EXPORT extern const base::Feature kMemoryPressureBasedSourceBufferGC;
 MEDIA_EXPORT extern const base::Feature kMojoCdm;
 MEDIA_EXPORT extern const base::Feature kNewAudioRenderingMixingStrategy;