Commit 864e2f05 authored by Tim van der Lippe's avatar Tim van der Lippe Committed by Chromium LUCI CQ

Inline usages of peekLast in DevTools tests

R=szuend@chromium.org

Bug: 1050549
Change-Id: I763f8596ab931c97a5b15dcd2639f59baab2763b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627412
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: default avatarSimon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842985}
parent b953c829
...@@ -165,7 +165,7 @@ ...@@ -165,7 +165,7 @@
var children = root.children.slice(); var children = root.children.slice();
root.removeChildren(); root.removeChildren();
// Assure wheelTarget is anything but null, otherwise it happily bypasses crashing code. // Assure wheelTarget is anything but null, otherwise it happily bypasses crashing code.
dataGrid._wheelTarget = children.peekLast().element; dataGrid._wheelTarget = children[children.length - 1].element;
for (var i = 0; i < 40; ++i) { for (var i = 0; i < 40; ++i) {
children[i].refresh(); children[i].refresh();
root.appendChild(children[i]); root.appendChild(children[i]);
......
...@@ -8,7 +8,8 @@ ...@@ -8,7 +8,8 @@
await TestRunner.showPanel('timeline'); await TestRunner.showPanel('timeline');
TestRunner.enableTimelineExtensionAndStart = function(callback) { TestRunner.enableTimelineExtensionAndStart = function(callback) {
const provider = Extensions.extensionServer.traceProviders().peekLast(); const traceProviders = Extensions.extensionServer.traceProviders();
const provider = traceProviders[traceProviders.length - 1];
const timelinePanel = UI.panels.timeline; const timelinePanel = UI.panels.timeline;
const setting = Timeline.TimelinePanel._settingForTraceProvider(provider); const setting = Timeline.TimelinePanel._settingForTraceProvider(provider);
setting.set(true); setting.set(true);
......
...@@ -23,7 +23,8 @@ ...@@ -23,7 +23,8 @@
TestRunner.evaluateInPage('document.querySelector("form").submit();'); TestRunner.evaluateInPage('document.querySelector("form").submit();');
await snifferPromise; await snifferPromise;
var request = NetworkTestRunner.networkRequests().peekLast(); const networkRequests = NetworkTestRunner.networkRequests();
var request = networkRequests[networkRequests.length - 1];
if (request.url().endsWith('/')) { if (request.url().endsWith('/')) {
await TestRunner.addSnifferPromise(SDK.NetworkDispatcher.prototype, 'requestWillBeSent'); await TestRunner.addSnifferPromise(SDK.NetworkDispatcher.prototype, 'requestWillBeSent');
request = NetworkTestRunner.networkRequests().pop(); request = NetworkTestRunner.networkRequests().pop();
......
...@@ -22,7 +22,8 @@ ...@@ -22,7 +22,8 @@
TestRunner.evaluateInPage('navigateLink()'); TestRunner.evaluateInPage('navigateLink()');
await snifferPromise; await snifferPromise;
var request = NetworkTestRunner.networkRequests().peekLast(); const networkRequests = NetworkTestRunner.networkRequests();
var request = networkRequests[networkRequests.length - 1];
if (request.url().endsWith('/')) { if (request.url().endsWith('/')) {
await TestRunner.addSnifferPromise(SDK.NetworkDispatcher.prototype, 'requestWillBeSent'); await TestRunner.addSnifferPromise(SDK.NetworkDispatcher.prototype, 'requestWillBeSent');
request = NetworkTestRunner.networkRequests().pop(); request = NetworkTestRunner.networkRequests().pop();
......
...@@ -13,7 +13,7 @@ ...@@ -13,7 +13,7 @@
UI.panels.timeline._captureLayersAndPicturesSetting.set(true); UI.panels.timeline._captureLayersAndPicturesSetting.set(true);
await PerformanceTestRunner.invokeAsyncWithTimeline('doActions'); await PerformanceTestRunner.invokeAsyncWithTimeline('doActions');
const frames = PerformanceTestRunner.timelineFrameModel().frames(); const frames = PerformanceTestRunner.timelineFrameModel().frames();
const lastFrame = PerformanceTestRunner.timelineFrameModel().frames().peekLast(); const lastFrame = frames[frames.length - 1];
if (lastFrame) { if (lastFrame) {
TestRunner.addResult('layerTree: ' + typeof lastFrame.layerTree); TestRunner.addResult('layerTree: ' + typeof lastFrame.layerTree);
TestRunner.addResult('mainFrameId: ' + typeof lastFrame._mainFrameId); TestRunner.addResult('mainFrameId: ' + typeof lastFrame._mainFrameId);
......
...@@ -35,7 +35,7 @@ ...@@ -35,7 +35,7 @@
await PerformanceTestRunner.invokeAsyncWithTimeline('doActions'); await PerformanceTestRunner.invokeAsyncWithTimeline('doActions');
const frames = PerformanceTestRunner.timelineFrameModel().frames(); const frames = PerformanceTestRunner.timelineFrameModel().frames();
const lastFrame = PerformanceTestRunner.timelineFrameModel().frames().peekLast(); const lastFrame = frames[frames.length - 1];
const layerTreeModel = await lastFrame.layerTree.layerTreePromise(); const layerTreeModel = await lastFrame.layerTree.layerTreePromise();
LayersTestRunner.dumpLayerTree(undefined, layerTreeModel.contentRoot()); LayersTestRunner.dumpLayerTree(undefined, layerTreeModel.contentRoot());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment