Commit 866b2aa4 authored by yhirano@chromium.org's avatar yhirano@chromium.org

[BackgroundSync] Use appopriate type parameters for WebCallbacks (4/4)

This series of CLs fixes WebCallback parameter types used in BackgroundSync.

 - WebSyncRegistration* (ownership transferred)
  => PassOwnPtr<WebServiceWorkerResponse>
 - bool* (ownership transferred)
  => bool
 - WebVector<WebSyncRegstration*>* (ownership transferred)
  => const WebVector<WebSyncRegistration*>&
 - WebPermissionStatus* (ownership transferred)
  => WebPermissionStatus
 - WebSyncError* (ownership transferred)
  => const WebSyncError&

1/4: https://codereview.chromium.org/1309143002/
2/4: https://codereview.chromium.org/1311053002/
3/4: https://codereview.chromium.org/1308273002/
4/4: https://codereview.chromium.org/1308283002/

BUG=493531

Review URL: https://codereview.chromium.org/1308283002

git-svn-id: svn://svn.chromium.org/blink/trunk@201330 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 5dd534da
......@@ -17,77 +17,10 @@
namespace blink {
class WebServiceWorkerRegistration;
template <>
class WebCallbacks<WebPassOwnPtr<WebSyncRegistration>, const WebSyncError&> {
public:
virtual ~WebCallbacks() {}
void onSuccess(WebSyncRegistration* r) { onSuccess(adoptWebPtr(r)); }
void onError(WebSyncError* e)
{
onError(*e);
delete e;
}
virtual void onSuccess(WebPassOwnPtr<WebSyncRegistration>) = 0;
virtual void onError(const WebSyncError&) = 0;
};
using WebSyncRegistrationCallbacks = WebCallbacks<WebPassOwnPtr<WebSyncRegistration>, const WebSyncError&>;
template <>
class WebCallbacks<bool, const WebSyncError&> {
public:
virtual ~WebCallbacks() {}
void onSuccess(bool* r)
{
onSuccess(*r);
delete r;
}
void onError(WebSyncError* e)
{
onError(*e);
delete e;
}
virtual void onSuccess(bool) = 0;
virtual void onError(const WebSyncError&) = 0;
};
using WebSyncNotifyWhenDoneCallbacks = WebCallbacks<bool, const WebSyncError&>;
using WebSyncUnregistrationCallbacks = WebCallbacks<bool, const WebSyncError&>;
template <>
class WebCallbacks<const WebVector<WebSyncRegistration*>&, const WebSyncError&> {
public:
virtual ~WebCallbacks() {}
void onSuccess(WebVector<WebSyncRegistration*>* r)
{
onSuccess(*r);
delete r;
}
void onError(WebSyncError* e)
{
onError(*e);
delete e;
}
virtual void onSuccess(const WebVector<WebSyncRegistration*>&) = 0;
virtual void onError(const WebSyncError&) = 0;
};
using WebSyncGetRegistrationsCallbacks = WebCallbacks<const WebVector<WebSyncRegistration*>&, const WebSyncError&>;
template <>
class WebCallbacks<WebSyncPermissionStatus, const WebSyncError&> {
public:
virtual ~WebCallbacks() {}
void onSuccess(WebSyncPermissionStatus* r)
{
onSuccess(*r);
delete r;
}
void onError(WebSyncError* e)
{
onError(*e);
delete e;
}
virtual void onSuccess(WebSyncPermissionStatus) = 0;
virtual void onError(const WebSyncError&) = 0;
};
using WebSyncGetPermissionStatusCallbacks = WebCallbacks<WebSyncPermissionStatus, const WebSyncError&>;
class WebSyncProvider {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment