Print Preview: Only check Chrome OS only policies on Chrome OS

Only use color and duplex setByPolicy on Chrome OS, since these
policies aren't implemented on other platforms.

To make this simpler, move logic for computing whether any setting on
the page is managed out of header.js and into model.js. This is also
more reasonable since model.js is responsible for tracking the settings
and is the only element where settings' |setByPolicy| field is updated.

Change-Id: Ie682c38ffd775cccc4f47c15b66fa85a46761e20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500785Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637584}

chrome/browser/resources/print_preview/new/app.html

@@ -81,7 +81,8 @@
     </style>
     <print-preview-state id="state" state="{{state}}"></print-preview-state>
     <print-preview-model id="model" settings="{{settings}}"
-        destination="{{destination_}}" document-settings="[[documentSettings_]]"
+        controls-managed="{{controlsManaged_}}" destination="{{destination_}}"
+        document-settings="[[documentSettings_]]"
         margins="[[margins_]]" page-size="[[pageSize_]]"
         recent-destinations="{{recentDestinations_}}"
         on-save-sticky-settings="onSaveStickySettings_">
@@ -98,7 +99,7 @@
     <div id="sidebar" on-setting-valid-changed="onSettingValidChanged_">
       <print-preview-header destination="[[destination_]]" state="[[state]]"
           error-message="[[errorMessage_]]" settings="[[settings]]"
-          on-print-requested="onPrintRequested_"
+          managed="[[controlsManaged_]]" on-print-requested="onPrintRequested_"
           on-cancel-requested="onCancelRequested_">
       </print-preview-header>
       <div id="container">

chrome/browser/resources/print_preview/new/app.js

@@ -56,6 +56,9 @@ Polymer({
       computed: 'computeControlsDisabled_(state)',
     },
 
+    /** @private {boolean} */
+    controlsManaged_: Boolean,
+
     /** @private {print_preview.Destination} */
     destination_: {
       type: Object,
@@ -423,9 +426,11 @@ Polymer({
       this.$.model.applyStickySettings();
     }
 
+    // <if expr="chromeos">
     if (this.destination_) {
       this.$.model.applyDestinationSpecificPolicies();
     }
+    // </if>
 
     if (this.state == print_preview_new.State.NOT_READY ||
         this.state == print_preview_new.State.INVALID_PRINTER) {

chrome/browser/resources/print_preview/new/header.html

@@ -74,7 +74,7 @@
     </style>
     <div class="title-container">
       <h1 class="title">$i18n{title}</h1>
-      <iron-icon hidden$="[[!managed_]]" icon="print-preview:business"
+      <iron-icon hidden$="[[!managed]]" icon="print-preview:business"
            alt="" title="$i18n{managedSettings}">
       </iron-icon>
     </div>

chrome/browser/resources/print_preview/new/header.js

@@ -30,14 +30,7 @@ Polymer({
       value: false,
     },
 
-    /** @private */
-    managed_: {
-      type: Boolean,
-      computed: 'computeManaged_(settings.headerFooter.setByPolicy, ' +
-          'settings.headerFooter.available, settings.color.setByPolicy, ' +
-          'settings.color.available, settings.duplex.setByPolicy, ' +
-          'settings.duplex.available)',
-    },
+    managed: Boolean,
 
     /** @private */
     printButtonLabel_: {
@@ -196,16 +189,4 @@ Polymer({
         'printPreviewSummaryFormatShort', labelInfo.numSheets.toLocaleString(),
         labelInfo.summaryLabel);
   },
-
-  /**
-   * @return {boolean} Whether any setting on the page is managed by enterprise
-   *     policy.
-   * @private
-   */
-  computeManaged_: function() {
-    return ['color', 'duplex', 'headerFooter'].some(settingName => {
-      const setting = this.getSetting(settingName);
-      return setting.available && setting.setByPolicy;
-    });
-  },
 });

chrome/browser/resources/print_preview/new/model.js

@@ -297,6 +297,12 @@ Polymer({
       },
     },
 
+    controlsManaged: {
+      type: Boolean,
+      notify: true,
+      value: false,
+    },
+
     /** @type {print_preview.Destination} */
     destination: {
       type: Object,
@@ -740,11 +746,13 @@ Polymer({
       }
     }
     this.initialized_ = true;
+    this.updateManaged_();
     this.stickySettings_ = null;
     this.updateRecentDestinations_();
     this.stickySettingsChanged_();
   },
 
+  // <if expr="chromeos">
   /**
    * Restricts settings and applies defaults as defined by policy applicable to
    * current destination.
@@ -770,6 +778,20 @@ Polymer({
           duplexValue != print_preview.DuplexModeRestriction.SIMPLEX);
     }
     this.set('settings.duplex.setByPolicy', !!duplexPolicy);
+    this.updateManaged_();
+  },
+  // </if>
+
+  /** @private */
+  updateManaged_: function() {
+    let managedSettings = ['headerFooter'];
+    // <if expr="chromeos">
+    managedSettings = managedSettings.concat(['color', 'duplex']);
+    // </if>
+    this.controlsManaged = managedSettings.some(settingName => {
+      const setting = this.getSetting(settingName);
+      return setting.available && setting.setByPolicy;
+    });
   },
 
   /** @return {boolean} Whether the model has been initialized. */

chrome/test/data/webui/print_preview/header_test.js

@@ -25,14 +25,6 @@ cr.define('header_test', function() {
       // whether to show the enterprise managed icon, and pages, copies, and
       // duplex to compute the number of sheets of paper.
       const settings = {
-        color: {
-          value: true, /* color */
-          unavailableValue: false,
-          valid: true,
-          available: true,
-          setByPolicy: false,
-          key: 'isColorEnabled',
-        },
         copies: {
           value: '1',
           unavailableValue: '1',
@@ -49,14 +41,6 @@ cr.define('header_test', function() {
           setByPolicy: false,
           key: 'isDuplexEnabled',
         },
-        headerFooter: {
-          value: true,
-          unavailableValue: false,
-          valid: true,
-          available: true,
-          setByPolicy: false,
-          key: 'isHeaderFooterEnabled',
-        },
         pages: {
           value: [1],
           unavailableValue: [],
@@ -76,6 +60,7 @@ cr.define('header_test', function() {
           print_preview.DestinationConnectionStatus.ONLINE);
       header.errorMessage = '';
       header.state = print_preview_new.State.READY;
+      header.managed = false;
       document.body.appendChild(header);
     });
 
@@ -186,13 +171,9 @@ cr.define('header_test', function() {
 
     // Tests that enterprise badge shows up if any setting is managed.
     test(assert(TestNames.EnterprisePolicy), function() {
-      ['color', 'duplex', 'headerFooter'].forEach(settingName => {
-        assertTrue(header.$$('iron-icon').hidden);
-        header.set(`settings.${settingName}.available`, true);
-        header.set(`settings.${settingName}.setByPolicy`, true);
-        assertFalse(header.$$('iron-icon').hidden);
-        header.set(`settings.${settingName}.setByPolicy`, false);
-      });
+      assertTrue(header.$$('iron-icon').hidden);
+      header.managed = true;
+      assertFalse(header.$$('iron-icon').hidden);
     });
   });
 

chrome/test/data/webui/print_preview/settings_section_test.js

@@ -281,6 +281,7 @@ cr.define('settings_sections_tests', function() {
         colorDefault: print_preview.ColorMode.COLOR,
         expectedValue: true,
         expectedHidden: true,
+        expectedManaged: false,
       },
        {
          // Policy contradicts actual capabilities and is ignored.
@@ -289,6 +290,7 @@ cr.define('settings_sections_tests', function() {
          colorDefault: print_preview.ColorMode.GRAY,
          expectedValue: true,
          expectedHidden: true,
+         expectedManaged: false,
        },
        {
          // Policy overrides default.
@@ -330,6 +332,7 @@ cr.define('settings_sections_tests', function() {
         page.set('destination_.policies', policies);
         page.set('destination_.capabilities', capabilities);
         page.$$('print-preview-model').applyDestinationSpecificPolicies();
+        assertEquals(subtestParams.expectedManaged, page.controlsManaged_);
         assertEquals(
             subtestParams.expectedValue, page.getSettingValue('color'));
         assertEquals(subtestParams.expectedHidden, colorElement.hidden);
@@ -360,6 +363,7 @@ cr.define('settings_sections_tests', function() {
         duplexDefault: print_preview.DuplexModeRestriction.SIMPLEX,
         expectedValue: false,
         expectedHidden: true,
+        expectedManaged: false,
       },
        {
          // Policy contradicts actual capabilities and is ignored.
@@ -368,6 +372,7 @@ cr.define('settings_sections_tests', function() {
          duplexDefault: print_preview.DuplexModeRestriction.LONG_EDGE,
          expectedValue: false,
          expectedHidden: true,
+         expectedManaged: false,
        },
        {
          // Policy overrides default.
@@ -409,6 +414,7 @@ cr.define('settings_sections_tests', function() {
         page.set('destination_.policies', policies);
         page.set('destination_.capabilities', capabilities);
         page.$$('print-preview-model').applyDestinationSpecificPolicies();
+        assertEquals(subtestParams.expectedManaged, page.controlsManaged_);
         assertEquals(
             subtestParams.expectedValue, page.getSettingValue('duplex'));
         assertEquals(