Commit 86c30c98 authored by Liquan (Max) Gu's avatar Liquan (Max) Gu Committed by Commit Bot

[PRImpl] Invalid PaymentRequestDetails should cause CPRImpl discardment

Fix a bug introduced from CL https://chromium-review.googlesource.com/c/chromium/src/+/2346730
where the failed parseAndValidateDetailsOrDisconnectFromClient() does
not cause the ComponentPaymentRequestImpl to be discarded by the
MojoPaymentRequestGateKeeper.

Bug: 1102522

Change-Id: I0b99b6aea2ada05e5a0474e3cb93eaed9a4ee789
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363249Reviewed-by: default avatarRouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799141}
parent 291214df
......@@ -434,7 +434,7 @@ public class PaymentRequestImpl
mQueryForQuota.put("basic-card-payment-options", paymentMethodData);
}
if (!parseAndValidateDetailsOrDisconnectFromClient(details)) return true;
if (!parseAndValidateDetailsOrDisconnectFromClient(details)) return false;
mSpec = new PaymentRequestSpec(mPaymentOptions, details, mMethodData.values(),
LocaleUtils.getDefaultLocaleString());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment