[Instant Start] 2 stages initializaton of MostVisitedListCoordinator.

Bug: 1061906
Change-Id: I83b3021e5f0428dc6d2f46b6c2ec4deef75aa8e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623189Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Hao Dong <spdonghao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844943}

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/MostVisitedListCoordinator.java

@@ -49,6 +49,7 @@ class MostVisitedListCoordinator implements TileGroup.Observer, TileGroup.TileSe
     private TileGroup mTileGroup;
     private TileRenderer mRenderer;
     private SuggestionsUiDelegate mSuggestionsUiDelegate;
+    private boolean mInitializationComplete;
 
     public MostVisitedListCoordinator(ChromeActivity activity, ViewGroup parent,
             PropertyModel propertyModel, Supplier<Tab> parentTabSupplier) {
@@ -60,16 +61,25 @@ class MostVisitedListCoordinator implements TileGroup.Observer, TileGroup.TileSe
     }
 
     public void initialize() {
+        mRenderer =
+                new TileRenderer(mActivity, SuggestionsConfig.TileStyle.MODERN, TITLE_LINES, null);
+    }
+
+    public void initWithNative() {
         Profile profile = Profile.getLastUsedRegularProfile();
         SnackbarManager snackbarManager = mActivity.getSnackbarManager();
-        if (mRenderer == null) {
-            // This function is never called in incognito mode.
+        if (!mInitializationComplete) {
             ImageFetcher imageFetcher = new ImageFetcher(profile);
-            mRenderer = new TileRenderer(
-                    mActivity, SuggestionsConfig.TileStyle.MODERN, TITLE_LINES, imageFetcher);
-
             mSuggestionsUiDelegate = new MostVisitedSuggestionsUiDelegate(profile, snackbarManager);
+            if (mRenderer == null) {
+                // This function is never called in incognito mode.
+                mRenderer = new TileRenderer(
+                        mActivity, SuggestionsConfig.TileStyle.MODERN, TITLE_LINES, imageFetcher);
+            } else {
+                mRenderer.setImageFetcher(imageFetcher);
+            }
         }
+
         OfflinePageBridge offlinePageBridge =
                 SuggestionsDependencyFactory.getInstance().getOfflinePageBridge(profile);
         TileGroupDelegateImpl tileGroupDelegate =
@@ -77,6 +87,7 @@ class MostVisitedListCoordinator implements TileGroup.Observer, TileGroup.TileSe
         mTileGroup = new TileGroup(mRenderer, mSuggestionsUiDelegate, null, tileGroupDelegate, this,
                 offlinePageBridge);
         mTileGroup.startObserving(MAX_RESULTS);
+        mInitializationComplete = true;
     }
 
     private void updateTileIcon(Tile tile) {

chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/TasksSurfaceCoordinator.java

@@ -96,6 +96,7 @@ public class TasksSurfaceCoordinator implements TasksSurface {
             LinearLayout mvTilesLayout = mView.findViewById(R.id.mv_tiles_layout);
             mMostVisitedList = new MostVisitedListCoordinator(
                     activity, mvTilesLayout, mPropertyModel, parentTabSupplier);
+            mMostVisitedList.initialize();
         }
     }
 
@@ -104,7 +105,7 @@ public class TasksSurfaceCoordinator implements TasksSurface {
     public void initialize() {
         assert LibraryLoader.getInstance().isInitialized();
 
-        if (mMostVisitedList != null) mMostVisitedList.initialize();
+        if (mMostVisitedList != null) mMostVisitedList.initWithNative();
         mMediator.initialize();
     }
 

chrome/android/java/src/org/chromium/chrome/browser/suggestions/tile/TileRenderer.java

@@ -48,9 +48,9 @@ public class TileRenderer {
     private static final String TAG = "TileRenderer";
 
     private final Resources mResources;
-    private final ImageFetcher mImageFetcher;
     private final RoundedIconGenerator mIconGenerator;
     private final Resources.Theme mTheme;
+    private ImageFetcher mImageFetcher;
 
     @TileStyle
     private final int mStyle;
@@ -121,6 +121,10 @@ public class TileRenderer {
         }
     }
 
+    public void setImageFetcher(ImageFetcher imageFetcher) {
+        mImageFetcher = imageFetcher;
+    }
+
     /**
      * Record that a tile was clicked for IPH reasons.
      */
@@ -166,7 +170,7 @@ public class TileRenderer {
 
         // Note: It is important that the callbacks below don't keep a reference to the tile or
         // modify them as there is no guarantee that the same tile would be used to update the view.
-        if (tile.getSource() != TileSource.EXPLORE) {
+        if (mImageFetcher != null && tile.getSource() != TileSource.EXPLORE) {
             fetchIcon(tile.getData(), setupDelegate.createIconLoadCallback(tile));
         }