Commit 86c7a76e authored by Oksana Zhuravlova's avatar Oksana Zhuravlova Committed by Commit Bot

Reland "[tools/perf] Add app and device usage to WebView power metric"

This is a reland of ebc935dc

Original change's description:
> [tools/perf] Add app and device usage to WebView power metric
> 
> Since webview_power_usage.sql now calculates app power usage and total
> device power usage, this change updates the corresponding tbmv3 metric
> to output these values.
> 
> Bug: b/159154163
> Change-Id: Ia0f788e357837e056ed04b1bd252f9a26d2d07de
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354834
> Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#798739}

Bug: b/159154163
Change-Id: I7ff60a3a009e74d0ab244f7ab83e66840fc4c712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360419Reviewed-by: default avatarMikhail Khokhlov <khokhlov@google.com>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799319}
parent c8d093ac
...@@ -12,13 +12,15 @@ import "protos/perfetto/metrics/custom_options.proto"; ...@@ -12,13 +12,15 @@ import "protos/perfetto/metrics/custom_options.proto";
// Output values are in milliampere-seconds. // Output values are in milliampere-seconds.
message EstimatedWebViewAppPowerUsage { message EstimatedWebViewAppPowerUsage {
string app_name = 1; // process name // Host app package name.
string app_name = 1;
// total app’s power consumption in milliampere-seconds // Total app’s power consumption in milliampere-seconds.
// TODO(b/159154163): make this required. // Includes renderer processes.
optional double total_app_power_mas = 2; double total_app_power_mas = 2;
// this is the sum of the following 3 fields // This is the sum of the following 3 fields.
// Includes renderer processes.
double webview_power_mas = 3; double webview_power_mas = 3;
// TODO(b/159154263): make this required. // TODO(b/159154263): make this required.
...@@ -29,6 +31,9 @@ message EstimatedWebViewAppPowerUsage { ...@@ -29,6 +31,9 @@ message EstimatedWebViewAppPowerUsage {
message WebViewPowerUsageMetric { message WebViewPowerUsageMetric {
repeated EstimatedWebViewAppPowerUsage estimated_webview_app_power_usage = 1; repeated EstimatedWebViewAppPowerUsage estimated_webview_app_power_usage = 1;
// Total power usage of the device (all apps).
double total_device_power_mas = 2;
} }
extend TraceMetrics { extend TraceMetrics {
......
...@@ -14,9 +14,12 @@ SELECT WebViewPowerUsageMetric( ...@@ -14,9 +14,12 @@ SELECT WebViewPowerUsageMetric(
(SELECT RepeatedField( (SELECT RepeatedField(
EstimatedWebViewAppPowerUsage( EstimatedWebViewAppPowerUsage(
'app_name', app_name, 'app_name', app_name,
'webview_power_mas', webview_power_mas 'webview_power_mas', webview_power_mas,
) 'total_app_power_mas', total_app_power_mas
)
) )
FROM webview_power_summary FROM webview_power_summary
) ),
'total_device_power_mas',
(SELECT power_mas FROM total_device_power)
); );
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment