MD Settings: Add MIDI-SysEx to the Site Details page.

Since a driving factor behind releasing the "Site Details" page as part of MD
Settings is to replace default permissions in the Page Info bubble, the list of
permissions shown in "Site Details" should include all permissions shown in
the Page Info bubble. Add MIDI-SysEx to match it.

and check one of the permissions listed there is "MIDI devices".

Bug: 656758
Test: With #enable-site-details turned on, navigate to
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic111c09c17aef557990ae4f522151b294ab84842
chrome: //settings/content/siteDetails?site=https%3A%2F%2Fpermission.site
Reviewed-on: https://chromium-review.googlesource.com/578758
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488604}

chrome/browser/resources/settings/site_settings/site_details.html

@@ -104,6 +104,10 @@
           icon="cr:file-download" id="automaticDownloads"
           label="$i18n{siteSettingsAutomaticDownloads}">
       </site-details-permission>
+      <site-details-permission
+          category="{{ContentSettingsTypes.MIDI_DEVICES}}" icon="settings:midi"
+          id="midiDevices" label="$i18n{siteSettingsMidiDevices}">
+      </site-details-permission>
       <site-details-permission
           category="{{ContentSettingsTypes.UNSANDBOXED_PLUGINS}}"
           icon="cr:extension" id="unsandboxedPlugins"

chrome/test/data/webui/settings/all_sites_tests.js

@@ -64,7 +64,7 @@ var prefsMixedOriginAndPattern = {
     mic: [],
     notifications: [],
     plugins: [],
-    midiDevices: [],
+    midi_devices: [],
     protectedContent: [],
     popups: [],
     unsandboxed_plugins: [],
@@ -102,7 +102,7 @@ var prefsVarious = {
     images: [],
     javascript: [],
     mic: [],
-    midiDevices: [],
+    midi_devices: [],
     notifications: [
       {
         embeddingOrigin: '',

chrome/test/data/webui/settings/site_details_tests.js

@@ -41,6 +41,9 @@ suite('SiteDetails', function() {
         mic: {
           setting: settings.ContentSetting.ASK,
         },
+        midi_devices: {
+          setting: settings.ContentSetting.ASK,
+        },
         notifications: {
           setting: settings.ContentSetting.ASK,
         },
@@ -111,6 +114,14 @@ suite('SiteDetails', function() {
             source: 'preference',
           },
         ],
+        midi_devices: [
+          {
+            embeddingOrigin: 'https://foo.com:443',
+            origin: 'https://foo.com:443',
+            setting: settings.ContentSetting.ALLOW,
+            source: 'preference',
+          },
+        ],
         notifications: [
           {
             embeddingOrigin: 'https://foo.com:443',

chrome/test/data/webui/settings/site_list_tests.js

@@ -46,7 +46,7 @@ var prefsGeolocation = {
     images: [],
     javascript: [],
     mic: [],
-    midiDevices: [],
+    midi_devices: [],
     notifications: [],
     plugins: [],
     protectedContent: [],
@@ -180,7 +180,7 @@ var prefsVarious = {
     images: [],
     javascript: [],
     mic: [],
-    midiDevices: [],
+    midi_devices: [],
     notifications: [
       {
         embeddingOrigin: '',

chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js

@@ -26,7 +26,7 @@ var prefsEmpty = {
     geolocation: {},
     javascript: {},
     mic: {},
-    midiDevices: {},
+    midi_devices: {},
     notifications: {},
     plugins: {},
     images: {},
@@ -42,7 +42,7 @@ var prefsEmpty = {
     geolocation: [],
     javascript: [],
     mic: [],
-    midiDevices: [],
+    midi_devices: [],
     notifications: [],
     plugins: [],
     images: [],
@@ -203,7 +203,7 @@ TestSiteSettingsPrefsBrowserProxy.prototype = {
     } else if (contentType == settings.ContentSettingsTypes.MIC) {
       pref = this.prefs_.defaults.mic;
     } else if (contentType == settings.ContentSettingsTypes.MIDI_DEVICES) {
-      pref = this.prefs_.defaults.midiDevices;
+      pref = this.prefs_.defaults.midi_devices;
     } else if (contentType == settings.ContentSettingsTypes.NOTIFICATIONS) {
       pref = this.prefs_.defaults.notifications;
     } else if (contentType == settings.ContentSettingsTypes.PDF_DOCUMENTS) {
@@ -247,7 +247,7 @@ TestSiteSettingsPrefsBrowserProxy.prototype = {
     else if (contentType == settings.ContentSettingsTypes.MIC)
       pref = this.prefs_.exceptions.mic;
     else if (contentType == settings.ContentSettingsTypes.MIDI_DEVICES)
-      pref = this.prefs_.exceptions.midiDevices;
+      pref = this.prefs_.exceptions.midi_devices;
     else if (contentType == settings.ContentSettingsTypes.NOTIFICATIONS)
       pref = this.prefs_.exceptions.notifications;
     else if (contentType == settings.ContentSettingsTypes.PDF_DOCUMENTS)
@@ -309,6 +309,8 @@ TestSiteSettingsPrefsBrowserProxy.prototype = {
         contentType = 'camera';
       } else if (contentType == settings.ContentSettingsTypes.MIC) {
         contentType = 'mic';
+      } else if (contentType == settings.ContentSettingsTypes.MIDI_DEVICES) {
+        contentType = 'midi_devices';
       } else if (contentType == settings.ContentSettingsTypes.BACKGROUND_SYNC) {
         contentType = 'background_sync';
       } else if (