Commit 86dad9f3 authored by Eric Willigers's avatar Eric Willigers Committed by Commit Bot

Retire VibrateWithoutUserGesture

Since M60, vibrate always requires user gesture.

Remove the feature flag and M59's deprecation message.

BUG=704650

Change-Id: Ifd1bda521e320fb7c0e8b3378117553e18cad833
Reviewed-on: https://chromium-review.googlesource.com/892581Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Reviewed-by: default avatarBryan McQuade <bmcquade@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541750}
parent de4a89f7
......@@ -14,7 +14,6 @@ bool IsAllowedUkmFeature(blink::mojom::WebFeature feature) {
const base::flat_set<WebFeature>, opt_in_features,
({
WebFeature::kNavigatorVibrate, WebFeature::kNavigatorVibrateSubFrame,
WebFeature::kVibrateWithoutUserGesture,
WebFeature::kTouchEventPreventedNoTouchAction,
WebFeature::kTouchEventPreventedForcedDocumentPassiveNoTouchAction,
// kDataUriHasOctothorpe may not be recorded correctly for iframes.
......
......@@ -426,13 +426,6 @@ DeprecationInfo GetDeprecationInfo(WebFeature feature) {
"for more details.",
milestoneString(M62))};
case WebFeature::kVibrateWithoutUserGesture:
return {"VibrateWithoutUserGesture", M60,
willBeRemoved("A call to navigator.vibrate without user tap on "
"the frame or any "
"embedded frame",
M60, "5644273861001216")};
case WebFeature::kChildSrcAllowedWorkerThatScriptSrcBlocked:
return {"ChildSrcAllowedWorkerThatScriptSrcBlocked", M60,
replacedWillBeRemoved("The 'child-src' directive",
......
......@@ -87,16 +87,11 @@ bool NavigatorVibration::vibrate(Navigator& navigator,
"Blocked call to navigator.vibrate inside a cross-origin "
"iframe because the frame has never been activated by the user: "
"https://www.chromestatus.com/feature/5682658461876224.";
} else if (RuntimeEnabledFeatures::VibrateRequiresUserGestureEnabled()) {
// The actual blocking is targeting M60.
} else {
message =
"Blocked call to navigator.vibrate because user hasn't tapped "
"on the frame or any embedded frame yet: "
"https://www.chromestatus.com/feature/5644273861001216.";
} else { // Just shows the deprecation message in M59.
level = kWarningMessageLevel;
Deprecation::CountDeprecation(frame,
WebFeature::kVibrateWithoutUserGesture);
}
if (level == kErrorMessageLevel) {
......
......@@ -1135,10 +1135,6 @@
{
name: "V8IdleTasks",
},
{
name: "VibrateRequiresUserGesture",
status: "stable",
},
{
name: "VideoFullscreenDetection",
},
......
......@@ -1468,7 +1468,6 @@ enum WebFeature {
kRequestMIDIAccessIframeWithSysExOption_ObscuredByFootprinting = 1963,
kGamepadAxes = 1964,
kGamepadButtons = 1965,
kVibrateWithoutUserGesture = 1966,
kDispatchMouseEventOnDisabledFormControl = 1967,
kElementNameDOMInvalidHTMLParserValid = 1968,
kElementNameDOMValidHTMLParserInvalid = 1969,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment