Commit 86e6da59 authored by Eugene But's avatar Eugene But Committed by Commit Bot

[ios] Remove get prefix where unnecessary in components/password_manager

Updated method names to follow Coding Style for Cocoa, where 'get'
prefix should only be used when result is returned indirectly.

Bug: None
Change-Id: I99f1a178af897563e90630ea73492d578c8852bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527513
Auto-Submit: Eugene But <eugenebut@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826743}
parent 7b30e750
...@@ -72,7 +72,7 @@ class WebState; ...@@ -72,7 +72,7 @@ class WebState;
// Retrieves password form fill data for |username| for use in // Retrieves password form fill data for |username| for use in
// |PasswordFormHelper|'s // |PasswordFormHelper|'s
// -fillPasswordFormWithFillData:completionHandler:. // -fillPasswordFormWithFillData:completionHandler:.
- (std::unique_ptr<password_manager::FillData>)getFillDataForUsername: - (std::unique_ptr<password_manager::FillData>)passwordFillDataForUsername:
(NSString*)username; (NSString*)username;
// The following methods should be called to maintain the correct state along // The following methods should be called to maintain the correct state along
......
...@@ -130,7 +130,7 @@ typedef void (^PasswordSuggestionsAvailableCompletion)( ...@@ -130,7 +130,7 @@ typedef void (^PasswordSuggestionsAvailableCompletion)(
formQuery.uniqueFormID, formQuery.uniqueFieldID, isPasswordField)); formQuery.uniqueFormID, formQuery.uniqueFieldID, isPasswordField));
} }
- (std::unique_ptr<password_manager::FillData>)getFillDataForUsername: - (std::unique_ptr<password_manager::FillData>)passwordFillDataForUsername:
(NSString*)username { (NSString*)username {
return _fillData.GetFillData(SysNSStringToUTF16(username)); return _fillData.GetFillData(SysNSStringToUTF16(username));
} }
......
...@@ -402,7 +402,7 @@ NSString* const kSuggestionSuffix = @" ••••••••"; ...@@ -402,7 +402,7 @@ NSString* const kSuggestionSuffix = @" ••••••••";
NSString* username = [suggestion.value NSString* username = [suggestion.value
substringToIndex:suggestion.value.length - kSuggestionSuffix.length]; substringToIndex:suggestion.value.length - kSuggestionSuffix.length];
std::unique_ptr<password_manager::FillData> fillData = std::unique_ptr<password_manager::FillData> fillData =
[self.suggestionHelper getFillDataForUsername:username]; [self.suggestionHelper passwordFillDataForUsername:username];
if (!fillData) { if (!fillData) {
completion(); completion();
...@@ -524,7 +524,7 @@ NSString* const kSuggestionSuffix = @" ••••••••"; ...@@ -524,7 +524,7 @@ NSString* const kSuggestionSuffix = @" ••••••••";
if (![fieldType isEqual:kPasswordFieldType]) if (![fieldType isEqual:kPasswordFieldType])
return NO; return NO;
const PasswordFormGenerationData* generation_data = const PasswordFormGenerationData* generation_data =
[self getFormForGenerationFromFormId:formIdentifier]; [self formForGenerationFromFormID:formIdentifier];
if (!generation_data) if (!generation_data)
return NO; return NO;
...@@ -537,7 +537,7 @@ NSString* const kSuggestionSuffix = @" ••••••••"; ...@@ -537,7 +537,7 @@ NSString* const kSuggestionSuffix = @" ••••••••";
return NO; return NO;
} }
- (const PasswordFormGenerationData*)getFormForGenerationFromFormId: - (const PasswordFormGenerationData*)formForGenerationFromFormID:
(FormRendererId)formIdentifier { (FormRendererId)formIdentifier {
if (_formGenerationData.find(formIdentifier) != _formGenerationData.end()) { if (_formGenerationData.find(formIdentifier) != _formGenerationData.end()) {
return &_formGenerationData[formIdentifier]; return &_formGenerationData[formIdentifier];
...@@ -547,7 +547,7 @@ NSString* const kSuggestionSuffix = @" ••••••••"; ...@@ -547,7 +547,7 @@ NSString* const kSuggestionSuffix = @" ••••••••";
- (void)generatePasswordForFormId:(FormRendererId)formIdentifier - (void)generatePasswordForFormId:(FormRendererId)formIdentifier
fieldIdentifier:(FieldRendererId)fieldIdentifier { fieldIdentifier:(FieldRendererId)fieldIdentifier {
if (![self getFormForGenerationFromFormId:formIdentifier]) if (![self formForGenerationFromFormID:formIdentifier])
return; return;
// TODO(crbug.com/886583): pass correct |max_length|. // TODO(crbug.com/886583): pass correct |max_length|.
...@@ -584,7 +584,7 @@ NSString* const kSuggestionSuffix = @" ••••••••"; ...@@ -584,7 +584,7 @@ NSString* const kSuggestionSuffix = @" ••••••••";
generatedPassword:(NSString*)generatedPassword generatedPassword:(NSString*)generatedPassword
completionHandler:(void (^)())completionHandler { completionHandler:(void (^)())completionHandler {
const autofill::PasswordFormGenerationData* generation_data = const autofill::PasswordFormGenerationData* generation_data =
[self getFormForGenerationFromFormId:formIdentifier]; [self formForGenerationFromFormID:formIdentifier];
if (!generation_data) if (!generation_data)
return; return;
FieldRendererId newPasswordUniqueId = FieldRendererId newPasswordUniqueId =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment